From e76854d1e158feca0a55466fef54b4aa2491b8d8 Mon Sep 17 00:00:00 2001 From: Nathaniel Case Date: Mon, 25 Apr 2022 10:57:04 -0400 Subject: [PATCH] Move check_mode setting to the proper location regardless of version --- changelogs/fragments/check_mode.yaml | 3 +++ docs/ansible.utils.index_of_lookup.rst | 1 + tests/unit/plugins/action/test_fact_diff.py | 3 +++ tests/unit/plugins/action/test_update_fact.py | 3 +++ 4 files changed, 10 insertions(+) create mode 100644 changelogs/fragments/check_mode.yaml diff --git a/changelogs/fragments/check_mode.yaml b/changelogs/fragments/check_mode.yaml new file mode 100644 index 0000000..5a88245 --- /dev/null +++ b/changelogs/fragments/check_mode.yaml @@ -0,0 +1,3 @@ +--- +trivial: + - check_mode has been removed from play_context, set on task instead for unit tests diff --git a/docs/ansible.utils.index_of_lookup.rst b/docs/ansible.utils.index_of_lookup.rst index 13200ba..fd0ed39 100644 --- a/docs/ansible.utils.index_of_lookup.rst +++ b/docs/ansible.utils.index_of_lookup.rst @@ -44,6 +44,7 @@ Parameters
list + / elements=raw / required
diff --git a/tests/unit/plugins/action/test_fact_diff.py b/tests/unit/plugins/action/test_fact_diff.py index 402dfaa..984c832 100644 --- a/tests/unit/plugins/action/test_fact_diff.py +++ b/tests/unit/plugins/action/test_fact_diff.py @@ -25,7 +25,10 @@ except ImportError: class TestUpdate_Fact(unittest.TestCase): def setUp(self): task = MagicMock(Task) + # Ansible > 2.13 looks for check_mode in task + task.check_mode = False play_context = MagicMock() + # Ansible <= 2.13 looks for check_mode in play_context play_context.check_mode = False connection = MagicMock() fake_loader = {} diff --git a/tests/unit/plugins/action/test_update_fact.py b/tests/unit/plugins/action/test_update_fact.py index 9eeb11b..c9d395d 100644 --- a/tests/unit/plugins/action/test_update_fact.py +++ b/tests/unit/plugins/action/test_update_fact.py @@ -81,7 +81,10 @@ INVALID_JINJA = [ class TestUpdate_Fact(unittest.TestCase): def setUp(self): task = MagicMock(Task) + # Ansible > 2.13 looks for check_mode in task + task.check_mode = False play_context = MagicMock() + # Ansible <= 2.13 looks for check_mode in play_context play_context.check_mode = False connection = MagicMock() fake_loader = {}