From 8dc11de0a9184a06b0debb5b7233a1b54d66a8c0 Mon Sep 17 00:00:00 2001 From: Ashwini Mhatre Date: Tue, 23 Jan 2024 12:31:57 +0530 Subject: [PATCH] Avoid unnecessary use of a persistent connection (#326) * Avoid unnecessary use of a persistent connection * Address review comments * Update add_require_Connection.yaml --------- Co-authored-by: Ashwini Mhatre --- changelogs/fragments/add_require_Connection.yaml | 2 ++ plugins/action/cli_parse.py | 2 ++ plugins/action/fact_diff.py | 2 ++ plugins/action/update_fact.py | 2 ++ plugins/action/validate.py | 1 + 5 files changed, 9 insertions(+) create mode 100644 changelogs/fragments/add_require_Connection.yaml diff --git a/changelogs/fragments/add_require_Connection.yaml b/changelogs/fragments/add_require_Connection.yaml new file mode 100644 index 0000000..656b8d1 --- /dev/null +++ b/changelogs/fragments/add_require_Connection.yaml @@ -0,0 +1,2 @@ +bugfixes: + - Avoid unnecessary use of persistent connection in `cli_parse`, `fact_diff`, `update_fact` and `validate` as this action does not require a connection. diff --git a/plugins/action/cli_parse.py b/plugins/action/cli_parse.py index f9314a6..de8b418 100644 --- a/plugins/action/cli_parse.py +++ b/plugins/action/cli_parse.py @@ -37,6 +37,8 @@ ARGSPEC_CONDITIONALS = { class ActionModule(ActionBase): """action module""" + _requires_connection = False + PARSER_CLS_NAME = "CliParser" def __init__(self, *args, **kwargs): diff --git a/plugins/action/fact_diff.py b/plugins/action/fact_diff.py index 85674d3..d9bab66 100644 --- a/plugins/action/fact_diff.py +++ b/plugins/action/fact_diff.py @@ -24,6 +24,8 @@ from ansible_collections.ansible.utils.plugins.modules.fact_diff import DOCUMENT class ActionModule(ActionBase): """action module""" + _requires_connection = False + def __init__(self, *args, **kwargs): super(ActionModule, self).__init__(*args, **kwargs) self._supports_async = True diff --git a/plugins/action/update_fact.py b/plugins/action/update_fact.py index da5f425..32393ed 100644 --- a/plugins/action/update_fact.py +++ b/plugins/action/update_fact.py @@ -26,6 +26,8 @@ from ansible_collections.ansible.utils.plugins.modules.update_fact import DOCUME class ActionModule(ActionBase): """action module""" + _requires_connection = False + def __init__(self, *args, **kwargs): """Start here""" super(ActionModule, self).__init__(*args, **kwargs) diff --git a/plugins/action/validate.py b/plugins/action/validate.py index a2eb306..8b4868d 100644 --- a/plugins/action/validate.py +++ b/plugins/action/validate.py @@ -29,6 +29,7 @@ class ActionModule(ActionBase): """action module""" VALIDATE_CLS_NAME = "Validate" + _requires_connection = False def __init__(self, *args, **kwargs): super(ActionModule, self).__init__(*args, **kwargs)