a-c-m
/
community.crypto
mirror of https://github.com/ansible-collections/community.crypto.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

acme_certificate: be nicer to non-compliant CAs (#832) 

* Be nicer to non-compliant CAs.

* Mark as a feature, not a bugfix.
pull/371/head
Felix Fontein 2024-12-30 11:30:33 +01:00 committed by GitHub
parent db04914ab6
commit 0d4b16aadb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changelogs/fragments/832-acme-challenges.yml Normal file
View File

@ -0,0 +1,3 @@
minor_changes:
- "acme_certificate - add compatibility for ACME CAs that are not fully RFC8555 compliant and do not provide ``challenges`` in authz objects
(https://github.com/ansible-collections/community.crypto/issues/824, https://github.com/ansible-collections/community.crypto/pull/832)."

7
plugins/module_utils/acme/challenges.py
View File

@ -141,7 +141,12 @@ class Authorization(object):
def _setup(self, client, data): def _setup(self, client, data):
data['uri'] = self.url data['uri'] = self.url
self.data = data self.data = data
self.challenges = [Challenge.from_json(client, challenge) for challenge in data['challenges']] # While 'challenges' is a required field, apparently not every CA cares
# (https://github.com/ansible-collections/community.crypto/issues/824)
if data.get('challenges'):
self.challenges = [Challenge.from_json(client, challenge) for challenge in data['challenges']]
else:
self.challenges = []
if client.version == 1 and 'status' not in data: if client.version == 1 and 'status' not in data:
# https://tools.ietf.org/html/draft-ietf-acme-acme-02#section-6.1.2 # https://tools.ietf.org/html/draft-ietf-acme-acme-02#section-6.1.2
# "status (required, string): ... # "status (required, string): ...