a-c-m
/
community.crypto
mirror of https://github.com/ansible-collections/community.crypto.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ecs_certificate: allow to request renewal without csr (#740) (#752) 

* renew request CSR validation

* Create 740-ecs_certificate-renewal-without-csr

* Rename 740-ecs_certificate-renewal-without-csr to 740-ecs_certificate-renewal-without-csr.yml

---------

Co-authored-by: flovecchio <flovecchio@sorint.com>
(cherry picked from commit 29ac3cbe81)

Co-authored-by: francescolovecchio <francescolovecchio97@gmail.com>
pull/756/head
patchback[bot] 2024-05-09 21:31:06 +02:00 committed by GitHub
parent 0ef6494ad2
commit 29ed12e7fd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/740-ecs_certificate-renewal-without-csr.yml Normal file
View File

@ -0,0 +1,2 @@
bugfixes:
- "ecs_certificate - fixed ``csr`` option to be empty and allow renewal of a specific certificate according to the Renewal Information specification (https://github.com/ansible-collections/community.crypto/pull/740)."

4
plugins/modules/ecs_certificate.py
View File

@ -922,8 +922,8 @@ def main():
module.fail_json(msg='The cert_expiry field is invalid when request_type="reissue".') module.fail_json(msg='The cert_expiry field is invalid when request_type="reissue".')
elif module.params['cert_lifetime']: elif module.params['cert_lifetime']:
module.fail_json(msg='The cert_lifetime field is invalid when request_type="reissue".') module.fail_json(msg='The cert_lifetime field is invalid when request_type="reissue".')
# Only a reissued request can omit the CSR # Reissued or renew request can omit the CSR
else: elif module.params['request_type'] != 'renew':
module_params_csr = module.params['csr'] module_params_csr = module.params['csr']
if module_params_csr is None: if module_params_csr is None:
module.fail_json(msg='The csr field is required when request_type={0}'.format(module.params['request_type'])) module.fail_json(msg='The csr field is required when request_type={0}'.format(module.params['request_type']))