a-c-m
/
community.crypto
mirror of https://github.com/ansible-collections/community.crypto.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

openssh_keypair: Populate return values when keypair exists and check_mode=true (#230) 

* Swapping statement order for check_mode to initialize return values

* Adding changelog fragment

* Updated changelog to reflect bugfix
pull/235/head
Ajpantuso 2021-05-12 10:10:08 -04:00 committed by GitHub
parent 3e7362200a
commit 80d64e7b64
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/230-openssh_keypair-check_mode-return-values.yml Normal file
View File

@ -0,0 +1,2 @@
bugfixes:
- openssh_keypair - fix ``check_mode`` to populate return values for existing keypairs (https://github.com/ansible-collections/community.crypto/issues/113, https://github.com/ansible-collections/community.crypto/pull/230).

3
plugins/modules/openssh_keypair.py
View File

@ -590,8 +590,9 @@ def main():
if keypair.state == 'present': if keypair.state == 'present':
if module.check_mode: if module.check_mode:
changed = keypair.force or not keypair.isPrivateKeyValid(module) or not keypair.isPublicKeyValid(module)
result = keypair.dump() result = keypair.dump()
result['changed'] = keypair.force or not keypair.isPrivateKeyValid(module) or not keypair.isPublicKeyValid(module) result['changed'] = changed
module.exit_json(**result) module.exit_json(**result)
try: try:

1
tests/integration/targets/openssh_keypair/tests/validate.yml
View File

@ -9,6 +9,7 @@
- privatekey1_result_check is changed - privatekey1_result_check is changed
- privatekey1_result is changed - privatekey1_result is changed
- privatekey1_idem_result_check is not changed - privatekey1_idem_result_check is not changed
- privatekey1_idem_result_check.public_key.startswith("ssh-rsa")
- privatekey1_idem_result is not changed - privatekey1_idem_result is not changed
- name: Validate privatekey1 return fingerprint - name: Validate privatekey1 return fingerprint