a-c-m
/
community.crypto
mirror of https://github.com/ansible-collections/community.crypto.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix deprecation handling. (#572) (#573) 

(cherry picked from commit 70c4585b88)

Co-authored-by: Felix Fontein <felix@fontein.de>
pull/584/head
patchback[bot] 2023-02-09 16:25:26 +01:00 committed by GitHub
parent 3468628f1f
commit 837733b4c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/572-action-module.yml Normal file
View File

@ -0,0 +1,2 @@
bugfixes:
- "action plugin helper - fix handling of deprecations for ansible-core 2.14.2 (https://github.com/ansible-collections/community.crypto/pull/572)."

11
plugins/plugin_utils/action_module.py
View File

@ -144,9 +144,14 @@ class AnsibleActionModule(object):
# warnings and deprecations that do not work in plugins. This is a copy of that code adjusted # warnings and deprecations that do not work in plugins. This is a copy of that code adjusted
# for our use-case: # for our use-case:
for d in self._validation_result._deprecations: for d in self._validation_result._deprecations:
self.deprecate( # Before ansible-core 2.14.2, deprecations were always for aliases:
"Alias '{name}' is deprecated. See the module docs for more information".format(name=d['name']), if 'name' in d:
version=d.get('version'), date=d.get('date'), collection_name=d.get('collection_name')) self.deprecate(
"Alias '{name}' is deprecated. See the module docs for more information".format(name=d['name']),
version=d.get('version'), date=d.get('date'), collection_name=d.get('collection_name'))
# Since ansible-core 2.14.2, a message is present that can be directly printed:
if 'msg' in d:
self.deprecate(d['msg'], version=d.get('version'), date=d.get('date'), collection_name=d.get('collection_name'))
for w in self._validation_result._warnings: for w in self._validation_result._warnings:
self.warn('Both option {option} and its alias {alias} are set.'.format(option=w['option'], alias=w['alias'])) self.warn('Both option {option} and its alias {alias} are set.'.format(option=w['option'], alias=w['alias']))