a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
community.general/changelogs/fragments/811-proxmox-kvm-state-absen...

4 lines
236 B
YAML
Raw Normal View History

proxmox_kvm: fix idempotency issue with state=absent (#811) When the `vmid` parameter is not supplied and the module can only rely on name look-up an early failure can happen if the targeted VM doesn't exist. In this case a task execution with the parameter `state` set to `absent` will actually fail instead of being considered ok. This patch introduces a deferred error-checking for non-existent VMs by assigning the value -1 to the `vmid` parameter, allowing the actual verification to be performed in the right code paths. Is also help to differentiate between a non-existent `vmid` or non-existent VM `name`. Previously: TASK [ansible-role-proxmox-instance : Remove instance-test] changed: [localhost] ... TASK [ansible-role-proxmox-instance : Remove instance-test] fatal: [localhost]: FAILED! => changed=false msg: VM instance-test does not exist in cluster. Now: TASK [ansible-role-proxmox-instance : Remove instance-test] ok: [localhost] ... TASK [ansible-role-proxmox-instance : Remove instance-test] ok: [localhost] Update changelogs/fragments/811-proxmox-kvm-state-absent.yml With suggestions from Felix Fontein <felix@fontein.de>.
2020-09-04 22:51:54 +00:00
---
bugfixes:
- proxmox_kvm - defer error-checking for non-existent VMs in order to fix idempotency of tasks using ``state=absent`` and properly recognize a success (https://github.com/ansible-collections/community.general/pull/811).