a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
community.general/changelogs/fragments/2454-detect_zfs_changed.yml

3 lines
292 B
YAML
Raw Normal View History

Avoid incorrectly marking zfs tasks as changed (#2454) * Avoid incorrectly marking zfs tasks as changed The zfs module will incorrectly mark certain tasks as having been changed. For example, if a dataset has a quota of "1G" and the user changes it to "1024M", the actual quota vale has not changed, but since the module is doing a simple string comparison between "1G" and "1024M", it marks the step as "changed". Instead of trying to handle all the corner cases of zfs (another example is when the zpool "altroot" property has been set), this change simply compares the output of "zfs-get" from before and after "zfs-set" is called * update changelog format * Update changelogs/fragments/2454-detect_zfs_changed.yml Co-authored-by: Felix Fontein <felix@fontein.de> * add note about check_mode * Update plugins/modules/storage/zfs/zfs.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/storage/zfs/zfs.py Co-authored-by: Felix Fontein <felix@fontein.de> * clarify check mode qualifications * rephrase to avoid hypothetical Co-authored-by: Felix Fontein <felix@fontein.de>
2021-05-10 15:55:19 +00:00
bugfixes:
- zfs - certain ZFS properties, especially sizes, would lead to a task being falsely marked as "changed" even when no actual change was made (https://github.com/ansible-collections/community.general/issues/975, https://github.com/ansible-collections/community.general/pull/2454).