community.general/lib/ansible/modules/packaging/os/dnf.py

1294 lines
50 KiB
Python
Raw Normal View History

#!/usr/bin/python
# -*- coding: utf-8 -*-
# Copyright 2015 Cristian van Ee <cristian at cvee.org>
# Copyright 2015 Igor Gnatenko <i.gnatenko.brain@gmail.com>
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Copyright 2018 Adam Miller <admiller@redhat.com>
#
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
from __future__ import absolute_import, division, print_function
__metaclass__ = type
2017-08-16 03:16:38 +00:00
ANSIBLE_METADATA = {'metadata_version': '1.1',
'status': ['stableinterface'],
'supported_by': 'core'}
2016-12-06 10:35:25 +00:00
DOCUMENTATION = '''
---
module: dnf
version_added: 1.9
short_description: Manages packages with the I(dnf) package manager
description:
- Installs, upgrade, removes, and lists packages and groups with the I(dnf) package manager.
options:
name:
description:
- "A package name or package specifier with version, like C(name-1.0).
When using state=latest, this can be '*' which means run: dnf -y update.
You can also pass a url or a local path to a rpm file.
To operate on several packages this can accept a comma separated string of packages or a list of packages."
required: true
aliases:
- pkg
list:
description:
- Various (non-idempotent) commands for usage with C(/usr/bin/ansible) and I(not) playbooks. See examples.
state:
description:
- Whether to install (C(present), C(latest)), or remove (C(absent)) a package.
- Default is C(None), however in effect the default action is C(present) unless the C(autoremove) option is
enabled for this module, then C(absent) is inferred.
choices: ['absent', 'present', 'installed', 'removed', 'latest']
enablerepo:
description:
- I(Repoid) of repositories to enable for the install/update operation.
These repos will not persist beyond the transaction.
When specifying multiple repos, separate them with a ",".
2016-12-08 14:38:05 +00:00
disablerepo:
description:
- I(Repoid) of repositories to disable for the install/update operation.
These repos will not persist beyond the transaction.
When specifying multiple repos, separate them with a ",".
conf_file:
description:
- The remote dnf configuration file to use for the transaction.
disable_gpg_check:
description:
- Whether to disable the GPG checking of signatures of packages being
installed. Has an effect only if state is I(present) or I(latest).
type: bool
default: 'no'
installroot:
description:
- Specifies an alternative installroot, relative to which all packages
will be installed.
version_added: "2.3"
default: "/"
releasever:
description:
- Specifies an alternative release from which all packages will be
installed.
version_added: "2.6"
autoremove:
description:
- If C(yes), removes all "leaf" packages from the system that were originally
installed as dependencies of user-installed packages but which are no longer
required by any such package. Should be used alone or when state is I(absent)
type: bool
default: "no"
version_added: "2.4"
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
exclude:
description:
- Package name(s) to exclude when state=present, or latest. This can be a
list or a comma separated string.
version_added: "2.7"
skip_broken:
description:
- Skip packages with broken dependencies(devsolve) and are causing problems.
type: bool
default: "no"
version_added: "2.7"
update_cache:
description:
- Force dnf to check if cache is out of date and redownload if needed.
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
Has an effect only if state is I(present) or I(latest).
type: bool
default: "no"
aliases: [ expire-cache ]
version_added: "2.7"
update_only:
description:
- When using latest, only update installed packages. Do not install packages.
- Has an effect only if state is I(latest)
default: "no"
type: bool
version_added: "2.7"
security:
description:
- If set to C(yes), and C(state=latest) then only installs updates that have been marked security related.
type: bool
default: "no"
version_added: "2.7"
bugfix:
description:
- If set to C(yes), and C(state=latest) then only installs updates that have been marked bugfix related.
default: "no"
type: bool
version_added: "2.7"
enable_plugin:
description:
- I(Plugin) name to enable for the install/update operation.
The enabled plugin will not persist beyond the transaction.
version_added: "2.7"
disable_plugin:
description:
- I(Plugin) name to disable for the install/update operation.
The disabled plugins will not persist beyond the transaction.
version_added: "2.7"
disable_excludes:
description:
- Disable the excludes defined in DNF config files.
- If set to C(all), disables all excludes.
- If set to C(main), disable excludes defined in [main] in dnf.conf.
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
- If set to C(repoid), disable excludes defined for given repo id.
version_added: "2.7"
validate_certs:
description:
- This only applies if using a https url as the source of the rpm. e.g. for localinstall. If set to C(no), the SSL certificates will not be validated.
- This should only set to C(no) used on personally controlled sites using self-signed certificates as it avoids verifying the source site.
type: bool
default: "yes"
version_added: "2.7"
allow_downgrade:
description:
- Specify if the named package and version is allowed to downgrade
a maybe already installed higher version of that package.
Note that setting allow_downgrade=True can make this module
behave in a non-idempotent way. The task could end up with a set
of packages that does not match the complete list of specified
packages to install (because dependencies between the downgraded
package and others can cause changes to the packages which were
in the earlier transaction).
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
type: bool
default: "no"
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
version_added: "2.7"
install_repoquery:
description:
- This is effectively a no-op in DNF as it is not needed with DNF, but is an accepted parameter for feature
parity/compatibility with the I(yum) module.
type: bool
default: "yes"
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
version_added: "2.7"
download_only:
description:
- Only download the packages, do not install them.
default: "no"
type: bool
version_added: "2.7"
lock_timeout:
description:
2018-10-19 18:18:09 +00:00
- Amount of time to wait for the dnf lockfile to be freed.
required: false
2018-10-19 18:18:09 +00:00
default: 0
type: int
version_added: "2.8"
install_weak_deps:
description:
- Will also install all packages linked by a weak dependency relation.
type: bool
default: "yes"
version_added: "2.8"
download_dir:
description:
- Specifies an alternate directory to store packages.
- Has an effect only if I(download_only) is specified.
type: str
version_added: "2.8"
notes:
- When used with a `loop:` each package will be processed individually, it is much more efficient to pass the list directly to the `name` option.
- Group removal doesn't work if the group was installed with Ansible because
upstream dnf's API doesn't properly mark groups as installed, therefore upon
removal the module is unable to detect that the group is installed
(https://bugzilla.redhat.com/show_bug.cgi?id=1620324)
requirements:
- "python >= 2.6"
- python-dnf
- for the autoremove option you need dnf >= 2.0.1"
author:
- Igor Gnatenko (@ignatenkobrain) <i.gnatenko.brain@gmail.com>
- Cristian van Ee (@DJMuggs) <cristian at cvee.org>
- Berend De Schouwer (@berenddeschouwer)
- Adam Miller (@maxamillion) <admiller@redhat.com>
'''
EXAMPLES = '''
- name: install the latest version of Apache
dnf:
name: httpd
state: latest
- name: install the latest version of Apache and MariaDB
dnf:
name:
- httpd
- mariadb-server
state: latest
- name: remove the Apache package
dnf:
name: httpd
state: absent
- name: install the latest version of Apache from the testing repo
dnf:
name: httpd
enablerepo: testing
state: present
- name: upgrade all packages
dnf:
name: "*"
state: latest
- name: install the nginx rpm from a remote repo
dnf:
name: 'http://nginx.org/packages/centos/6/noarch/RPMS/nginx-release-centos-6-0.el6.ngx.noarch.rpm'
state: present
- name: install nginx rpm from a local file
dnf:
name: /usr/local/src/nginx-release-centos-6-0.el6.ngx.noarch.rpm
state: present
- name: install the 'Development tools' package group
dnf:
name: '@Development tools'
state: present
- name: Autoremove unneeded packages installed as dependencies
dnf:
autoremove: yes
- name: Uninstall httpd but keep its dependencies
dnf:
name: httpd
state: absent
autoremove: no
- name: install a modularity appstream with defined stream and profile
dnf:
name: '@postgresql:9.6/client'
state: present
- name: install a modularity appstream with defined stream
dnf:
name: '@postgresql:9.6'
state: present
- name: install a modularity appstream with defined profile
dnf:
name: '@postgresql/client'
state: present
'''
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
import os
import re
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
import tempfile
try:
import dnf
import dnf.cli
import dnf.const
import dnf.exceptions
import dnf.subject
import dnf.util
HAS_DNF = True
except ImportError:
HAS_DNF = False
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
from ansible.module_utils._text import to_native, to_text
from ansible.module_utils.urls import fetch_url
from ansible.module_utils.six import PY2, text_type
from distutils.version import LooseVersion
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.yumdnf import YumDnf, yumdnf_argument_spec
# 64k. Number of bytes to read at a time when manually downloading pkgs via a url
BUFSIZE = 65536
class DnfModule(YumDnf):
"""
DNF Ansible module back-end implementation
"""
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
def __init__(self, module):
# This populates instance vars for all argument spec params
super(DnfModule, self).__init__(module)
self._ensure_dnf()
self.lockfile = "/var/cache/dnf/*_lock.pid"
self.pkg_mgr_name = "dnf"
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
try:
self.with_modules = dnf.base.WITH_MODULES
except AttributeError:
self.with_modules = False
def _sanitize_dnf_error_msg(self, spec, error):
"""
For unhandled dnf.exceptions.Error scenarios, there are certain error
messages we want to filter. Do that here.
"""
if to_text("no package matched") in to_text(error):
return "No package {0} available.".format(spec)
return error
def _package_dict(self, package):
"""Return a dictionary of information for the package."""
# NOTE: This no longer contains the 'dnfstate' field because it is
# already known based on the query type.
result = {
'name': package.name,
'arch': package.arch,
'epoch': str(package.epoch),
'release': package.release,
'version': package.version,
'repo': package.repoid}
result['nevra'] = '{epoch}:{name}-{version}-{release}.{arch}'.format(
**result)
if package.installtime == 0:
result['yumstate'] = 'available'
else:
result['yumstate'] = 'installed'
return result
def _packagename_dict(self, packagename):
"""
Return a dictionary of information for a package name string or None
if the package name doesn't contain at least all NVR elements
"""
if packagename[-4:] == '.rpm':
packagename = packagename[:-4]
# This list was auto generated on a Fedora 28 system with the following one-liner
# printf '[ '; for arch in $(ls /usr/lib/rpm/platform); do printf '"%s", ' ${arch%-linux}; done; printf ']\n'
redhat_rpm_arches = [
"aarch64", "alphaev56", "alphaev5", "alphaev67", "alphaev6", "alpha",
"alphapca56", "amd64", "armv3l", "armv4b", "armv4l", "armv5tejl", "armv5tel",
"armv5tl", "armv6hl", "armv6l", "armv7hl", "armv7hnl", "armv7l", "athlon",
"geode", "i386", "i486", "i586", "i686", "ia32e", "ia64", "m68k", "mips64el",
"mips64", "mips64r6el", "mips64r6", "mipsel", "mips", "mipsr6el", "mipsr6",
"noarch", "pentium3", "pentium4", "ppc32dy4", "ppc64iseries", "ppc64le", "ppc64",
"ppc64p7", "ppc64pseries", "ppc8260", "ppc8560", "ppciseries", "ppc", "ppcpseries",
"riscv64", "s390", "s390x", "sh3", "sh4a", "sh4", "sh", "sparc64", "sparc64v",
"sparc", "sparcv8", "sparcv9", "sparcv9v", "x86_64"
]
rpm_arch_re = re.compile(r'(.*)\.(.*)')
rpm_nevr_re = re.compile(r'(\S+)-(?:(\d*):)?(.*)-(~?\w+[\w.+]*)')
try:
arch = None
rpm_arch_match = rpm_arch_re.match(packagename)
if rpm_arch_match:
nevr, arch = rpm_arch_match.groups()
if arch in redhat_rpm_arches:
packagename = nevr
rpm_nevr_match = rpm_nevr_re.match(packagename)
if rpm_nevr_match:
name, epoch, version, release = rpm_nevr_re.match(packagename).groups()
if not version or not version.split('.')[0].isdigit():
return None
else:
return None
except AttributeError as e:
self.module.fail_json(
msg='Error attempting to parse package: %s, %s' % (packagename, to_native(e)),
rc=1,
results=[]
)
if not epoch:
epoch = "0"
if ':' in name:
epoch_name = name.split(":")
epoch = epoch_name[0]
name = ''.join(epoch_name[1:])
result = {
'name': name,
'epoch': epoch,
'release': release,
'version': version,
}
return result
# Original implementation from yum.rpmUtils.miscutils (GPLv2+)
# http://yum.baseurl.org/gitweb?p=yum.git;a=blob;f=rpmUtils/miscutils.py
def _compare_evr(self, e1, v1, r1, e2, v2, r2):
# return 1: a is newer than b
# 0: a and b are the same version
# -1: b is newer than a
if e1 is None:
e1 = '0'
else:
e1 = str(e1)
v1 = str(v1)
r1 = str(r1)
if e2 is None:
e2 = '0'
else:
e2 = str(e2)
v2 = str(v2)
r2 = str(r2)
# print '%s, %s, %s vs %s, %s, %s' % (e1, v1, r1, e2, v2, r2)
rc = dnf.rpm.rpm.labelCompare((e1, v1, r1), (e2, v2, r2))
# print '%s, %s, %s vs %s, %s, %s = %s' % (e1, v1, r1, e2, v2, r2, rc)
return rc
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
def fetch_rpm_from_url(self, spec):
# FIXME: Remove this once this PR is merged:
# https://github.com/ansible/ansible/pull/19172
# download package so that we can query it
package_name, dummy = os.path.splitext(str(spec.rsplit('/', 1)[1]))
package_file = tempfile.NamedTemporaryFile(dir=self.module.tmpdir, prefix=package_name, suffix='.rpm', delete=False)
self.module.add_cleanup_file(package_file.name)
try:
rsp, info = fetch_url(self.module, spec)
if not rsp:
self.module.fail_json(
msg="Failure downloading %s, %s" % (spec, info['msg']),
results=[],
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
data = rsp.read(BUFSIZE)
while data:
package_file.write(data)
data = rsp.read(BUFSIZE)
package_file.close()
except Exception as e:
self.module.fail_json(
msg="Failure downloading %s, %s" % (spec, to_native(e)),
results=[],
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
return package_file.name
def _ensure_dnf(self):
if not HAS_DNF:
if PY2:
package = 'python2-dnf'
else:
package = 'python3-dnf'
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
if self.module.check_mode:
self.module.fail_json(
msg="`{0}` is not installed, but it is required"
"for the Ansible dnf module.".format(package),
results=[],
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
)
self.module.run_command(['dnf', 'install', '-y', package], check_rc=True)
global dnf
try:
import dnf
import dnf.cli
import dnf.const
import dnf.exceptions
import dnf.subject
import dnf.util
except ImportError:
self.module.fail_json(
msg="Could not import the dnf python module. "
"Please install `{0}` package.".format(package),
results=[],
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
)
def _configure_base(self, base, conf_file, disable_gpg_check, installroot='/'):
"""Configure the dnf Base object."""
conf = base.conf
2019-01-03 20:25:58 +00:00
# Change the configuration file path if provided, this must be done before conf.read() is called
if conf_file:
# Fail if we can't read the configuration file.
if not os.access(conf_file, os.R_OK):
self.module.fail_json(
msg="cannot read configuration file", conf_file=conf_file,
results=[],
)
else:
conf.config_file_path = conf_file
# Read the configuration file
conf.read()
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Turn off debug messages in the output
conf.debuglevel = 0
# Set whether to check gpg signatures
conf.gpgcheck = not disable_gpg_check
conf.localpkg_gpgcheck = not disable_gpg_check
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Don't prompt for user confirmations
conf.assumeyes = True
# Set installroot
conf.installroot = installroot
# Load substitutions from the filesystem
conf.substitutions.update_from_etc(installroot)
# Handle different DNF versions immutable mutable datatypes and
# dnf v1/v2/v3
#
# In DNF < 3.0 are lists, and modifying them works
# In DNF >= 3.0 < 3.6 are lists, but modifying them doesn't work
# In DNF >= 3.6 have been turned into tuples, to communicate that modifying them doesn't work
#
# https://www.happyassassin.net/2018/06/27/adams-debugging-adventures-the-immutable-mutable-object/
#
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Set excludes
if self.exclude:
_excludes = list(conf.exclude)
_excludes.extend(self.exclude)
conf.exclude = _excludes
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Set disable_excludes
if self.disable_excludes:
_disable_excludes = list(conf.disable_excludes)
if self.disable_excludes not in _disable_excludes:
_disable_excludes.append(self.disable_excludes)
conf.disable_excludes = _disable_excludes
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Set releasever
if self.releasever is not None:
conf.substitutions['releasever'] = self.releasever
# Set skip_broken (in dnf this is strict=0)
if self.skip_broken:
conf.strict = 0
if self.download_only:
conf.downloadonly = True
if self.download_dir:
conf.destdir = self.download_dir
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Default in dnf upstream is true
conf.clean_requirements_on_remove = self.autoremove
# Default in dnf (and module default) is True
conf.install_weak_deps = self.install_weak_deps
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
def _specify_repositories(self, base, disablerepo, enablerepo):
"""Enable and disable repositories matching the provided patterns."""
base.read_all_repos()
repos = base.repos
# Disable repositories
for repo_pattern in disablerepo:
if repo_pattern:
for repo in repos.get_matching(repo_pattern):
repo.disable()
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Enable repositories
for repo_pattern in enablerepo:
if repo_pattern:
for repo in repos.get_matching(repo_pattern):
repo.enable()
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
def _base(self, conf_file, disable_gpg_check, disablerepo, enablerepo, installroot):
"""Return a fully configured dnf Base object."""
base = dnf.Base()
self._configure_base(base, conf_file, disable_gpg_check, installroot)
try:
base.init_plugins(set(self.disable_plugin), set(self.enable_plugin))
base.pre_configure_plugins()
except AttributeError:
pass # older versions of dnf didn't require this and don't have these methods
self._specify_repositories(base, disablerepo, enablerepo)
try:
base.configure_plugins()
except AttributeError:
pass # older versions of dnf didn't require this and don't have these methods
try:
if self.update_cache:
try:
base.update_cache()
except dnf.exceptions.RepoError as e:
self.module.fail_json(
msg="{0}".format(to_text(e)),
results=[],
rc=1
)
base.fill_sack(load_system_repo='auto')
except dnf.exceptions.RepoError as e:
self.module.fail_json(
msg="{0}".format(to_text(e)),
results=[],
rc=1
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
if self.bugfix:
key = {'advisory_type__eq': 'bugfix'}
base._update_security_filters = [base.sack.query().filter(**key)]
if self.security:
key = {'advisory_type__eq': 'security'}
base._update_security_filters = [base.sack.query().filter(**key)]
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
return base
def list_items(self, command):
"""List package info based on the command."""
# Rename updates to upgrades
if command == 'updates':
command = 'upgrades'
# Return the corresponding packages
if command in ['installed', 'upgrades', 'available']:
results = [
self._package_dict(package)
for package in getattr(self.base.sack.query(), command)()]
# Return the enabled repository ids
elif command in ['repos', 'repositories']:
results = [
{'repoid': repo.id, 'state': 'enabled'}
for repo in self.base.repos.iter_enabled()]
# Return any matching packages
else:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
packages = dnf.subject.Subject(command).get_best_query(self.base.sack)
results = [self._package_dict(package) for package in packages]
self.module.exit_json(msg="", results=results)
def _is_installed(self, pkg):
installed = self.base.sack.query().installed()
if installed.filter(name=pkg):
return True
else:
return False
def _is_newer_version_installed(self, pkg_name):
candidate_pkg = self._packagename_dict(pkg_name)
if not candidate_pkg:
# The user didn't provide a versioned rpm, so version checking is
# not required
return False
installed = self.base.sack.query().installed()
installed_pkg = installed.filter(name=candidate_pkg['name']).run()
if installed_pkg:
installed_pkg = installed_pkg[0]
# this looks weird but one is a dict and the other is a dnf.Package
evr_cmp = self._compare_evr(
installed_pkg.epoch, installed_pkg.version, installed_pkg.release,
candidate_pkg['epoch'], candidate_pkg['version'], candidate_pkg['release'],
)
if evr_cmp == 1:
return True
else:
return False
else:
return False
def _mark_package_install(self, pkg_spec, upgrade=False):
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
"""Mark the package for install."""
is_newer_version_installed = self._is_newer_version_installed(pkg_spec)
is_installed = self._is_installed(pkg_spec)
try:
if self.allow_downgrade:
# dnf only does allow_downgrade, we have to handle this ourselves
# because it allows a possibility for non-idempotent transactions
# on a system's package set (pending the yum repo has many old
# NVRs indexed)
if upgrade:
if is_installed:
self.base.upgrade(pkg_spec)
else:
self.base.install(pkg_spec)
else:
self.base.install(pkg_spec)
elif not self.allow_downgrade and is_newer_version_installed:
return {'failed': False, 'msg': '', 'failure': '', 'rc': 0}
elif not is_newer_version_installed:
if upgrade:
if is_installed:
self.base.upgrade(pkg_spec)
else:
self.base.install(pkg_spec)
else:
self.base.install(pkg_spec)
else:
if upgrade:
if is_installed:
self.base.upgrade(pkg_spec)
else:
self.base.install(pkg_spec)
else:
self.base.install(pkg_spec)
return {'failed': False, 'msg': 'Installed: {0}'.format(pkg_spec), 'failure': '', 'rc': 0}
except dnf.exceptions.MarkingError as e:
return {
'failed': True,
'msg': "No package {0} available.".format(pkg_spec),
'failure': " ".join((pkg_spec, to_native(e))),
'rc': 1,
"results": []
}
except dnf.exceptions.DepsolveError as e:
return {
'failed': True,
'msg': "Depsolve Error occured for package {0}.".format(pkg_spec),
'failure': " ".join((pkg_spec, to_native(e))),
'rc': 1,
"results": []
}
except dnf.exceptions.Error as e:
if to_text("already installed") in to_text(e):
return {'failed': False, 'msg': '', 'failure': ''}
else:
return {
'failed': True,
'msg': "Unknown Error occured for package {0}.".format(pkg_spec),
'failure': " ".join((pkg_spec, to_native(e))),
'rc': 1,
"results": []
}
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
def _whatprovides(self, filepath):
available = self.base.sack.query().available()
pkg_spec = available.filter(provides=filepath).run()
if pkg_spec:
return pkg_spec[0].name
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
def _parse_spec_group_file(self):
pkg_specs, grp_specs, module_specs, filenames = [], [], [], []
already_loaded_comps = False # Only load this if necessary, it's slow
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
for name in self.names:
if '://' in name:
name = self.fetch_rpm_from_url(name)
filenames.append(name)
elif name.endswith(".rpm"):
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
filenames.append(name)
elif name.startswith("@") or ('/' in name):
# like "dnf install /usr/bin/vi"
if '/' in name:
pkg_spec = self._whatprovides(name)
if pkg_spec:
pkg_specs.append(pkg_spec)
continue
if not already_loaded_comps:
self.base.read_comps()
already_loaded_comps = True
grp_env_mdl_candidate = name[1:].strip()
if self.with_modules:
mdl = self.module_base._get_modules(grp_env_mdl_candidate)
if mdl[0]:
module_specs.append(grp_env_mdl_candidate)
else:
grp_specs.append(grp_env_mdl_candidate)
else:
grp_specs.append(grp_env_mdl_candidate)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
else:
pkg_specs.append(name)
return pkg_specs, grp_specs, module_specs, filenames
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
def _update_only(self, pkgs):
not_installed = []
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
for pkg in pkgs:
if self._is_installed(pkg):
try:
if isinstance(to_text(pkg), text_type):
self.base.upgrade(pkg)
else:
self.base.package_upgrade(pkg)
except Exception as e:
self.module.fail_json(
msg="Error occured attempting update_only operation: {0}".format(to_native(e)),
results=[],
rc=1,
)
else:
not_installed.append(pkg)
return not_installed
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
def _install_remote_rpms(self, filenames):
if int(dnf.__version__.split(".")[0]) >= 2:
pkgs = list(sorted(self.base.add_remote_rpms(list(filenames)), reverse=True))
else:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
pkgs = []
try:
for filename in filenames:
pkgs.append(self.base.add_remote_rpm(filename))
except IOError as e:
if to_text("Can not load RPM file") in to_text(e):
self.module.fail_json(
msg="Error occured attempting remote rpm install of package: {0}. {1}".format(filename, to_native(e)),
results=[],
rc=1,
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
if self.update_only:
self._update_only(pkgs)
else:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
for pkg in pkgs:
try:
if self._is_newer_version_installed(self._package_dict(pkg)['nevra']):
if self.allow_downgrade:
self.base.package_install(pkg)
else:
2019-02-14 02:39:26 +00:00
self.base.package_install(pkg)
except Exception as e:
self.module.fail_json(
msg="Error occured attempting remote rpm operation: {0}".format(to_native(e)),
results=[],
rc=1,
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
def _is_module_installed(self, module_spec):
if self.with_modules:
module_spec = module_spec.strip()
module_list, nsv = self.module_base._get_modules(module_spec)
if nsv.stream in self.base._moduleContainer.getEnabledStream(nsv.name):
return True
return False # seems like a sane default
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
def ensure(self):
allow_erasing = False
response = {
'msg': "",
'changed': False,
'results': [],
'rc': 0
}
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Accumulate failures. Package management modules install what they can
# and fail with a message about what they can't.
failure_response = {
'msg': "",
'failures': [],
'results': [],
'rc': 1
}
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Autoremove is called alone
# Jump to remove path where base.autoremove() is run
if not self.names and self.autoremove:
self.names = []
self.state = 'absent'
if self.names == ['*'] and self.state == 'latest':
try:
self.base.upgrade_all()
except dnf.exceptions.DepsolveError as e:
failure_response['msg'] = "Depsolve Error occured attempting to upgrade all packages"
self.module.fail_json(**failure_response)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
else:
pkg_specs, group_specs, module_specs, filenames = self._parse_spec_group_file()
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
pkg_specs = [p.strip() for p in pkg_specs]
filenames = [f.strip() for f in filenames]
groups = []
environments = []
for group_spec in (g.strip() for g in group_specs):
group = self.base.comps.group_by_pattern(group_spec)
if group:
groups.append(group.id)
else:
environment = self.base.comps.environment_by_pattern(group_spec)
if environment:
environments.append(environment.id)
else:
self.module.fail_json(
msg="No group {0} available.".format(group_spec),
results=[],
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
if self.state in ['installed', 'present']:
# Install files.
self._install_remote_rpms(filenames)
for filename in filenames:
response['results'].append("Installed {0}".format(filename))
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Install modules
if module_specs and self.with_modules:
for module in module_specs:
try:
if not self._is_module_installed(module):
response['results'].append("Module {0} installed.".format(module))
self.module_base.install([module])
self.module_base.enable([module])
except dnf.exceptions.MarkingErrors as e:
failure_response['failures'].append(
" ".join(
(
' '.join(module),
to_native(e)
)
)
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Install groups.
for group in groups:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
try:
group_pkg_count_installed = self.base.group_install(group, dnf.const.GROUP_PACKAGE_TYPES)
if group_pkg_count_installed == 0:
response['results'].append("Group {0} already installed.".format(group))
else:
response['results'].append("Group {0} installed.".format(group))
except dnf.exceptions.DepsolveError as e:
failure_response['msg'] = "Depsolve Error occured attempting to install group: {0}".format(group)
self.module.fail_json(**failure_response)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
except dnf.exceptions.Error as e:
# In dnf 2.0 if all the mandatory packages in a group do
# not install, an error is raised. We want to capture
# this but still install as much as possible.
failure_response['failures'].append(" ".join((group, to_native(e))))
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
for environment in environments:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
try:
self.base.environment_install(environment, dnf.const.GROUP_PACKAGE_TYPES)
except dnf.exceptions.DepsolveError as e:
failure_response['msg'] = "Depsolve Error occured attempting to install environment: {0}".format(environment)
self.module.fail_json(**failure_response)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
except dnf.exceptions.Error as e:
failure_response['failures'].append(" ".join((environment, to_native(e))))
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
if module_specs and not self.with_modules:
# This means that the group or env wasn't found in comps
self.module.fail_json(
msg="No group {0} available.".format(module_specs[0]),
results=[],
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Install packages.
if self.update_only:
not_installed = self._update_only(pkg_specs)
for spec in not_installed:
response['results'].append("Packages providing %s not installed due to update_only specified" % spec)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
else:
for pkg_spec in pkg_specs:
install_result = self._mark_package_install(pkg_spec)
if install_result['failed']:
failure_response['msg'] += install_result['msg']
failure_response['failures'].append(self._sanitize_dnf_error_msg(pkg_spec, install_result['failure']))
else:
response['results'].append(install_result['msg'])
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
elif self.state == 'latest':
# "latest" is same as "installed" for filenames.
self._install_remote_rpms(filenames)
for filename in filenames:
response['results'].append("Installed {0}".format(filename))
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Upgrade modules
if module_specs and self.with_modules:
for module in module_specs:
try:
if self._is_module_installed(module):
response['results'].append("Module {0} upgraded.".format(module))
self.module_base.upgrade([module])
except dnf.exceptions.MarkingErrors as e:
failure_response['failures'].append(
" ".join(
(
' '.join(module),
to_native(e)
)
)
)
for group in groups:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
try:
try:
self.base.group_upgrade(group)
response['results'].append("Group {0} upgraded.".format(group))
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
except dnf.exceptions.CompsError:
if not self.update_only:
# If not already installed, try to install.
group_pkg_count_installed = self.base.group_install(group, dnf.const.GROUP_PACKAGE_TYPES)
if group_pkg_count_installed == 0:
response['results'].append("Group {0} already installed.".format(group))
else:
response['results'].append("Group {0} installed.".format(group))
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
except dnf.exceptions.Error as e:
failure_response['failures'].append(" ".join((group, to_native(e))))
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
for environment in environments:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
try:
try:
self.base.environment_upgrade(environment)
except dnf.exceptions.CompsError:
# If not already installed, try to install.
self.base.environment_install(environment, dnf.const.GROUP_PACKAGE_TYPES)
except dnf.exceptions.DepsolveError as e:
failure_response['msg'] = "Depsolve Error occured attempting to install environment: {0}".format(environment)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
except dnf.exceptions.Error as e:
failure_response['failures'].append(" ".join((environment, to_native(e))))
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
if self.update_only:
not_installed = self._update_only(pkg_specs)
for spec in not_installed:
response['results'].append("Packages providing %s not installed due to update_only specified" % spec)
else:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
for pkg_spec in pkg_specs:
# best effort causes to install the latest package
# even if not previously installed
self.base.conf.best = True
install_result = self._mark_package_install(pkg_spec, upgrade=True)
if install_result['failed']:
failure_response['msg'] += install_result['msg']
failure_response['failures'].append(self._sanitize_dnf_error_msg(pkg_spec, install_result['failure']))
else:
response['results'].append(install_result['msg'])
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
else:
# state == absent
if filenames:
self.module.fail_json(
msg="Cannot remove paths -- please specify package name.",
results=[],
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Remove modules
if module_specs and self.with_modules:
for module in module_specs:
try:
if self._is_module_installed(module):
response['results'].append("Module {0} removed.".format(module))
self.module_base.remove([module])
self.module_base.disable([module])
self.module_base.reset([module])
except dnf.exceptions.MarkingErrors as e:
failure_response['failures'].append(
" ".join(
(
' '.join(module),
to_native(e)
)
)
)
for group in groups:
try:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
self.base.group_remove(group)
except dnf.exceptions.CompsError:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Group is already uninstalled.
pass
except AttributeError:
# Group either isn't installed or wasn't marked installed at install time
# because of DNF bug
#
# This is necessary until the upstream dnf API bug is fixed where installing
# a group via the dnf API doesn't actually mark the group as installed
# https://bugzilla.redhat.com/show_bug.cgi?id=1620324
pass
for environment in environments:
try:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
self.base.environment_remove(environment)
except dnf.exceptions.CompsError:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Environment is already uninstalled.
pass
installed = self.base.sack.query().installed()
for pkg_spec in pkg_specs:
# short-circuit installed check for wildcard matching
if '*' in pkg_spec:
try:
self.base.remove(pkg_spec)
except dnf.exceptions.MarkingError as e:
failure_response['failures'].append('{0} - {1}'.format(pkg_spec, to_native(e)))
continue
installed_pkg = list(map(str, installed.filter(name=pkg_spec).run()))
if installed_pkg:
candidate_pkg = self._packagename_dict(installed_pkg[0])
installed_pkg = installed.filter(name=candidate_pkg['name']).run()
else:
candidate_pkg = self._packagename_dict(pkg_spec)
installed_pkg = installed.filter(nevra=pkg_spec).run()
if installed_pkg:
installed_pkg = installed_pkg[0]
evr_cmp = self._compare_evr(
installed_pkg.epoch, installed_pkg.version, installed_pkg.release,
candidate_pkg['epoch'], candidate_pkg['version'], candidate_pkg['release'],
)
if evr_cmp == 0:
self.base.remove(pkg_spec)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Like the dnf CLI we want to allow recursive removal of dependent
# packages
allow_erasing = True
if self.autoremove:
self.base.autoremove()
2015-07-09 21:00:22 +00:00
try:
if not self.base.resolve(allow_erasing=allow_erasing):
if failure_response['failures']:
failure_response['msg'] = 'Failed to install some of the specified packages'
self.module.fail_json(**failure_response)
response['msg'] = "Nothing to do"
self.module.exit_json(**response)
else:
response['changed'] = True
if failure_response['failures']:
failure_response['msg'] = 'Failed to install some of the specified packages',
self.module.fail_json(**failure_response)
if self.module.check_mode:
response['msg'] = "Check mode: No changes made, but would have if not in check mode"
self.module.exit_json(**response)
try:
if self.download_only and self.download_dir and self.base.conf.destdir:
dnf.util.ensure_dir(self.base.conf.destdir)
self.base.repos.all().pkgdir = self.base.conf.destdir
self.base.download_packages(self.base.transaction.install_set)
except dnf.exceptions.DownloadError as e:
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
self.module.fail_json(
msg="Failed to download packages: {0}".format(to_text(e)),
results=[],
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
)
if self.download_only:
for package in self.base.transaction.install_set:
response['results'].append("Downloaded: {0}".format(package))
self.module.exit_json(**response)
else:
self.base.do_transaction()
for package in self.base.transaction.install_set:
response['results'].append("Installed: {0}".format(package))
for package in self.base.transaction.remove_set:
response['results'].append("Removed: {0}".format(package))
if failure_response['failures']:
failure_response['msg'] = 'Failed to install some of the specified packages',
self.module.exit_json(**response)
self.module.exit_json(**response)
except dnf.exceptions.DepsolveError as e:
failure_response['msg'] = "Depsolve Error occured: {0}".format(to_native(e))
self.module.fail_json(**failure_response)
except dnf.exceptions.Error as e:
if to_text("already installed") in to_text(e):
response['changed'] = False
response['results'].append("Package already installed: {0}".format(to_native(e)))
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
self.module.exit_json(**response)
else:
failure_response['msg'] = "Unknown Error occured: {0}".format(to_native(e))
self.module.fail_json(**failure_response)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
@staticmethod
def has_dnf():
return HAS_DNF
def run(self):
"""The main function."""
# Check if autoremove is called correctly
if self.autoremove:
if LooseVersion(dnf.__version__) < LooseVersion('2.0.1'):
self.module.fail_json(
msg="Autoremove requires dnf>=2.0.1. Current dnf version is %s" % dnf.__version__,
results=[],
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Check if download_dir is called correctly
if self.download_dir:
if LooseVersion(dnf.__version__) < LooseVersion('2.6.2'):
self.module.fail_json(
msg="download_dir requires dnf>=2.6.2. Current dnf version is %s" % dnf.__version__,
results=[],
)
if self.update_cache and not self.names and not self.list:
self.base = self._base(
self.conf_file, self.disable_gpg_check, self.disablerepo,
self.enablerepo, self.installroot
)
self.module.exit_json(
msg="Cache updated",
changed=False,
results=[],
rc=0
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# Set state as installed by default
# This is not set in AnsibleModule() because the following shouldn't happend
# - dnf: autoremove=yes state=installed
if self.state is None:
self.state = 'installed'
if self.list:
self.base = self._base(
self.conf_file, self.disable_gpg_check, self.disablerepo,
self.enablerepo, self.installroot
)
self.list_items(self.list)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
else:
# Note: base takes a long time to run so we want to check for failure
# before running it.
if not dnf.util.am_i_root():
self.module.fail_json(
msg="This command has to be run under the root user.",
results=[],
)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
self.base = self._base(
self.conf_file, self.disable_gpg_check, self.disablerepo,
self.enablerepo, self.installroot
)
if self.with_modules:
self.module_base = dnf.module.module_base.ModuleBase(self.base)
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
self.ensure()
def main():
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
# state=installed name=pkgspec
# state=removed name=pkgspec
# state=latest name=pkgspec
#
# informational commands:
# list=installed
# list=updates
# list=available
# list=repos
# list=pkgspec
module = AnsibleModule(
Refactor yum and dnf, add feature parity (#43621) * Refactor yum and dnf, add feature parity Signed-off-by: Adam Miller <admiller@redhat.com> * remove unnecessary module_utils, move the classes into the module code Signed-off-by: Adam Miller <admiller@redhat.com> * remove yum -> yum4, out of scope Signed-off-by: Adam Miller <admiller@redhat.com> * use ABCMeta Signed-off-by: Adam Miller <admiller@redhat.com> * re-arrange run() caller vs callee Signed-off-by: Adam Miller <admiller@redhat.com> * make sanity checks happy Signed-off-by: Adam Miller <admiller@redhat.com> * fix yum unit tests Signed-off-by: Adam Miller <admiller@redhat.com> * remove unecessary debug statements, fix typo Signed-off-by: Adam Miller <admiller@redhat.com> * fix licensing and attribution in yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * include fix from PR 40737 original commit 5cbda9658ab13d45a210c0581458327a4d975bcc original Author: Strahinja Kustudic <kustodian@gmail.com> yum will fail on 'No space left on device', fixes #32791 (#40737) During the installing of packages if yum runs out of free disk space, some post install scripts could fail (like e.g. when the kernel package generates initramfs), but yum would still exit with a status 0. This is bad, especially for the kernel package, because it makes it unable to boot. Because the yum module is usually used for automation, which means the users cannot read every message yum prints, it's better that the yum module fails if it detects that there is no free space on the disk. Signed-off-by: Adam Miller <admiller@redhat.com> * Revert "fix licensing and attribution in yumdnf module_util" This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd. * move fetch_rpm_from_url out of yumdnf module_util Signed-off-by: Adam Miller <admiller@redhat.com> * fix the move of fetch_rpm_from_url Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 15:15:11 +00:00
**yumdnf_argument_spec
)
module_implementation = DnfModule(module)
try:
module_implementation.run()
except dnf.exceptions.RepoError as de:
module.fail_json(
msg="Failed to synchronize repodata: {0}".format(to_native(de)),
rc=1,
results=[],
changed=False
)
if __name__ == '__main__':
main()