a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(opentelemetry): close span even if no logs are sent (#8367) 

* fix(opentelemetry): close span even if no logs are sent

* changelog
pull/8392/head
Victor Martinez 2024-05-19 20:50:03 +02:00 committed by GitHub
parent d87b9fe0dc
commit 03240ad7dc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/8367-fix-close-span-if-no-logs.yaml Normal file
View File

@ -0,0 +1,2 @@
bugfixes:
- "opentelemetry callback plugin - close spans always (https://github.com/ansible-collections/community.general/pull/8367)."

3
plugins/callback/opentelemetry.py
View File

@ -402,7 +402,8 @@ class OpenTelemetrySource(object):
if not disable_logs: if not disable_logs:
# This will avoid populating span attributes to the logs # This will avoid populating span attributes to the logs
span.add_event(task_data.dump, attributes={} if disable_attributes_in_logs else attributes) span.add_event(task_data.dump, attributes={} if disable_attributes_in_logs else attributes)
span.end(end_time=host_data.finish) # Close span always
span.end(end_time=host_data.finish)
def set_span_attributes(self, span, attributes): def set_span_attributes(self, span, attributes):
""" update the span attributes with the given attributes if not None """ """ update the span attributes with the given attributes if not None """