From 055c18c892ecf6ad31998f4501e74a7e24227f8d Mon Sep 17 00:00:00 2001 From: Lucas Basquerotto Date: Wed, 29 Apr 2020 03:28:10 -0300 Subject: [PATCH] cloudflare_dns: fix KeyError (#243) Fix errors of the type KeyError: 'success' to show a more meaningful message Fixes: #236 --- changelogs/fragments/243-cloudflare_dns_fix_keyerror.yml | 2 ++ plugins/modules/net_tools/cloudflare_dns.py | 4 ++++ 2 files changed, 6 insertions(+) create mode 100644 changelogs/fragments/243-cloudflare_dns_fix_keyerror.yml diff --git a/changelogs/fragments/243-cloudflare_dns_fix_keyerror.yml b/changelogs/fragments/243-cloudflare_dns_fix_keyerror.yml new file mode 100644 index 0000000000..ce0baf17ca --- /dev/null +++ b/changelogs/fragments/243-cloudflare_dns_fix_keyerror.yml @@ -0,0 +1,2 @@ +bugfixes: + - cloudflare_dns - fix KeyError 'success' (https://github.com/ansible-collections/community.general/issues/236). diff --git a/plugins/modules/net_tools/cloudflare_dns.py b/plugins/modules/net_tools/cloudflare_dns.py index ee9704e9e5..4e2d16afb7 100644 --- a/plugins/modules/net_tools/cloudflare_dns.py +++ b/plugins/modules/net_tools/cloudflare_dns.py @@ -496,6 +496,10 @@ class CloudflareAPI(object): if result is None: self.module.fail_json(msg=error_msg) + if 'success' not in result: + error_msg += "; Unexpected error details: {0}".format(result.get('error')) + self.module.fail_json(msg=error_msg) + if not result['success']: error_msg += "; Error details: " for error in result['errors']: