a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add idempotency in snapshot creation (#28466) 

Fix adds idempotent behavior while creating snapshot

Fixes: #24511

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
pull/4420/head
Abhijeet Kasurde 2017-12-15 08:34:39 +05:30 committed by GitHub
parent 36f82ae8cc
commit 08a2338277
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/ansible/modules/cloud/vmware/vmware_guest_snapshot.py
View File

@ -240,8 +240,13 @@ class PyVmomiHelper(PyVmomi):
def snapshot_vm(self, vm): def snapshot_vm(self, vm):
memory_dump = False memory_dump = False
quiesce = False quiesce = False
# Check if Virtual Machine provides capabilities for Quiesce and Memory # Check if there is a latest snapshot already present as specified by user
# Snapshots snap_obj = self.get_snapshots_by_name_recursively(vm.snapshot.rootSnapshotList,
self.module.params["snapshot_name"])
if snap_obj:
# Snapshot already exists, do not anything.
self.module.exit_json(changed=False, msg="Snapshot named [%(snapshot_name)s] already exists." % self.module.params)
# Check if Virtual Machine provides capabilities for Quiesce and Memory Snapshots
if vm.capability.quiescedSnapshotsSupported: if vm.capability.quiescedSnapshotsSupported:
quiesce = self.module.params['quiesce'] quiesce = self.module.params['quiesce']
if vm.capability.memorySnapshotsSupported: if vm.capability.memorySnapshotsSupported:
@ -257,7 +262,6 @@ class PyVmomiHelper(PyVmomi):
self.module.fail_json(msg="Failed to take snapshot due to VMware Licence: %s" % to_native(exc.msg)) self.module.fail_json(msg="Failed to take snapshot due to VMware Licence: %s" % to_native(exc.msg))
except Exception as exc: except Exception as exc:
self.module.fail_json(msg="Failed to create snapshot of VM %s due to %s" % (self.module.params['name'], to_native(exc))) self.module.fail_json(msg="Failed to create snapshot of VM %s due to %s" % (self.module.params['name'], to_native(exc)))
return task return task
def rename_snapshot(self, vm): def rename_snapshot(self, vm):
@ -282,7 +286,6 @@ class PyVmomiHelper(PyVmomi):
msg="Couldn't find any snapshots with specified name: %s on VM: %s" % msg="Couldn't find any snapshots with specified name: %s on VM: %s" %
(self.module.params["snapshot_name"], (self.module.params["snapshot_name"],
self.module.params.get('uuid') or self.module.params.get('name'))) self.module.params.get('uuid') or self.module.params.get('name')))
return task return task
def remove_or_revert_snapshot(self, vm): def remove_or_revert_snapshot(self, vm):