a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

manageiq_alert_profiles: improve handling param requirements (#9449) 

* manageiq_alert_profiles: improve handling param requirements

Basically two changes:
* `name` is already required when state is either present or absent, and there are no other states, so making it fully required and removing the conditional
* `alerts` is documented as required when state=present, this has been verified in the code, so added that parameter to the existing `required_if` spec.

* add changelog frag
pull/9431/head
Alexei Znamensky 2024-12-30 07:44:32 +13:00 committed by GitHub
parent 5f47127ef7
commit 0bbc3eccd9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/9449-manageiq-alert-profiles-reqs.yml Normal file
View File

@ -0,0 +1,2 @@
minor_changes:
- manageiq_alert_profiles - improve handling of parameter requirements (https://github.com/ansible-collections/community.general/pull/9449).

13
plugins/modules/manageiq_alert_profiles.py
View File

@ -37,7 +37,7 @@ options:
type: str type: str
description: description:
- The unique alert profile name in ManageIQ. - The unique alert profile name in ManageIQ.
- Required when state is "absent" or "present". required: true
resource_type: resource_type:
type: str type: str
description: description:
@ -114,8 +114,7 @@ class ManageIQAlertProfiles(object):
""" """
alerts = [] alerts = []
for alert_description in alert_descriptions: for alert_description in alert_descriptions:
alert = self.manageiq.find_collection_resource_or_fail("alert_definitions", alert = self.manageiq.find_collection_resource_or_fail("alert_definitions", description=alert_description)
description=alert_description)
alerts.append(alert['href']) alerts.append(alert['href'])
return alerts return alerts
@ -253,7 +252,7 @@ class ManageIQAlertProfiles(object):
def main(): def main():
argument_spec = dict( argument_spec = dict(
name=dict(type='str'), name=dict(type='str', required=True),
resource_type=dict(type='str', choices=['Vm', resource_type=dict(type='str', choices=['Vm',
'ContainerNode', 'ContainerNode',
'MiqServer', 'MiqServer',
@ -270,8 +269,7 @@ def main():
argument_spec.update(manageiq_argument_spec()) argument_spec.update(manageiq_argument_spec())
module = AnsibleModule(argument_spec=argument_spec, module = AnsibleModule(argument_spec=argument_spec,
required_if=[('state', 'present', ['name', 'resource_type']), required_if=[('state', 'present', ['resource_type', 'alerts'])])
('state', 'absent', ['name'])])
state = module.params['state'] state = module.params['state']
name = module.params['name'] name = module.params['name']
@ -279,8 +277,7 @@ def main():
manageiq = ManageIQ(module) manageiq = ManageIQ(module)
manageiq_alert_profiles = ManageIQAlertProfiles(manageiq) manageiq_alert_profiles = ManageIQAlertProfiles(manageiq)
existing_profile = manageiq.find_collection_resource_by("alert_definition_profiles", existing_profile = manageiq.find_collection_resource_by("alert_definition_profiles", name=name)
name=name)
# we need to add or update the alert profile # we need to add or update the alert profile
if state == "present": if state == "present":