From 0bd4b3cbc95c615a5b2f9bb07a523744279eb596 Mon Sep 17 00:00:00 2001 From: Alexei Znamensky <103110+russoz@users.noreply.github.com> Date: Mon, 4 Jan 2021 01:35:46 +1300 Subject: [PATCH] changed make parameter from --question to -q (#1574) * changed make parameter from --question to -q * changelog fragment * Update changelogs/fragments/1574-make-question.yaml Co-authored-by: Felix Fontein Co-authored-by: Abhijeet Kasurde Co-authored-by: Felix Fontein --- changelogs/fragments/1574-make-question.yaml | 2 ++ plugins/modules/system/make.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/1574-make-question.yaml diff --git a/changelogs/fragments/1574-make-question.yaml b/changelogs/fragments/1574-make-question.yaml new file mode 100644 index 0000000000..b2590f3e5b --- /dev/null +++ b/changelogs/fragments/1574-make-question.yaml @@ -0,0 +1,2 @@ +bugfixes: + - make - fixed ``make`` parameter used for check mode when running a non-GNU ``make`` (https://github.com/ansible-collections/community.general/pull/1574). diff --git a/plugins/modules/system/make.py b/plugins/modules/system/make.py index c8d4107c6f..7314af2809 100644 --- a/plugins/modules/system/make.py +++ b/plugins/modules/system/make.py @@ -136,7 +136,7 @@ def main(): base_command.extend(make_parameters) # Check if the target is already up to date - rc, out, err = run_command(base_command + ['--question'], module, check_rc=False) + rc, out, err = run_command(base_command + ['-q'], module, check_rc=False) if module.check_mode: # If we've been asked to do a dry run, we only need # to report whether or not the target is up to date