a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

osx_defaults: Fix boolean value parsing 

Values for boolean types were being unconditionally treated as strings
(by calling `.lower()`), thus breaking value parsing for actual boolean
and integer objects.

It looks like the bug was introduced in:

- 130bd670d82cc55fa321021e819838e07ff10c08

Fixes #709.
pull/4420/head
Tom X. Tobin 2016-01-14 12:44:05 -05:00 committed by Matt Clay
parent 9d355fb5af
commit 1223143ebe
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/ansible/modules/extras/system/osx_defaults.py
View File

@ -124,9 +124,11 @@ class OSXDefaults(object):
if type == "string": if type == "string":
return str(value) return str(value)
elif type in ["bool", "boolean"]: elif type in ["bool", "boolean"]:
if value.lower() in [True, 1, "true", "1", "yes"]: if isinstance(value, basestring):
value = value.lower()
if value in [True, 1, "true", "1", "yes"]:
return True return True
elif value.lower() in [False, 0, "false", "0", "no"]: elif value in [False, 0, "false", "0", "no"]:
return False return False
raise OSXDefaultsException("Invalid boolean value: {0}".format(repr(value))) raise OSXDefaultsException("Invalid boolean value: {0}".format(repr(value)))
elif type == "date": elif type == "date":