a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

selective: mark task failed correctly (#629) 

Added additional condition to detect failed task in
selective callback plugin when ran with loop or with_items.

Fixes: ansible/ansible#63767

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
pull/643/head
Abhijeet Kasurde 2020-07-12 03:56:58 +05:30 committed by GitHub
parent b31de003bd
commit 151551b04f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/63767_selective.yml Normal file
View File

@ -0,0 +1,2 @@
bugfixes:
- selective - mark task failed correctly (https://github.com/ansible/ansible/issues/63767).

2
plugins/callback/selective.py
View File

@ -201,7 +201,7 @@ class CallbackModule(CallbackBase):
) )
if 'results' in result._result: if 'results' in result._result:
for r in result._result['results']: for r in result._result['results']:
failed = 'failed' in r failed = 'failed' in r and r['failed']
stderr = [r.get('exception', None), r.get('module_stderr', None)] stderr = [r.get('exception', None), r.get('module_stderr', None)]
stderr = "\n".join([e for e in stderr if e]).strip() stderr = "\n".join([e for e in stderr if e]).strip()