a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

redfish_config: fix support for boolean BIOS attributes (#189) 

Currently the redfish_config module will convert boolean bios_attribute_value
settings to strings (type str). This will cause BMCs expecting booleans to
error out.

This PR will change the default type of bios_attribute_value to 'raw' in order
to support strings and booleans.

Fixes #68251
pull/191/head
Jacob 2020-04-16 02:56:24 -04:00 committed by GitHub
parent d54581dddc
commit 15e961c2ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changelogs/fragments/68251-redfish_config-fix-boolean-bios-attr-support.yaml Normal file
View File

@ -0,0 +1,3 @@
---
bugfixes:
- redfish_config - fix support for boolean bios attrs (https://github.com/ansible/ansible/pull/68251)

4
plugins/modules/remote_management/redfish/redfish_config.py
View File

@ -57,7 +57,7 @@ options:
description: description:
- value of BIOS attr to update (deprecated - use bios_attributes instead) - value of BIOS attr to update (deprecated - use bios_attributes instead)
default: 'null' default: 'null'
type: str type: raw
bios_attributes: bios_attributes:
required: false required: false
description: description:
@ -230,7 +230,7 @@ def main():
username=dict(required=True), username=dict(required=True),
password=dict(required=True, no_log=True), password=dict(required=True, no_log=True),
bios_attribute_name=dict(default='null'), bios_attribute_name=dict(default='null'),
bios_attribute_value=dict(default='null'), bios_attribute_value=dict(default='null', type='raw'),
bios_attributes=dict(type='dict', default={}), bios_attributes=dict(type='dict', default={}),
timeout=dict(type='int', default=10), timeout=dict(type='int', default=10),
boot_order=dict(type='list', elements='str', default=[]), boot_order=dict(type='list', elements='str', default=[]),