From 1bdf8fc02545acd73faf988088ea0f187f3f909f Mon Sep 17 00:00:00 2001 From: salty Date: Mon, 7 Oct 2024 22:14:52 +0200 Subject: [PATCH] cloudflare_dns: Update SRV record handling for Cloudflare API changes (#8948) --- changelogs/fragments/8679-fix-cloudflare-srv.yml | 2 ++ plugins/modules/cloudflare_dns.py | 10 ++++++---- 2 files changed, 8 insertions(+), 4 deletions(-) create mode 100644 changelogs/fragments/8679-fix-cloudflare-srv.yml diff --git a/changelogs/fragments/8679-fix-cloudflare-srv.yml b/changelogs/fragments/8679-fix-cloudflare-srv.yml new file mode 100644 index 0000000000..bf00fc1305 --- /dev/null +++ b/changelogs/fragments/8679-fix-cloudflare-srv.yml @@ -0,0 +1,2 @@ +bugfixes: + - cloudflare_dns - fix changing Cloudflare SRV records (https://github.com/ansible-collections/community.general/issues/8679, https://github.com/ansible-collections/community.general/pull/8948). diff --git a/plugins/modules/cloudflare_dns.py b/plugins/modules/cloudflare_dns.py index 1904976440..86550966be 100644 --- a/plugins/modules/cloudflare_dns.py +++ b/plugins/modules/cloudflare_dns.py @@ -716,12 +716,14 @@ class CloudflareAPI(object): "port": params['port'], "weight": params['weight'], "priority": params['priority'], - "name": params['record'], - "proto": params['proto'], - "service": params['service'] } - new_record = {"type": params['type'], "ttl": params['ttl'], 'data': srv_data} + new_record = { + "type": params['type'], + "name": params['service'] + '.' + params['proto'] + '.' + params['record'], + "ttl": params['ttl'], + 'data': srv_data, + } search_value = str(params['weight']) + '\t' + str(params['port']) + '\t' + params['value'] search_record = params['service'] + '.' + params['proto'] + '.' + params['record']