a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[PR #9012/67ddb567 backport][stable-9] Dell PwrButton requires a job initated at reboot (#9015) 

Dell PwrButton requires a job initated at reboot (#9012)

Dell systems do not change the bios setting PwrButton right away. The
command will return changed=true, but it is not applied. Also no job is
scheduled at next reboot for the change to take place. This patch aims
to fix this issue.

(cherry picked from commit 67ddb567c9)

Co-authored-by: Ruben Bosch <8641284+Rubueno@users.noreply.github.com>
pull/9023/head
patchback[bot] 2024-10-10 22:24:53 +02:00 committed by GitHub
parent 6f98adf602
commit 21a840eab7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
changelogs/fragments/9012-dell-pwrbutton-requires-a-job-initiated-at-reboot.yml Normal file
View File

@ -0,0 +1,4 @@
minor_changes:
- redfish_utils module utils - schedule a BIOS configuration job at next
reboot when the BIOS config is changed
(https://github.com/ansible-collections/community.general/pull/9012).

10
plugins/module_utils/redfish_utils.py
View File

@ -2311,11 +2311,19 @@ class RedfishUtils(object):
# Construct payload and issue PATCH command # Construct payload and issue PATCH command
payload = {"Attributes": attrs_to_patch} payload = {"Attributes": attrs_to_patch}
# WORKAROUND
# Dell systems require manually setting the apply time to "OnReset"
# to spawn a proprietary job to apply the BIOS settings
vendor = self._get_vendor()['Vendor']
if vendor == 'Dell':
payload.update({"@Redfish.SettingsApplyTime": {"ApplyTime": "OnReset"}})
response = self.patch_request(self.root_uri + set_bios_attr_uri, payload) response = self.patch_request(self.root_uri + set_bios_attr_uri, payload)
if response['ret'] is False: if response['ret'] is False:
return response return response
return {'ret': True, 'changed': True, return {'ret': True, 'changed': True,
'msg': "Modified BIOS attributes %s" % (attrs_to_patch), 'msg': "Modified BIOS attributes %s. A reboot is required" % (attrs_to_patch),
'warning': warning} 'warning': warning}
def set_boot_order(self, boot_list): def set_boot_order(self, boot_list):