From 2f67d3a4f33f9d7261ffa3f82595aa99f32bc527 Mon Sep 17 00:00:00 2001 From: Alex Date: Wed, 13 Dec 2017 20:05:20 +0100 Subject: [PATCH] facts: Fix duplicate IPs in ipv4_secondaries (#32040) --- lib/ansible/module_utils/facts/network/linux.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/ansible/module_utils/facts/network/linux.py b/lib/ansible/module_utils/facts/network/linux.py index 95e3bfd5ff..eddb1df5bd 100644 --- a/lib/ansible/module_utils/facts/network/linux.py +++ b/lib/ansible/module_utils/facts/network/linux.py @@ -206,12 +206,13 @@ class LinuxNetwork(Network): if secondary: if "ipv4_secondaries" not in interfaces[device]: interfaces[device]["ipv4_secondaries"] = [] - interfaces[device]["ipv4_secondaries"].append({ - 'address': address, - 'broadcast': broadcast, - 'netmask': netmask, - 'network': network, - }) + if device != iface: + interfaces[device]["ipv4_secondaries"].append({ + 'address': address, + 'broadcast': broadcast, + 'netmask': netmask, + 'network': network, + }) # NOTE: default_ipv4 is ref to outside scope # If this is the default address, update default_ipv4