a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix VerifyBiosAttributes command on Systems with multiple entries (#9234) 

* Fix verify_bios_attributes command

* Add changelog fragment

* Update changelogs/fragments/9234-fix-verify-bios-attributes-multi-system.yml

Improve fragment

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

---------

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
pull/9259/head
Scott Seekamp 2024-12-14 02:44:33 -07:00 committed by GitHub
parent 88ea025d12
commit 34e8e8e5d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/9234-fix-verify-bios-attributes-multi-system.yml Normal file
View File

@ -0,0 +1,2 @@
bugfixes:
- redfish_utils module utils - Fix ``VerifyBiosAttributes`` command on multi system resource nodes (https://github.com/ansible-collections/community.general/pull/9234).

6
plugins/module_utils/redfish_utils.py
View File

@ -3616,7 +3616,7 @@ class RedfishUtils(object):
def verify_bios_attributes(self, bios_attributes): def verify_bios_attributes(self, bios_attributes):
# This method verifies BIOS attributes against the provided input # This method verifies BIOS attributes against the provided input
server_bios = self.get_multi_bios_attributes() server_bios = self.get_bios_attributes(self.systems_uri)
if server_bios["ret"] is False: if server_bios["ret"] is False:
return server_bios return server_bios
@ -3625,8 +3625,8 @@ class RedfishUtils(object):
# Verify bios_attributes with BIOS settings available in the server # Verify bios_attributes with BIOS settings available in the server
for key, value in bios_attributes.items(): for key, value in bios_attributes.items():
if key in server_bios["entries"][0][1]: if key in server_bios["entries"]:
if server_bios["entries"][0][1][key] != value: if server_bios["entries"][key] != value:
bios_dict.update({key: value}) bios_dict.update({key: value})
else: else:
wrong_param.update({key: value}) wrong_param.update({key: value})