Remove deprecated features scheduled for removal in 3.0.0 (#1926)

* Remove deprecated features.

* Remove ignore.txt entries.

* Update changelogs/fragments/remove-deprecated-features.yml

Co-authored-by: Joe Adams <adams10301@gmail.com>

Co-authored-by: Joe Adams <adams10301@gmail.com>
pull/803/head
Felix Fontein 2021-03-09 21:23:20 +01:00 committed by GitHub
parent 1ca9229c66
commit 36daa7c48e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
16 changed files with 58 additions and 208 deletions

View File

@ -0,0 +1,16 @@
removed_features:
- "airbrake_deployment - removed deprecated ``token`` parameter. Use ``project_id`` and ``project_key`` instead."
- "bigpanda - the alias ``message`` has been removed. Use ``deployment_message`` instead."
- "cisco_spark, cisco_webex - the alias ``message`` has been removed. Use ``msg`` instead."
- "clc_aa_policy - the ``wait`` parameter has been removed. It did not have any effect."
- "datadog_monitor - the alias ``message`` has been removed. Use ``notification_message`` instead."
- "django_manage - the parameter ``liveserver`` has been removed."
- "idrac_redfish_config - the parameters ``manager_attribute_name`` and ``manager_attribute_value`` have been removed. Use ``manager_attributes`` instead."
- "iso_extract - the alias ``thirsty`` has been removed. Use ``force`` instead."
- "redfish_config - the parameters ``bios_attribute_name`` and ``bios_attribute_value`` have been removed. Use ``bios_attributes`` instead."
- "syspatch - the ``apply`` parameter has been removed. This is the default mode, so simply removing it will not change the behavior."
- "xbps - the ``force`` parameter has been removed. It did not have any effect."
- "redfish modules - issuing a data modification command without specifying the ID of the target System, Chassis or Manager resource when there is more than one is no longer allowed. Use the ``resource_id`` option to specify the target ID."
- "pulp_repo - the alias ``ca_cert`` has been removed. Use ``feed_ca_cert`` instead."
- "pulp_repo - the ``feed_client_cert`` parameter no longer defaults to the value of the ``client_cert`` parameter."
- "pulp_repo - the ``feed_client_key`` parameter no longer defaults to the value of the ``client_key`` parameter."

View File

@ -19,11 +19,10 @@ PATCH_HEADERS = {'content-type': 'application/json', 'accept': 'application/json
'OData-Version': '4.0'} 'OData-Version': '4.0'}
DELETE_HEADERS = {'accept': 'application/json', 'OData-Version': '4.0'} DELETE_HEADERS = {'accept': 'application/json', 'OData-Version': '4.0'}
DEPRECATE_MSG = 'Issuing a data modification command without specifying the '\ FAIL_MSG = 'Issuing a data modification command without specifying the '\
'ID of the target %(resource)s resource when there is more '\ 'ID of the target %(resource)s resource when there is more '\
'than one %(resource)s will use the first one in the '\ 'than one %(resource)s is no longer allowed. Use the `resource_id` '\
'collection. Use the `resource_id` option to specify the '\ 'option to specify the target %(resource)s ID.'
'target %(resource)s ID'
class RedfishUtils(object): class RedfishUtils(object):
@ -245,8 +244,7 @@ class RedfishUtils(object):
'ret': False, 'ret': False,
'msg': "System resource %s not found" % self.resource_id} 'msg': "System resource %s not found" % self.resource_id}
elif len(self.systems_uris) > 1: elif len(self.systems_uris) > 1:
self.module.deprecate(DEPRECATE_MSG % {'resource': 'System'}, self.module.fail_json(msg=FAIL_MSG % {'resource': 'System'})
version='3.0.0', collection_name='community.general') # was Ansible 2.14
return {'ret': True} return {'ret': True}
def _find_updateservice_resource(self): def _find_updateservice_resource(self):
@ -296,8 +294,7 @@ class RedfishUtils(object):
'ret': False, 'ret': False,
'msg': "Chassis resource %s not found" % self.resource_id} 'msg': "Chassis resource %s not found" % self.resource_id}
elif len(self.chassis_uris) > 1: elif len(self.chassis_uris) > 1:
self.module.deprecate(DEPRECATE_MSG % {'resource': 'Chassis'}, self.module.fail_json(msg=FAIL_MSG % {'resource': 'Chassis'})
version='3.0.0', collection_name='community.general') # was Ansible 2.14
return {'ret': True} return {'ret': True}
def _find_managers_resource(self): def _find_managers_resource(self):
@ -326,8 +323,7 @@ class RedfishUtils(object):
'ret': False, 'ret': False,
'msg': "Manager resource %s not found" % self.resource_id} 'msg': "Manager resource %s not found" % self.resource_id}
elif len(self.manager_uris) > 1: elif len(self.manager_uris) > 1:
self.module.deprecate(DEPRECATE_MSG % {'resource': 'Manager'}, self.module.fail_json(msg=FAIL_MSG % {'resource': 'Manager'})
version='3.0.0', collection_name='community.general') # was Ansible 2.14
return {'ret': True} return {'ret': True}
def _get_all_action_info_values(self, action): def _get_all_action_info_values(self, action):

View File

@ -30,10 +30,6 @@ options:
required: False required: False
default: present default: present
choices: ['present','absent'] choices: ['present','absent']
wait:
description:
- This option does nothing and will be removed in community.general 3.0.0.
type: bool
requirements: requirements:
- python = 2.7 - python = 2.7
- requests >= 2.5.0 - requests >= 2.5.0
@ -185,7 +181,6 @@ class ClcAntiAffinityPolicy:
argument_spec = dict( argument_spec = dict(
name=dict(required=True), name=dict(required=True),
location=dict(required=True), location=dict(required=True),
wait=dict(type='bool', removed_in_version='3.0.0', removed_from_collection='community.general'), # was Ansible 2.14
state=dict(default='present', choices=['present', 'absent']), state=dict(default='present', choices=['present', 'absent']),
) )
return argument_spec return argument_spec

View File

@ -52,10 +52,8 @@ options:
description: description:
- If C(yes), which will replace the remote file when contents are different than the source. - If C(yes), which will replace the remote file when contents are different than the source.
- If C(no), the file will only be extracted and copied if the destination does not already exist. - If C(no), the file will only be extracted and copied if the destination does not already exist.
- Alias C(thirsty) has been deprecated and will be removed in community.general 3.0.0.
type: bool type: bool
default: yes default: yes
aliases: [ thirsty ]
executable: executable:
description: description:
- The path to the C(7z) executable to use for extracting files from the ISO. - The path to the C(7z) executable to use for extracting files from the ISO.
@ -101,8 +99,7 @@ def main():
image=dict(type='path', required=True, aliases=['path', 'src']), image=dict(type='path', required=True, aliases=['path', 'src']),
dest=dict(type='path', required=True), dest=dict(type='path', required=True),
files=dict(type='list', elements='str', required=True), files=dict(type='list', elements='str', required=True),
force=dict(type='bool', default=True, aliases=['thirsty'], force=dict(type='bool', default=True),
deprecated_aliases=[dict(name='thirsty', version='3.0.0', collection_name='community.general')]),
executable=dict(type='path'), # No default on purpose executable=dict(type='path'), # No default on purpose
), ),
supports_check_mode=True, supports_check_mode=True,

View File

@ -17,18 +17,17 @@ author:
short_description: Notify airbrake about app deployments short_description: Notify airbrake about app deployments
description: description:
- Notify airbrake about app deployments (see U(https://airbrake.io/docs/api/#deploys-v4)). - Notify airbrake about app deployments (see U(https://airbrake.io/docs/api/#deploys-v4)).
- Parameter I(token) has been deprecated for community.general 0.2.0. Please remove entry.
options: options:
project_id: project_id:
description: description:
- Airbrake PROJECT_ID - Airbrake PROJECT_ID
required: false required: true
type: str type: str
version_added: '0.2.0' version_added: '0.2.0'
project_key: project_key:
description: description:
- Airbrake PROJECT_KEY. - Airbrake PROJECT_KEY.
required: false required: true
type: str type: str
version_added: '0.2.0' version_added: '0.2.0'
environment: environment:
@ -70,11 +69,6 @@ options:
required: false required: false
default: 'yes' default: 'yes'
type: bool type: bool
token:
description:
- This parameter (API token) has been deprecated in community.general 0.2.0. Please remove it from your tasks.
required: false
type: str
requirements: [] requirements: []
''' '''
@ -111,9 +105,8 @@ def main():
module = AnsibleModule( module = AnsibleModule(
argument_spec=dict( argument_spec=dict(
token=dict(required=False, no_log=True, type='str'), project_id=dict(required=True, no_log=True, type='str'),
project_id=dict(required=False, no_log=True, type='str'), project_key=dict(required=True, no_log=True, type='str'),
project_key=dict(required=False, no_log=True, type='str'),
environment=dict(required=True, type='str'), environment=dict(required=True, type='str'),
user=dict(required=False, type='str'), user=dict(required=False, type='str'),
repo=dict(required=False, type='str'), repo=dict(required=False, type='str'),
@ -123,8 +116,6 @@ def main():
validate_certs=dict(default=True, type='bool'), validate_certs=dict(default=True, type='bool'),
), ),
supports_check_mode=True, supports_check_mode=True,
required_together=[('project_id', 'project_key')],
mutually_exclusive=[('project_id', 'token')],
) )
# Build list of params # Build list of params
@ -134,65 +125,32 @@ def main():
if module.check_mode: if module.check_mode:
module.exit_json(changed=True) module.exit_json(changed=True)
if module.params["token"]: # v4 API documented at https://airbrake.io/docs/api/#create-deploy-v4
# v2 API documented at https://airbrake.io/docs/legacy-xml-api/#tracking-deploys if module.params["environment"]:
if module.params["environment"]: params["environment"] = module.params["environment"]
params["deploy[rails_env]"] = module.params["environment"]
if module.params["user"]: if module.params["user"]:
params["deploy[local_username]"] = module.params["user"] params["username"] = module.params["user"]
if module.params["repo"]: if module.params["repo"]:
params["deploy[scm_repository]"] = module.params["repo"] params["repository"] = module.params["repo"]
if module.params["revision"]: if module.params["revision"]:
params["deploy[scm_revision]"] = module.params["revision"] params["revision"] = module.params["revision"]
# version not supported in v2 API; omit if module.params["version"]:
params["version"] = module.params["version"]
module.deprecate("Parameter 'token' is deprecated since community.general 0.2.0. Please remove " # Build deploy url
"it and use 'project_id' and 'project_key' instead", url = module.params.get('url') + module.params["project_id"] + '/deploys?key=' + module.params["project_key"]
version='3.0.0', collection_name='community.general') # was Ansible 2.14 json_body = module.jsonify(params)
params["api_key"] = module.params["token"] # Build header
headers = {'Content-Type': 'application/json'}
# Allow sending to Airbrake compliant v2 APIs # Notify Airbrake of deploy
if module.params["url"] == 'https://api.airbrake.io/api/v4/projects/': response, info = fetch_url(module, url, data=json_body,
url = 'https://api.airbrake.io/deploys.txt' headers=headers, method='POST')
else:
url = module.params["url"]
# Send the data to airbrake
data = urlencode(params)
response, info = fetch_url(module, url, data=data)
if module.params["project_id"] and module.params["project_key"]:
# v4 API documented at https://airbrake.io/docs/api/#create-deploy-v4
if module.params["environment"]:
params["environment"] = module.params["environment"]
if module.params["user"]:
params["username"] = module.params["user"]
if module.params["repo"]:
params["repository"] = module.params["repo"]
if module.params["revision"]:
params["revision"] = module.params["revision"]
if module.params["version"]:
params["version"] = module.params["version"]
# Build deploy url
url = module.params.get('url') + module.params["project_id"] + '/deploys?key=' + module.params["project_key"]
json_body = module.jsonify(params)
# Build header
headers = {'Content-Type': 'application/json'}
# Notify Airbrake of deploy
response, info = fetch_url(module, url, data=json_body,
headers=headers, method='POST')
if info['status'] == 200 or info['status'] == 201: if info['status'] == 200 or info['status'] == 201:
module.exit_json(changed=True) module.exit_json(changed=True)

View File

@ -76,8 +76,6 @@ options:
type: str type: str
description: description:
- Message about the deployment. - Message about the deployment.
- C(message) alias is deprecated in community.general 0.2.0, since it is used internally by Ansible Core Engine.
aliases: ['message']
version_added: '0.2.0' version_added: '0.2.0'
source_system: source_system:
type: str type: str
@ -148,9 +146,7 @@ def main():
env=dict(required=False), env=dict(required=False),
owner=dict(required=False), owner=dict(required=False),
description=dict(required=False), description=dict(required=False),
deployment_message=dict(required=False, aliases=['message'], deployment_message=dict(required=False),
deprecated_aliases=[dict(name='message', version='3.0.0',
collection_name='community.general')]), # was Ansible 2.14
source_system=dict(required=False, default='ansible'), source_system=dict(required=False, default='ansible'),
validate_certs=dict(default=True, type='bool'), validate_certs=dict(default=True, type='bool'),
url=dict(required=False, default='https://api.bigpanda.io'), url=dict(required=False, default='https://api.bigpanda.io'),

View File

@ -68,9 +68,7 @@ options:
- A message to include with notifications for this monitor. - A message to include with notifications for this monitor.
- Email notifications can be sent to specific users by using the same '@username' notation as events. - Email notifications can be sent to specific users by using the same '@username' notation as events.
- Monitor message template variables can be accessed by using double square brackets, i.e '[[' and ']]'. - Monitor message template variables can be accessed by using double square brackets, i.e '[[' and ']]'.
- C(message) alias is deprecated in community.general 0.2.0, since it is used internally by Ansible Core Engine.
type: str type: str
aliases: [ 'message' ]
silenced: silenced:
type: dict type: dict
description: description:
@ -214,9 +212,7 @@ def main():
'log alert', 'query alert', 'trace-analytics alert', 'rum alert']), 'log alert', 'query alert', 'trace-analytics alert', 'rum alert']),
name=dict(required=True), name=dict(required=True),
query=dict(), query=dict(),
notification_message=dict(no_log=True, aliases=['message'], notification_message=dict(no_log=True),
deprecated_aliases=[dict(name='message', version='3.0.0',
collection_name='community.general')]), # was Ansible 2.14
silenced=dict(type='dict'), silenced=dict(type='dict'),
notify_no_data=dict(default=False, type='bool'), notify_no_data=dict(default=False, type='bool'),
no_data_timeframe=dict(), no_data_timeframe=dict(),
@ -239,9 +235,6 @@ def main():
if not HAS_DATADOG: if not HAS_DATADOG:
module.fail_json(msg=missing_required_lib('datadogpy'), exception=DATADOG_IMP_ERR) module.fail_json(msg=missing_required_lib('datadogpy'), exception=DATADOG_IMP_ERR)
if 'message' in module.params:
module.fail_json(msg="'message' is reserved keyword, please change this parameter to 'notification_message'")
options = { options = {
'api_key': module.params['api_key'], 'api_key': module.params['api_key'],
'api_host': module.params['api_host'], 'api_host': module.params['api_host'],

View File

@ -55,7 +55,6 @@ options:
- The message you would like to send. - The message you would like to send.
required: yes required: yes
type: str type: str
aliases: ['message']
''' '''
EXAMPLES = """ EXAMPLES = """
@ -174,9 +173,7 @@ def main():
recipient_id=dict(required=True, no_log=True), recipient_id=dict(required=True, no_log=True),
msg_type=dict(required=False, default='text', aliases=['message_type'], choices=['text', 'markdown']), msg_type=dict(required=False, default='text', aliases=['message_type'], choices=['text', 'markdown']),
personal_token=dict(required=True, no_log=True, aliases=['token']), personal_token=dict(required=True, no_log=True, aliases=['token']),
msg=dict(required=True, aliases=['message'], msg=dict(required=True),
deprecated_aliases=[dict(name='message', version='3.0.0',
collection_name='community.general')]), # was Ansible 2.14
), ),
supports_check_mode=True supports_check_mode=True

View File

@ -46,9 +46,8 @@ options:
description: description:
- CA certificate string used to validate the feed source SSL certificate. - CA certificate string used to validate the feed source SSL certificate.
This can be the file content or the path to the file. This can be the file content or the path to the file.
The ca_cert alias will be removed in community.general 3.0.0.
type: str type: str
aliases: [ importer_ssl_ca_cert, ca_cert ] aliases: [ importer_ssl_ca_cert ]
feed_client_cert: feed_client_cert:
description: description:
- Certificate used as the client certificate when synchronizing the - Certificate used as the client certificate when synchronizing the
@ -57,8 +56,6 @@ options:
certificate. The specified file may be the certificate itself or a certificate. The specified file may be the certificate itself or a
single file containing both the certificate and private key. This can be single file containing both the certificate and private key. This can be
the file content or the path to the file. the file content or the path to the file.
- If not specified the default value will come from client_cert. Which will
change in community.general 3.0.0.
type: str type: str
aliases: [ importer_ssl_client_cert ] aliases: [ importer_ssl_client_cert ]
feed_client_key: feed_client_key:
@ -66,8 +63,6 @@ options:
- Private key to the certificate specified in I(importer_ssl_client_cert), - Private key to the certificate specified in I(importer_ssl_client_cert),
assuming it is not included in the certificate file itself. This can be assuming it is not included in the certificate file itself. This can be
the file content or the path to the file. the file content or the path to the file.
- If not specified the default value will come from client_key. Which will
change in community.general 3.0.0.
type: str type: str
aliases: [ importer_ssl_client_key ] aliases: [ importer_ssl_client_key ]
name: name:
@ -541,9 +536,7 @@ def main():
add_export_distributor=dict(default=False, type='bool'), add_export_distributor=dict(default=False, type='bool'),
feed=dict(), feed=dict(),
generate_sqlite=dict(default=False, type='bool'), generate_sqlite=dict(default=False, type='bool'),
feed_ca_cert=dict(aliases=['importer_ssl_ca_cert', 'ca_cert'], feed_ca_cert=dict(aliases=['importer_ssl_ca_cert']),
deprecated_aliases=[dict(name='ca_cert', version='3.0.0',
collection_name='community.general')]), # was Ansible 2.14
feed_client_cert=dict(aliases=['importer_ssl_client_cert']), feed_client_cert=dict(aliases=['importer_ssl_client_cert']),
feed_client_key=dict(aliases=['importer_ssl_client_key'], no_log=True), feed_client_key=dict(aliases=['importer_ssl_client_key'], no_log=True),
name=dict(required=True, aliases=['repo']), name=dict(required=True, aliases=['repo']),
@ -571,19 +564,7 @@ def main():
generate_sqlite = module.params['generate_sqlite'] generate_sqlite = module.params['generate_sqlite']
importer_ssl_ca_cert = module.params['feed_ca_cert'] importer_ssl_ca_cert = module.params['feed_ca_cert']
importer_ssl_client_cert = module.params['feed_client_cert'] importer_ssl_client_cert = module.params['feed_client_cert']
if importer_ssl_client_cert is None and module.params['client_cert'] is not None:
importer_ssl_client_cert = module.params['client_cert']
module.deprecate("To specify client certificates to be used with the repo to sync, and not for communication with the "
"Pulp instance, use the new options `feed_client_cert` and `feed_client_key` (available since "
"Ansible 2.9.2). Until community.general 3.0.0, the default value for `feed_client_cert` will be "
"taken from `client_cert` if only the latter is specified",
version="3.0.0", collection_name='community.general') # was Ansible 2.14
importer_ssl_client_key = module.params['feed_client_key'] importer_ssl_client_key = module.params['feed_client_key']
if importer_ssl_client_key is None and module.params['client_key'] is not None:
importer_ssl_client_key = module.params['client_key']
module.deprecate("In Ansible 2.9.2 `feed_client_key` option was added. Until community.general 3.0.0 the default "
"value will come from client_key option",
version="3.0.0", collection_name='community.general') # was Ansible 2.14
proxy_host = module.params['proxy_host'] proxy_host = module.params['proxy_host']
proxy_port = module.params['proxy_port'] proxy_port = module.params['proxy_port']
proxy_username = module.params['proxy_username'] proxy_username = module.params['proxy_username']

View File

@ -61,12 +61,6 @@ options:
type: bool type: bool
default: yes default: yes
version_added: '0.2.0' version_added: '0.2.0'
force:
description:
- This option doesn't have any effect and is deprecated, it will be
removed in 3.0.0.
type: bool
default: no
''' '''
EXAMPLES = ''' EXAMPLES = '''
@ -289,7 +283,6 @@ def main():
'latest', 'absent', 'latest', 'absent',
'removed']), 'removed']),
recurse=dict(default=False, type='bool'), recurse=dict(default=False, type='bool'),
force=dict(default=False, type='bool', removed_in_version='3.0.0', removed_from_collection='community.general'),
upgrade=dict(default=False, type='bool'), upgrade=dict(default=False, type='bool'),
update_cache=dict( update_cache=dict(
default=True, aliases=['update-cache'], type='bool', default=True, aliases=['update-cache'], type='bool',

View File

@ -45,16 +45,6 @@ options:
description: description:
- Password for authentication with iDRAC - Password for authentication with iDRAC
type: str type: str
manager_attribute_name:
required: false
description:
- (deprecated) name of iDRAC attribute to update
type: str
manager_attribute_value:
required: false
description:
- (deprecated) value of iDRAC attribute to update
type: str
manager_attributes: manager_attributes:
required: false required: false
description: description:
@ -183,12 +173,6 @@ class IdracRedfishUtils(RedfishUtils):
manager_uri = command_manager_attributes_uri_map.get(command, self.manager_uri) manager_uri = command_manager_attributes_uri_map.get(command, self.manager_uri)
attributes = self.module.params['manager_attributes'] attributes = self.module.params['manager_attributes']
manager_attr_name = self.module.params.get('manager_attribute_name')
manager_attr_value = self.module.params.get('manager_attribute_value')
# manager attributes to update
if manager_attr_name:
attributes.update({manager_attr_name: manager_attr_value})
attrs_to_patch = {} attrs_to_patch = {}
attrs_skipped = {} attrs_skipped = {}
@ -250,8 +234,6 @@ def main():
baseuri=dict(required=True), baseuri=dict(required=True),
username=dict(required=True), username=dict(required=True),
password=dict(required=True, no_log=True), password=dict(required=True, no_log=True),
manager_attribute_name=dict(default=None),
manager_attribute_value=dict(default=None),
manager_attributes=dict(type='dict', default={}), manager_attributes=dict(type='dict', default={}),
timeout=dict(type='int', default=10), timeout=dict(type='int', default=10),
resource_id=dict() resource_id=dict()
@ -310,13 +292,6 @@ def main():
if command in ["SetManagerAttributes", "SetLifecycleControllerAttributes", "SetSystemAttributes"]: if command in ["SetManagerAttributes", "SetLifecycleControllerAttributes", "SetSystemAttributes"]:
result = rf_utils.set_manager_attributes(command) result = rf_utils.set_manager_attributes(command)
if any((module.params['manager_attribute_name'], module.params['manager_attribute_value'])):
module.deprecate(msg='Arguments `manager_attribute_name` and '
'`manager_attribute_value` are deprecated. '
'Use `manager_attributes` instead for passing in '
'the manager attribute name and value pairs',
version='3.0.0', collection_name='community.general') # was Ansible 2.13
# Return data back or fail with proper message # Return data back or fail with proper message
if result['ret'] is True: if result['ret'] is True:
module.exit_json(changed=result['changed'], msg=to_native(result['msg'])) module.exit_json(changed=result['changed'], msg=to_native(result['msg']))

View File

@ -43,18 +43,6 @@ options:
description: description:
- Password for authentication with OOB controller - Password for authentication with OOB controller
type: str type: str
bios_attribute_name:
required: false
description:
- name of BIOS attr to update (deprecated - use bios_attributes instead)
default: 'null'
type: str
bios_attribute_value:
required: false
description:
- value of BIOS attr to update (deprecated - use bios_attributes instead)
default: 'null'
type: raw
bios_attributes: bios_attributes:
required: false required: false
description: description:
@ -129,13 +117,13 @@ EXAMPLES = '''
username: "{{ username }}" username: "{{ username }}"
password: "{{ password }}" password: "{{ password }}"
- name: Enable PXE Boot for NIC1 using deprecated options - name: Enable PXE Boot for NIC1
community.general.redfish_config: community.general.redfish_config:
category: Systems category: Systems
command: SetBiosAttributes command: SetBiosAttributes
resource_id: 437XR1138R2 resource_id: 437XR1138R2
bios_attribute_name: PxeDev1EnDis bios_attributes:
bios_attribute_value: Enabled PxeDev1EnDis: Enabled
baseuri: "{{ baseuri }}" baseuri: "{{ baseuri }}"
username: "{{ username }}" username: "{{ username }}"
password: "{{ password }}" password: "{{ password }}"
@ -233,8 +221,6 @@ def main():
baseuri=dict(required=True), baseuri=dict(required=True),
username=dict(required=True), username=dict(required=True),
password=dict(required=True, no_log=True), password=dict(required=True, no_log=True),
bios_attribute_name=dict(default='null'),
bios_attribute_value=dict(default='null', type='raw'),
bios_attributes=dict(type='dict', default={}), bios_attributes=dict(type='dict', default={}),
timeout=dict(type='int', default=10), timeout=dict(type='int', default=10),
boot_order=dict(type='list', elements='str', default=[]), boot_order=dict(type='list', elements='str', default=[]),
@ -264,12 +250,6 @@ def main():
# BIOS attributes to update # BIOS attributes to update
bios_attributes = module.params['bios_attributes'] bios_attributes = module.params['bios_attributes']
if module.params['bios_attribute_name'] != 'null':
bios_attributes[module.params['bios_attribute_name']] = module.params[
'bios_attribute_value']
module.deprecate(msg='The bios_attribute_name/bios_attribute_value '
'options are deprecated. Use bios_attributes instead',
version='3.0.0', collection_name='community.general') # was Ansible 2.14
# boot order # boot order
boot_order = module.params['boot_order'] boot_order = module.params['boot_order']

View File

@ -17,13 +17,6 @@ description:
- "Manage OpenBSD system patches using syspatch." - "Manage OpenBSD system patches using syspatch."
options: options:
apply:
type: bool
description:
- Apply all available system patches.
- By default, apply all patches.
- Deprecated. Will be removed in community.general 3.0.0.
default: yes
revert: revert:
description: description:
- Revert system patches. - Revert system patches.
@ -37,7 +30,6 @@ author:
EXAMPLES = ''' EXAMPLES = '''
- name: Apply all available system patches - name: Apply all available system patches
community.general.syspatch: community.general.syspatch:
apply: true
- name: Revert last patch - name: Revert last patch
community.general.syspatch: community.general.syspatch:
@ -50,7 +42,6 @@ EXAMPLES = '''
# NOTE: You can reboot automatically if a patch requires it: # NOTE: You can reboot automatically if a patch requires it:
- name: Apply all patches and store result - name: Apply all patches and store result
community.general.syspatch: community.general.syspatch:
apply: true
register: syspatch register: syspatch
- name: Reboot if patch requires it - name: Reboot if patch requires it
@ -86,14 +77,12 @@ from ansible.module_utils.basic import AnsibleModule
def run_module(): def run_module():
# define available arguments/parameters a user can pass to the module # define available arguments/parameters a user can pass to the module
module_args = dict( module_args = dict(
apply=dict(type='bool', default=True, removed_in_version='3.0.0', removed_from_collection='community.general'),
revert=dict(type='str', choices=['all', 'one']) revert=dict(type='str', choices=['all', 'one'])
) )
module = AnsibleModule( module = AnsibleModule(
argument_spec=module_args, argument_spec=module_args,
supports_check_mode=True, supports_check_mode=True,
required_one_of=[['apply', 'revert']]
) )
result = syspatch_run(module) result = syspatch_run(module)
@ -117,7 +106,7 @@ def syspatch_run(module):
run_flag = ['-R'] run_flag = ['-R']
else: else:
run_flag = ['-r'] run_flag = ['-r']
elif module.params['apply']: else:
check_flag = ['-c'] check_flag = ['-c']
run_flag = [] run_flag = []

View File

@ -101,14 +101,6 @@ options:
C(collectstatic) command. C(collectstatic) command.
required: false required: false
type: bool type: bool
liveserver:
description:
- This parameter was implemented a long time ago in a galaxy far way. It probably relates to the
django-liveserver package, which is no longer updated.
- Hence, it will be considered DEPRECATED and should be removed in a future release.
type: str
required: false
aliases: [live_server]
testrunner: testrunner:
description: description:
- "From the Django docs: Controls the test runner class that is used to execute tests." - "From the Django docs: Controls the test runner class that is used to execute tests."
@ -233,7 +225,7 @@ def main():
flush=('database', ), flush=('database', ),
loaddata=('database', 'fixtures', ), loaddata=('database', 'fixtures', ),
syncdb=('database', ), syncdb=('database', ),
test=('failfast', 'testrunner', 'liveserver', 'apps', ), test=('failfast', 'testrunner', 'apps', ),
validate=(), validate=(),
migrate=('apps', 'skip', 'merge', 'database',), migrate=('apps', 'skip', 'merge', 'database',),
collectstatic=('clear', 'link', ), collectstatic=('clear', 'link', ),
@ -253,7 +245,7 @@ def main():
) )
# These params are allowed for certain commands only # These params are allowed for certain commands only
specific_params = ('apps', 'clear', 'database', 'failfast', 'fixtures', 'liveserver', 'testrunner') specific_params = ('apps', 'clear', 'database', 'failfast', 'fixtures', 'testrunner')
# These params are automatically added to the command if present # These params are automatically added to the command if present
general_params = ('settings', 'pythonpath', 'database',) general_params = ('settings', 'pythonpath', 'database',)
@ -274,8 +266,6 @@ def main():
database=dict(default=None, required=False, type='str'), database=dict(default=None, required=False, type='str'),
failfast=dict(default=False, required=False, type='bool', aliases=['fail_fast']), failfast=dict(default=False, required=False, type='bool', aliases=['fail_fast']),
fixtures=dict(default=None, required=False, type='str'), fixtures=dict(default=None, required=False, type='str'),
liveserver=dict(default=None, required=False, type='str', aliases=['live_server'],
removed_in_version='3.0.0', removed_from_collection='community.general'),
testrunner=dict(default=None, required=False, type='str', aliases=['test_runner']), testrunner=dict(default=None, required=False, type='str', aliases=['test_runner']),
skip=dict(default=None, required=False, type='bool'), skip=dict(default=None, required=False, type='bool'),
merge=dict(default=None, required=False, type='bool'), merge=dict(default=None, required=False, type='bool'),

View File

@ -107,14 +107,11 @@ plugins/modules/cloud/xenserver/xenserver_guest.py validate-modules:undocumented
plugins/modules/clustering/consul/consul.py validate-modules:doc-missing-type plugins/modules/clustering/consul/consul.py validate-modules:doc-missing-type
plugins/modules/clustering/consul/consul.py validate-modules:undocumented-parameter plugins/modules/clustering/consul/consul.py validate-modules:undocumented-parameter
plugins/modules/clustering/consul/consul_session.py validate-modules:parameter-state-invalid-choice plugins/modules/clustering/consul/consul_session.py validate-modules:parameter-state-invalid-choice
plugins/modules/monitoring/bigpanda.py validate-modules:invalid-argument-name
plugins/modules/monitoring/datadog/datadog_monitor.py validate-modules:invalid-argument-name
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:parameter-type-not-in-doc # This triggers when a parameter is undocumented plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:parameter-type-not-in-doc # This triggers when a parameter is undocumented
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:undocumented-parameter # Parameter removed but reason for removal is shown by custom code plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:undocumented-parameter # Parameter removed but reason for removal is shown by custom code
plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:doc-missing-type plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:doc-missing-type
plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:parameter-type-not-in-doc plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:parameter-type-not-in-doc
plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:undocumented-parameter # Parameter removed but reason for removal is shown by custom code plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:undocumented-parameter # Parameter removed but reason for removal is shown by custom code
plugins/modules/notification/cisco_webex.py validate-modules:invalid-argument-name
plugins/modules/notification/grove.py validate-modules:invalid-argument-name plugins/modules/notification/grove.py validate-modules:invalid-argument-name
plugins/modules/packaging/language/composer.py validate-modules:parameter-invalid plugins/modules/packaging/language/composer.py validate-modules:parameter-invalid
plugins/modules/packaging/os/apt_rpm.py validate-modules:parameter-invalid plugins/modules/packaging/os/apt_rpm.py validate-modules:parameter-invalid

View File

@ -106,14 +106,11 @@ plugins/modules/cloud/xenserver/xenserver_guest.py validate-modules:undocumented
plugins/modules/clustering/consul/consul.py validate-modules:doc-missing-type plugins/modules/clustering/consul/consul.py validate-modules:doc-missing-type
plugins/modules/clustering/consul/consul.py validate-modules:undocumented-parameter plugins/modules/clustering/consul/consul.py validate-modules:undocumented-parameter
plugins/modules/clustering/consul/consul_session.py validate-modules:parameter-state-invalid-choice plugins/modules/clustering/consul/consul_session.py validate-modules:parameter-state-invalid-choice
plugins/modules/monitoring/bigpanda.py validate-modules:invalid-argument-name
plugins/modules/monitoring/datadog/datadog_monitor.py validate-modules:invalid-argument-name
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:parameter-type-not-in-doc # This triggers when a parameter is undocumented plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:parameter-type-not-in-doc # This triggers when a parameter is undocumented
plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:undocumented-parameter # Parameter removed but reason for removal is shown by custom code plugins/modules/net_tools/ldap/ldap_attr.py validate-modules:undocumented-parameter # Parameter removed but reason for removal is shown by custom code
plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:doc-missing-type plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:doc-missing-type
plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:parameter-type-not-in-doc plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:parameter-type-not-in-doc
plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:undocumented-parameter # Parameter removed but reason for removal is shown by custom code plugins/modules/net_tools/ldap/ldap_entry.py validate-modules:undocumented-parameter # Parameter removed but reason for removal is shown by custom code
plugins/modules/notification/cisco_webex.py validate-modules:invalid-argument-name
plugins/modules/notification/grove.py validate-modules:invalid-argument-name plugins/modules/notification/grove.py validate-modules:invalid-argument-name
plugins/modules/packaging/language/composer.py validate-modules:parameter-invalid plugins/modules/packaging/language/composer.py validate-modules:parameter-invalid
plugins/modules/packaging/os/apt_rpm.py validate-modules:parameter-invalid plugins/modules/packaging/os/apt_rpm.py validate-modules:parameter-invalid