a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove elements= from arg_spec when type is not 'list'. (#50484)

pull/4420/head
Felix Fontein 2019-01-09 15:10:17 +01:00 committed by Ganesh Nalawade
parent 4902306dd8
commit 41de2855ae
4 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ansible/modules/crypto/openssl_csr.py
View File

@ -544,8 +544,8 @@ def main():
subjectAltName_critical=dict(aliases=['subject_alt_name_critical'], default=False, type='bool'), subjectAltName_critical=dict(aliases=['subject_alt_name_critical'], default=False, type='bool'),
keyUsage=dict(aliases=['key_usage'], type='list', elements='str'), keyUsage=dict(aliases=['key_usage'], type='list', elements='str'),
keyUsage_critical=dict(aliases=['key_usage_critical'], default=False, type='bool'), keyUsage_critical=dict(aliases=['key_usage_critical'], default=False, type='bool'),
extendedKeyUsage=dict(aliases=['extKeyUsage', 'extended_key_usage'], type='list'), extendedKeyUsage=dict(aliases=['extKeyUsage', 'extended_key_usage'], type='list', elements='str'),
extendedKeyUsage_critical=dict(aliases=['extKeyUsage_critical', 'extended_key_usage_critical'], default=False, type='bool', elements='str'), extendedKeyUsage_critical=dict(aliases=['extKeyUsage_critical', 'extended_key_usage_critical'], default=False, type='bool'),
basicConstraints=dict(aliases=['basic_constraints'], type='list', elements='str'), basicConstraints=dict(aliases=['basic_constraints'], type='list', elements='str'),
basicConstraints_critical=dict(aliases=['basic_constraints_critical'], default=False, type='bool'), basicConstraints_critical=dict(aliases=['basic_constraints_critical'], default=False, type='bool'),
ocspMustStaple=dict(aliases=['ocsp_must_staple'], default=False, type='bool'), ocspMustStaple=dict(aliases=['ocsp_must_staple'], default=False, type='bool'),

2
lib/ansible/modules/network/ios/ios_user.py
View File

@ -456,7 +456,7 @@ def main():
name=dict(), name=dict(),
configured_password=dict(no_log=True), configured_password=dict(no_log=True),
hashed_password=dict(no_log=True, elements='dict', options=hashed_password_spec), hashed_password=dict(no_log=True, type='dict', options=hashed_password_spec),
nopassword=dict(type='bool'), nopassword=dict(type='bool'),
update_password=dict(default='always', choices=['on_create', 'always']), update_password=dict(default='always', choices=['on_create', 'always']),
password_type=dict(default='secret', choices=['secret', 'password']), password_type=dict(default='secret', choices=['secret', 'password']),

8
lib/ansible/modules/remote_management/manageiq/manageiq_group.py
View File

@ -507,13 +507,15 @@ class ManageIQgroup(object):
return res return res
@staticmethod @staticmethod
def normalize_user_managed_filters_to_sorted_dict(managed_filters): def normalize_user_managed_filters_to_sorted_dict(managed_filters, module):
if not managed_filters: if not managed_filters:
return None return None
res = {} res = {}
for cat_key in managed_filters: for cat_key in managed_filters:
cat_array = [] cat_array = []
if not isinstance(managed_filters[cat_key], list):
module.fail_json(msg='Entry "{0}" of managed_filters must be a list!'.format(cat_key))
for tags in managed_filters[cat_key]: for tags in managed_filters[cat_key]:
miq_managed_tag = "/managed/" + cat_key + "/" + tags miq_managed_tag = "/managed/" + cat_key + "/" + tags
cat_array.append(miq_managed_tag) cat_array.append(miq_managed_tag)
@ -571,7 +573,7 @@ def main():
role=dict(required=False, type='str'), role=dict(required=False, type='str'),
tenant_id=dict(required=False, type='int'), tenant_id=dict(required=False, type='int'),
tenant=dict(required=False, type='str'), tenant=dict(required=False, type='str'),
managed_filters=dict(required=False, type='dict', elements='list'), managed_filters=dict(required=False, type='dict'),
managed_filters_merge_mode=dict(required=False, choices=['merge', 'replace'], default='replace'), managed_filters_merge_mode=dict(required=False, choices=['merge', 'replace'], default='replace'),
belongsto_filters=dict(required=False, type='list', elements='str'), belongsto_filters=dict(required=False, type='list', elements='str'),
belongsto_filters_merge_mode=dict(required=False, choices=['merge', 'replace'], default='replace'), belongsto_filters_merge_mode=dict(required=False, choices=['merge', 'replace'], default='replace'),
@ -615,7 +617,7 @@ def main():
tenant = manageiq_group.tenant(tenant_id, tenant_name) tenant = manageiq_group.tenant(tenant_id, tenant_name)
role = manageiq_group.role(role_id, role_name) role = manageiq_group.role(role_id, role_name)
norm_managed_filters = manageiq_group.normalize_user_managed_filters_to_sorted_dict(managed_filters) norm_managed_filters = manageiq_group.normalize_user_managed_filters_to_sorted_dict(managed_filters, module)
# if we have a group, edit it # if we have a group, edit it
if group: if group:
res_args = manageiq_group.edit_group(group, description, role, tenant, res_args = manageiq_group.edit_group(group, description, role, tenant,

2
lib/ansible/modules/remote_management/ucs/ucs_disk_group_policy.py
View File

@ -387,7 +387,7 @@ def main():
min_drive_size=dict(type='str', default='unspecified'), min_drive_size=dict(type='str', default='unspecified'),
manual_disks=dict(type='list', elements='dict', options=manual_disk), manual_disks=dict(type='list', elements='dict', options=manual_disk),
state=dict(type='str', default='present', choices=['present', 'absent']), state=dict(type='str', default='present', choices=['present', 'absent']),
virtual_drive=dict(type='dict', elements='dict', options=_virtual_drive_argument_spec()), virtual_drive=dict(type='dict', options=_virtual_drive_argument_spec()),
) )
module = AnsibleModule( module = AnsibleModule(
argument_spec, argument_spec,