removes advertise_addr from required parameters when state is "join" (#646)

* removes advertise_addr from required parameters when state is "join"

addressing this issue: https://github.com/ansible-collections/community.general/issues/439

* adjusts test

* adds changelog

changelogs/fragments/646-docker_swarm-remove-advertise_addr-from-join-requirement.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - docker_swarm - removes ``advertise_addr`` from list of required arguments when ``state`` is ``"join"`` (https://github.com/ansible-collections/community.general/issues/439).

plugins/modules/cloud/docker/docker_swarm.py

@@ -627,7 +627,7 @@ def main():
     )
 
     required_if = [
-        ('state', 'join', ['advertise_addr', 'remote_addrs', 'join_token']),
+        ('state', 'join', ['remote_addrs', 'join_token']),
         ('state', 'remove', ['node_id'])
     ]
 

tests/integration/targets/docker_swarm/tasks/tests/basic.yml

@@ -10,11 +10,11 @@
   ignore_errors: yes
   register: output
 
-- name: assert failure when called with state=join and no advertise_addr,remote_addrs,join_token
+- name: assert failure when called with state=join and no remote_addrs,join_token
   assert:
     that:
        - 'output.failed'
-       - 'output.msg == "state is join but all of the following are missing: advertise_addr, remote_addrs, join_token"'
+       - 'output.msg == "state is join but all of the following are missing: remote_addrs, join_token"'
 
 - name: Test parameters with state=remove
   docker_swarm: