a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Proxmox inventory: Add some sanitization to url parameter (#1914) (#1930) 

* Added rstrip to the URL field to prevent issues when users add a trailing / in the config of this module

* Added changelog fragment

* Sorry Mr. Linter, I have removed the empty line :-)

* Fixed punctuation

* Fixed punctuation

(cherry picked from commit 20bd065e77)

Co-authored-by: Jeffrey van Pelt <jeff@vanpelt.one>
pull/1935/head
patchback[bot] 2021-02-27 17:27:11 +01:00 committed by GitHub
parent e68c68d417
commit 5ffef67f11
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changelogs/fragments/1914-add-sanitization-to-url.yml Normal file
View File

@ -0,0 +1,3 @@
---
bugfixes:
- proxmox inventory - added handling of extra trailing slashes in the URL (https://github.com/ansible-collections/community.general/pull/1914).

2
plugins/inventory/proxmox.py
View File

@ -338,7 +338,7 @@ class InventoryModule(BaseInventoryPlugin, Cacheable):
self._read_config_data(path) self._read_config_data(path)
# get connection host # get connection host
self.proxmox_url = self.get_option('url') self.proxmox_url = self.get_option('url').rstrip('/')
self.proxmox_user = self.get_option('user') self.proxmox_user = self.get_option('user')
self.proxmox_password = self.get_option('password') self.proxmox_password = self.get_option('password')
self.cache_key = self.get_cache_key(path) self.cache_key = self.get_cache_key(path)