collection: Change default='no's and 'yes's to default=False and default=True (#556)

* Change default={'no','yes'} to default={False,True}

* Add changelog

* Remove changelog

plugins/modules/cloud/digital_ocean/digital_ocean.py

@@ -434,13 +434,13 @@ def main():
             image_id=dict(),
             region_id=dict(),
             ssh_key_ids=dict(type='list'),
-            virtio=dict(type='bool', default='yes'),
+            virtio=dict(type='bool', default=True),
-            private_networking=dict(type='bool', default='no'),
+            private_networking=dict(type='bool', default=False),
-            backups_enabled=dict(type='bool', default='no'),
+            backups_enabled=dict(type='bool', default=False),
             id=dict(aliases=['droplet_id'], type='int'),
-            unique_name=dict(type='bool', default='no'),
+            unique_name=dict(type='bool', default=False),
             user_data=dict(default=None),
-            ipv6=dict(type='bool', default='no'),
+            ipv6=dict(type='bool', default=False),
             wait=dict(type='bool', default=True),
             wait_timeout=dict(default=300, type='int'),
             ssh_pub_key=dict(type='str'),

plugins/modules/cloud/google/gc_storage.py

@@ -409,7 +409,7 @@ def main():
             gs_access_key=dict(required=True),
             overwrite=dict(default=True, type='bool', aliases=['force']),
             region=dict(default='US', type='str'),
-            versioning=dict(default='no', type='bool')
+            versioning=dict(default=False, type='bool')
         ),
     )
 

plugins/modules/cloud/misc/proxmox.py

@@ -444,7 +444,7 @@ def main():
             api_user=dict(required=True),
             api_password=dict(no_log=True),
             vmid=dict(required=False),
-            validate_certs=dict(type='bool', default='no'),
+            validate_certs=dict(type='bool', default=False),
             node=dict(),
             pool=dict(),
             password=dict(no_log=True),
@@ -458,16 +458,16 @@ def main():
             netif=dict(type='dict'),
             mounts=dict(type='dict'),
             ip_address=dict(),
-            onboot=dict(type='bool', default='no'),
+            onboot=dict(type='bool', default=False),
             storage=dict(default='local'),
             cpuunits=dict(type='int', default=1000),
             nameserver=dict(),
             searchdomain=dict(),
             timeout=dict(type='int', default=30),
-            force=dict(type='bool', default='no'),
+            force=dict(type='bool', default=False),
             state=dict(default='present', choices=['present', 'absent', 'stopped', 'started', 'restarted']),
             pubkey=dict(type='str', default=None),
-            unprivileged=dict(type='bool', default='no'),
+            unprivileged=dict(type='bool', default=False),
             description=dict(type='str'),
             hookscript=dict(type='str'),
         )

plugins/modules/cloud/misc/proxmox_kvm.py

@@ -788,13 +788,13 @@ def proxmox_version(proxmox):
 def main():
     module = AnsibleModule(
         argument_spec=dict(
-            acpi=dict(type='bool', default='yes'),
+            acpi=dict(type='bool', default=True),
             agent=dict(type='bool'),
             args=dict(type='str', default=None),
             api_host=dict(required=True),
             api_user=dict(required=True),
             api_password=dict(no_log=True),
-            autostart=dict(type='bool', default='no'),
+            autostart=dict(type='bool', default=False),
             balloon=dict(type='int', default=0),
             bios=dict(choices=['seabios', 'ovmf']),
             boot=dict(type='str', default='cnd'),
@@ -810,13 +810,13 @@ def main():
             force=dict(type='bool', default=None),
             format=dict(type='str', default='qcow2', choices=['cloop', 'cow', 'qcow', 'qcow2', 'qed', 'raw', 'vmdk']),
             freeze=dict(type='bool'),
-            full=dict(type='bool', default='yes'),
+            full=dict(type='bool', default=True),
             hostpci=dict(type='dict'),
             hotplug=dict(type='str'),
             hugepages=dict(choices=['any', '2', '1024']),
             ide=dict(type='dict', default=None),
             keyboard=dict(type='str'),
-            kvm=dict(type='bool', default='yes'),
+            kvm=dict(type='bool', default=True),
             localtime=dict(type='bool'),
             lock=dict(choices=['migrate', 'backup', 'snapshot', 'rollback']),
             machine=dict(type='str'),
@@ -829,7 +829,7 @@ def main():
             node=dict(),
             numa=dict(type='dict'),
             numa_enabled=dict(type='bool'),
-            onboot=dict(type='bool', default='yes'),
+            onboot=dict(type='bool', default=True),
             ostype=dict(default='l26', choices=['other', 'wxp', 'w2k', 'w2k3', 'w2k8', 'wvista', 'win7', 'win8', 'win10', 'l24', 'l26', 'solaris']),
             parallel=dict(type='dict'),
             pool=dict(type='str'),
@@ -849,13 +849,13 @@ def main():
             startup=dict(),
             state=dict(default='present', choices=['present', 'absent', 'stopped', 'started', 'restarted', 'current']),
             storage=dict(type='str'),
-            tablet=dict(type='bool', default='no'),
+            tablet=dict(type='bool', default=False),
             target=dict(type='str'),
             tdf=dict(type='bool'),
-            template=dict(type='bool', default='no'),
+            template=dict(type='bool', default=False),
             timeout=dict(type='int', default=30),
-            update=dict(type='bool', default='no'),
+            update=dict(type='bool', default=False),
-            validate_certs=dict(type='bool', default='no'),
+            validate_certs=dict(type='bool', default=False),
             vcpus=dict(type='int', default=None),
             vga=dict(default='std', choices=['std', 'cirrus', 'vmware', 'qxl', 'serial0', 'serial1', 'serial2', 'serial3', 'qxl2', 'qxl3', 'qxl4']),
             virtio=dict(type='dict', default=None),

plugins/modules/cloud/misc/proxmox_template.py

@@ -166,14 +166,14 @@ def main():
             api_host=dict(required=True),
             api_user=dict(required=True),
             api_password=dict(no_log=True),
-            validate_certs=dict(type='bool', default='no'),
+            validate_certs=dict(type='bool', default=False),
             node=dict(),
             src=dict(type='path'),
             template=dict(),
             content_type=dict(default='vztmpl', choices=['vztmpl', 'iso']),
             storage=dict(default='local'),
             timeout=dict(type='int', default=30),
-            force=dict(type='bool', default='no'),
+            force=dict(type='bool', default=False),
             state=dict(default='present', choices=['present', 'absent']),
         )
     )

plugins/modules/database/misc/riak.py

@@ -97,7 +97,7 @@ def main():
             wait_for_ring=dict(default=False, type='int'),
             wait_for_service=dict(
                 required=False, default=None, choices=['kv']),
-            validate_certs=dict(default='yes', type='bool'))
+            validate_certs=dict(default=True, type='bool'))
     )
 
     command = module.params.get('command')

plugins/modules/database/postgresql/postgresql_user.py

@@ -869,10 +869,10 @@ def main():
         state=dict(type='str', default='present', choices=['absent', 'present']),
         priv=dict(type='str', default=None),
         db=dict(type='str', default='', aliases=['login_db']),
-        fail_on_user=dict(type='bool', default='yes', aliases=['fail_on_role']),
+        fail_on_user=dict(type='bool', default=True, aliases=['fail_on_role']),
         role_attr_flags=dict(type='str', default=''),
-        encrypted=dict(type='bool', default='yes'),
+        encrypted=dict(type='bool', default=True),
-        no_password_changes=dict(type='bool', default='no', no_log=False),
+        no_password_changes=dict(type='bool', default=False, no_log=False),
         expires=dict(type='str', default=None),
         conn_limit=dict(type='int', default=None),
         session_role=dict(type='str'),

plugins/modules/monitoring/airbrake_deployment.py

@@ -104,7 +104,7 @@ def main():
             repo=dict(required=False),
             revision=dict(required=False),
             url=dict(required=False, default='https://api.airbrake.io/api/v4/projects/'),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
         ),
         supports_check_mode=True,
         required_together=[('project_id', 'project_key')],

plugins/modules/monitoring/bigpanda.py

@@ -137,7 +137,7 @@ def main():
                                     deprecated_aliases=[dict(name='message', version='3.0.0',
                                                              collection_name='community.general')]),  # was Ansible 2.14
             source_system=dict(required=False, default='ansible'),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
             url=dict(required=False, default='https://api.bigpanda.io'),
         ),
         supports_check_mode=True,

plugins/modules/monitoring/datadog/datadog_event.py

@@ -115,7 +115,7 @@ def main():
                 choices=['error', 'warning', 'info', 'success']
             ),
             aggregation_key=dict(required=False, default=None),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
         )
     )
 

plugins/modules/monitoring/honeybadger_deployment.py

@@ -79,7 +79,7 @@ def main():
             repo=dict(required=False),
             revision=dict(required=False),
             url=dict(required=False, default='https://api.honeybadger.io/v1/deploys'),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
         ),
         supports_check_mode=True
     )

plugins/modules/monitoring/newrelic_deployment.py

@@ -94,7 +94,7 @@ def main():
             user=dict(required=False),
             appname=dict(required=False),
             environment=dict(required=False),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
         ),
         required_one_of=[['app_name', 'application_id']],
         supports_check_mode=True

plugins/modules/monitoring/pagerduty.py

@@ -231,7 +231,7 @@ def main():
             hours=dict(default='1', required=False),
             minutes=dict(default='0', required=False),
             desc=dict(default='Created by Ansible', required=False),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
         )
     )
 

plugins/modules/monitoring/rollbar_deployment.py

@@ -95,7 +95,7 @@ def main():
                 required=False,
                 default='https://api.rollbar.com/api/1/deploy/'
             ),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
         ),
         supports_check_mode=True
     )

plugins/modules/monitoring/spectrum_device.py

@@ -306,8 +306,8 @@ def main():
             url=dict(required=True, aliases=['oneclick_url']),
             url_username=dict(required=True, aliases=['oneclick_user']),
             url_password=dict(required=True, no_log=True, aliases=['oneclick_password']),
-            use_proxy=dict(type='bool', default='yes'),
+            use_proxy=dict(type='bool', default=True),
-            validate_certs=dict(type='bool', default='yes'),
+            validate_certs=dict(type='bool', default=True),
         ),
         required_if=[('state', 'present', ['community'])],
         supports_check_mode=True

plugins/modules/net_tools/dnsmadeeasy.py

@@ -530,14 +530,14 @@ def main():
             account_key=dict(required=True),
             account_secret=dict(required=True, no_log=True),
             domain=dict(required=True),
-            sandbox=dict(default='no', type='bool'),
+            sandbox=dict(default=False, type='bool'),
             state=dict(required=True, choices=['present', 'absent']),
             record_name=dict(required=False),
             record_type=dict(required=False, choices=[
                              'A', 'AAAA', 'CNAME', 'ANAME', 'HTTPRED', 'MX', 'NS', 'PTR', 'SRV', 'TXT']),
             record_value=dict(required=False),
             record_ttl=dict(required=False, default=1800, type='int'),
-            monitor=dict(default='no', type='bool'),
+            monitor=dict(default=False, type='bool'),
             systemDescription=dict(default=''),
             maxEmails=dict(default=1, type='int'),
             protocol=dict(default='HTTP', choices=['TCP', 'UDP', 'HTTP', 'DNS', 'SMTP', 'HTTPS']),
@@ -547,14 +547,14 @@ def main():
             httpFqdn=dict(required=False),
             httpFile=dict(required=False),
             httpQueryString=dict(required=False),
-            failover=dict(default='no', type='bool'),
+            failover=dict(default=False, type='bool'),
-            autoFailover=dict(default='no', type='bool'),
+            autoFailover=dict(default=False, type='bool'),
             ip1=dict(required=False),
             ip2=dict(required=False),
             ip3=dict(required=False),
             ip4=dict(required=False),
             ip5=dict(required=False),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
         ),
         required_together=[
             ['record_value', 'record_ttl', 'record_type']

plugins/modules/notification/bearychat.py

@@ -152,7 +152,7 @@ def main():
     module = AnsibleModule(argument_spec={
         'url': dict(type='str', required=True, no_log=True),
         'text': dict(type='str'),
-        'markdown': dict(default='yes', type='bool'),
+        'markdown': dict(default=True, type='bool'),
         'channel': dict(type='str'),
         'attachments': dict(type='list'),
     })

plugins/modules/notification/flowdock.py

@@ -120,7 +120,7 @@ def main():
             project=dict(required=False),
             tags=dict(required=False),
             link=dict(required=False),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
         ),
         supports_check_mode=True
     )

plugins/modules/notification/grove.py

@@ -91,7 +91,7 @@ def main():
             service=dict(type='str', default='ansible'),
             url=dict(type='str', default=None),
             icon_url=dict(type='str', default=None),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
         )
     )
 

plugins/modules/notification/hipchat.py

@@ -173,7 +173,7 @@ def main():
                                                   "purple", "gray", "random"]),
             msg_format=dict(default="text", choices=["text", "html"]),
             notify=dict(default=True, type='bool'),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
             api=dict(default=DEFAULT_URI),
         ),
         supports_check_mode=True

plugins/modules/notification/mattermost.py

@@ -97,7 +97,7 @@ def main():
             channel=dict(type='str', default=None),
             username=dict(type='str', default='Ansible'),
             icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
         )
     )
     # init return dict

plugins/modules/notification/rocketchat.py

@@ -202,7 +202,7 @@ def main():
             icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'),
             icon_emoji=dict(type='str', default=None),
             link_names=dict(type='int', default=1, choices=[0, 1]),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
             color=dict(type='str', default='normal', choices=['normal', 'good', 'warning', 'danger']),
             attachments=dict(type='list', required=False, default=None)
         )

plugins/modules/notification/slack.py

@@ -308,7 +308,7 @@ def main():
             icon_emoji=dict(type='str', default=None),
             link_names=dict(type='int', default=1, choices=[0, 1]),
             parse=dict(type='str', default=None, choices=['none', 'full']),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
             color=dict(type='str', default='normal'),
             attachments=dict(type='list', required=False, default=None)
         )

plugins/modules/packaging/language/bower.py

@@ -175,8 +175,8 @@ class Bower(object):
 def main():
     arg_spec = dict(
         name=dict(default=None),
-        offline=dict(default='no', type='bool'),
+        offline=dict(default=False, type='bool'),
-        production=dict(default='no', type='bool'),
+        production=dict(default=False, type='bool'),
         path=dict(required=True, type='path'),
         relative_execpath=dict(default=None, required=False, type='path'),
         state=dict(default='present', choices=['present', 'absent', 'latest', ]),

plugins/modules/packaging/language/easy_install.py

@@ -128,7 +128,7 @@ def main():
                    choices=['present', 'latest'],
                    type='str'),
         virtualenv=dict(default=None, required=False),
-        virtualenv_site_packages=dict(default='no', type='bool'),
+        virtualenv_site_packages=dict(default=False, type='bool'),
         virtualenv_command=dict(default='virtualenv', required=False),
         executable=dict(default='easy_install', required=False),
     )

plugins/modules/packaging/language/npm.py

@@ -238,7 +238,7 @@ def main():
         name=dict(default=None, type='str'),
         path=dict(default=None, type='path'),
         version=dict(default=None, type='str'),
-        production=dict(default='no', type='bool'),
+        production=dict(default=False, type='bool'),
         executable=dict(default=None, type='path'),
         registry=dict(default=None, type='str'),
         state=dict(default='present', choices=['present', 'absent', 'latest']),
@@ -246,7 +246,7 @@ def main():
         unsafe_perm=dict(default=False, type='bool'),
         ci=dict(default=False, type='bool'),
     )
-    arg_spec['global'] = dict(default='no', type='bool')
+    arg_spec['global'] = dict(default=False, type='bool')
     module = AnsibleModule(
         argument_spec=arg_spec,
         supports_check_mode=True

plugins/modules/packaging/language/yarn.py

@@ -295,13 +295,13 @@ def main():
         name=dict(default=None),
         path=dict(default=None, type='path'),
         version=dict(default=None),
-        production=dict(default='no', type='bool'),
+        production=dict(default=False, type='bool'),
         executable=dict(default=None, type='path'),
         registry=dict(default=None),
         state=dict(default='present', choices=['present', 'absent', 'latest']),
         ignore_scripts=dict(default=False, type='bool'),
     )
-    arg_spec['global'] = dict(default='no', type='bool')
+    arg_spec['global'] = dict(default=False, type='bool')
     module = AnsibleModule(
         argument_spec=arg_spec,
         supports_check_mode=True

plugins/modules/source_control/bzr.py

@@ -137,7 +137,7 @@ def main():
             dest=dict(type='path', required=True),
             name=dict(type='str', required=True, aliases=['parent']),
             version=dict(type='str', default='head'),
-            force=dict(type='bool', default='no'),
+            force=dict(type='bool', default=False),
             executable=dict(type='str'),
         )
     )

plugins/modules/source_control/github/github_hooks.py

@@ -159,7 +159,7 @@ def main():
             oauthkey=dict(required=True, no_log=True),
             repo=dict(required=True),
             user=dict(required=True),
-            validate_certs=dict(default='yes', type='bool'),
+            validate_certs=dict(default=True, type='bool'),
             content_type=dict(default='json', choices=['json', 'form']),
         )
     )

plugins/modules/storage/infinidat/infini_export_client.py

@@ -175,7 +175,7 @@ def main():
         dict(
             client=dict(required=True),
             access_mode=dict(choices=['RO', 'RW'], default='RW'),
-            no_root_squash=dict(type='bool', default='no'),
+            no_root_squash=dict(type='bool', default=False),
             state=dict(default='present', choices=['present', 'absent']),
             export=dict(required=True)
         )

plugins/modules/web_infrastructure/django_manage.py

@@ -234,7 +234,7 @@ def main():
             cache_table=dict(default=None, required=False),
             clear=dict(default=None, required=False, type='bool'),
             database=dict(default=None, required=False),
-            failfast=dict(default='no', required=False, type='bool', aliases=['fail_fast']),
+            failfast=dict(default=False, required=False, type='bool', aliases=['fail_fast']),
             fixtures=dict(default=None, required=False),
             liveserver=dict(default=None, required=False, aliases=['live_server']),
             testrunner=dict(default=None, required=False, aliases=['test_runner']),

plugins/modules/web_infrastructure/htpasswd.py

@@ -200,7 +200,7 @@ def main():
         password=dict(required=False, default=None, no_log=True),
         crypt_scheme=dict(required=False, default="apr_md5_crypt"),
         state=dict(required=False, default="present"),
-        create=dict(type='bool', default='yes'),
+        create=dict(type='bool', default=True),
 
     )
     module = AnsibleModule(argument_spec=arg_spec,