From 6b852d841f3b5b5fa3279c73f8c98476b6422570 Mon Sep 17 00:00:00 2001 From: James J Porter Date: Sun, 5 Jul 2020 02:01:52 -0400 Subject: [PATCH] Fix bug in digital_ocean_tag_info module (#615) Co-authored-by: Felix Fontein --- changelogs/fragments/615-digital-ocean-tag-info-bugfix.yml | 2 ++ plugins/modules/cloud/digital_ocean/digital_ocean_tag_info.py | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/615-digital-ocean-tag-info-bugfix.yml diff --git a/changelogs/fragments/615-digital-ocean-tag-info-bugfix.yml b/changelogs/fragments/615-digital-ocean-tag-info-bugfix.yml new file mode 100644 index 0000000000..384666161b --- /dev/null +++ b/changelogs/fragments/615-digital-ocean-tag-info-bugfix.yml @@ -0,0 +1,2 @@ +bugfixes: + - digital_ocean_tag_info - fix crash when querying for an individual tag (https://github.com/ansible-collections/community.general/pull/615). diff --git a/plugins/modules/cloud/digital_ocean/digital_ocean_tag_info.py b/plugins/modules/cloud/digital_ocean/digital_ocean_tag_info.py index 80faaf708e..2c91411f40 100644 --- a/plugins/modules/cloud/digital_ocean/digital_ocean_tag_info.py +++ b/plugins/modules/cloud/digital_ocean/digital_ocean_tag_info.py @@ -79,7 +79,7 @@ def core(module): tag_name = module.params.get('tag_name', None) rest = DigitalOceanHelper(module) - base_url = 'tags?' + base_url = 'tags' if tag_name is not None: response = rest.get("%s/%s" % (base_url, tag_name)) status_code = response.status_code @@ -90,7 +90,7 @@ def core(module): resp_json = response.json tag = resp_json['tag'] else: - tag = rest.get_paginated_data(base_url=base_url, data_key_name='tags') + tag = rest.get_paginated_data(base_url=base_url + '?', data_key_name='tags') module.exit_json(changed=False, data=tag)