From 6cec2e2f584149ff66cb2a025f7c6e0f36ebf0a2 Mon Sep 17 00:00:00 2001 From: Jean-Francois Panisset <32653482+jfpanisset@users.noreply.github.com> Date: Mon, 13 Dec 2021 12:43:54 -0800 Subject: [PATCH] Pass missing vlan-related options (flags, ingress, egress) to nmcli (#3896) * Pass missing vlan-related options (flags, ingress, egress) to nmcli Signed-off-by: Jean-Francois Panisset * Follow style: comma on last parameter Signed-off-by: Jean-Francois Panisset * PEP8 code style fix Signed-off-by: Jean-Francois Panisset * add missing changelog fragment Signed-off-by: Jean-Francois Panisset --- changelogs/fragments/3896-nmcli_vlan_missing_options.yaml | 2 ++ plugins/modules/net_tools/nmcli.py | 3 +++ 2 files changed, 5 insertions(+) create mode 100644 changelogs/fragments/3896-nmcli_vlan_missing_options.yaml diff --git a/changelogs/fragments/3896-nmcli_vlan_missing_options.yaml b/changelogs/fragments/3896-nmcli_vlan_missing_options.yaml new file mode 100644 index 0000000000..8fab1ac37c --- /dev/null +++ b/changelogs/fragments/3896-nmcli_vlan_missing_options.yaml @@ -0,0 +1,2 @@ +bugfixes: + - nmcli - pass ``flags``, ``ingress``, ``egress`` params to ``nmcli`` (https://github.com/ansible-collections/community.general/issues/1086). diff --git a/plugins/modules/net_tools/nmcli.py b/plugins/modules/net_tools/nmcli.py index 61f2674372..bb656b3a23 100644 --- a/plugins/modules/net_tools/nmcli.py +++ b/plugins/modules/net_tools/nmcli.py @@ -1373,6 +1373,9 @@ class Nmcli(object): options.update({ 'vlan.id': self.vlanid, 'vlan.parent': self.vlandev, + 'vlan.flags': self.flags, + 'vlan.ingress': self.ingress, + 'vlan.egress': self.egress, }) elif self.type == 'vxlan': options.update({