a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gem: Fix get_installed_versions: correctly parse "default" version. (#783) 

* Fix get_installed_versions: correctly parse "default" version.

gem query output of

    bundler (default: 2.1.4, 1.17.2)

Gets parsed as:

    ['default:', '1.17.2']

Fix this by skipping "default: " if present in the list of versions - by adding
it as an optional part of the regex, grouped as a non-capturing group to keep
the index of existing group.

This now correctly parses the above input as

    ['2.1.4:', '1.17.2']

Fixes #782

* Fix gem get_installed_versions (cont): add changelog fragment

* Update changelogs/fragments/783-fix-gem-installed-versions.yaml as per suggestion

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
pull/849/head
Vlad Mencl 2020-09-03 17:47:34 +12:00 committed by GitHub
parent 8f2b2d9dc6
commit 6dc98c08fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/783-fix-gem-installed-versions.yaml Normal file
View File

@ -0,0 +1,2 @@
bugfixes:
- "gem - fix get_installed_versions: correctly parse ``default`` version (https://github.com/ansible-collections/community.general/pull/783)."

2
plugins/modules/packaging/language/gem.py
View File

@ -157,7 +157,7 @@ def get_installed_versions(module, remote=False):
(rc, out, err) = module.run_command(cmd, environ_update=environ, check_rc=True) (rc, out, err) = module.run_command(cmd, environ_update=environ, check_rc=True)
installed_versions = [] installed_versions = []
for line in out.splitlines(): for line in out.splitlines():
match = re.match(r"\S+\s+\((.+)\)", line) match = re.match(r"\S+\s+\((?:default: )?(.+)\)", line)
if match: if match:
versions = match.group(1) versions = match.group(1)
for version in versions.split(', '): for version in versions.split(', '):