a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not mark "skipped" when changed is false 

When using the "creates" option with the unarchive module, set changed
to False if the file already exists. This behavior is consistent with
other modules which use "creates", such as command and shell.
pull/4420/head
Dan Rue 2015-02-17 15:02:08 -06:00
parent 50379d59ba
commit 787388ac30
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/ansible/runner/action_plugins/unarchive.py
View File

@ -69,7 +69,6 @@ class ActionModule(object):
conn=conn, conn=conn,
comm_ok=True, comm_ok=True,
result=dict( result=dict(
skipped=True,
changed=False, changed=False,
msg=("skipped, since %s exists" % creates) msg=("skipped, since %s exists" % creates)
) )

2
test/integration/roles/test_unarchive/tasks/main.yml
View File

@ -96,7 +96,6 @@
assert: assert:
that: that:
- "unarchive02c.changed == false" - "unarchive02c.changed == false"
- "unarchive02c.skipped == true"
- name: unarchive a tar.gz file with creates over an existing file using complex_args - name: unarchive a tar.gz file with creates over an existing file using complex_args
unarchive: unarchive:
@ -110,7 +109,6 @@
assert: assert:
that: that:
- "unarchive02d.changed == false" - "unarchive02d.changed == false"
- "unarchive02d.skipped == true"
- name: remove our tar.gz unarchive destination - name: remove our tar.gz unarchive destination
file: path={{output_dir}}/test-unarchive-tar-gz state=absent file: path={{output_dir}}/test-unarchive-tar-gz state=absent