Merge pull request #965 from dhozac/cowsay-no-shell

Invoke cowsay without going through the shell
2012-08-29 15:55:43 -07:00 · 2012-08-29 15:55:43 -07:00 · 7bb9f71a7e
parent 00c4c5c4a1 2d448f2a34
commit 7bb9f71a7e
1 changed files with 2 additions and 2 deletions
--- a/lib/ansible/callbacks.py
+++ b/lib/ansible/callbacks.py
@ -121,8 +121,8 @@ def regular_generic_msg(hostname, result, oneline, caption):
 def banner(msg):

    if cowsay != None:
-        cmd = subprocess.Popen("%s -W 60 \"%s\"" % (cowsay, msg),
-            stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True)
+        cmd = subprocess.Popen([cowsay, "-W", "60", msg],
+            stdout=subprocess.PIPE, stderr=subprocess.PIPE)
        (out, err) = cmd.communicate()
        return "%s\n" % out
    else: