a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

no-smart-quotes: Skip files by path in code-smell (#45881) 

* no-smart-quotes: Skip files by path in code-smell

This is to ensure the generated docs do not trigger code-smell issues on
contributor systems.

* Implement feedback from review
pull/4420/head
Dag Wieers 2018-12-18 20:33:18 +01:00 committed by GitHub
parent 13f2b29305
commit 7fb1a71a2c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/sanity/code-smell/no-smart-quotes.py
View File

@ -8,19 +8,26 @@ import sys
def main(): def main():
skip = set([ skip = set([
'test/sanity/code-smell/%s' % os.path.basename(__file__),
'docs/docsite/rst/dev_guide/testing/sanity/no-smart-quotes.rst', 'docs/docsite/rst/dev_guide/testing/sanity/no-smart-quotes.rst',
'test/integration/targets/unicode/unicode.yml',
'test/integration/targets/lookup_properties/lookup-8859-15.ini', 'test/integration/targets/lookup_properties/lookup-8859-15.ini',
'test/integration/targets/template/files/encoding_1252_utf-8.expected', 'test/integration/targets/template/files/encoding_1252_utf-8.expected',
'test/integration/targets/template/files/encoding_1252_windows-1252.expected', 'test/integration/targets/template/files/encoding_1252_windows-1252.expected',
'test/integration/targets/template/templates/encoding_1252.j2', 'test/integration/targets/template/templates/encoding_1252.j2',
'test/integration/targets/unicode/unicode.yml',
'test/sanity/code-smell/%s' % os.path.basename(__file__),
])
prune = set([
'docs/docsite/_build/',
]) ])
for path in sys.argv[1:] or sys.stdin.read().splitlines(): for path in sys.argv[1:] or sys.stdin.read().splitlines():
if path in skip: if path in skip:
continue continue
if any(path.startswith(p) for p in prune):
continue
with open(path, 'rb') as path_fd: with open(path, 'rb') as path_fd:
for line, text in enumerate(path_fd.readlines()): for line, text in enumerate(path_fd.readlines()):
try: try: