a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make sure PlayContext is copied when iterating in a with_ loop

pull/4420/head
James Cammarata 2015-09-03 08:11:30 -04:00
parent c16961db60
commit 8774ff5f57
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/ansible/executor/task_executor.py
View File

@ -188,15 +188,18 @@ class TaskExecutor:
try: try:
tmp_task = self._task.copy() tmp_task = self._task.copy()
tmp_play_context = self._play_context.copy()
except AnsibleParserError as e: except AnsibleParserError as e:
results.append(dict(failed=True, msg=str(e))) results.append(dict(failed=True, msg=str(e)))
continue continue
# now we swap the internal task with the copy, execute, # now we swap the internal task and play context with their copies,
# and swap them back so we can do the next iteration cleanly # execute, and swap them back so we can do the next iteration cleanly
(self._task, tmp_task) = (tmp_task, self._task) (self._task, tmp_task) = (tmp_task, self._task)
(self._play_context, tmp_play_context) = (tmp_play_context, self._play_context)
res = self._execute(variables=task_vars) res = self._execute(variables=task_vars)
(self._task, tmp_task) = (tmp_task, self._task) (self._task, tmp_task) = (tmp_task, self._task)
(self._play_context, tmp_play_context) = (tmp_play_context, self._play_context)
# now update the result with the item info, and append the result # now update the result with the item info, and append the result
# to the list of results # to the list of results