a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Always set `result` variable in `cloudflare_dns` module (#23683) 

Fixes #23682
pull/4420/head
Jack Price 2017-07-20 13:16:37 +01:00 committed by René Moser
parent 5ab8d30d10
commit aed35aba70
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/ansible/modules/net_tools/cloudflare_dns.py
View File

@ -596,13 +596,17 @@ class CloudflareAPI(object):
if (type == 'CNAME') and (cur_record['content'] != new_record['content']): if (type == 'CNAME') and (cur_record['content'] != new_record['content']):
do_update = True do_update = True
if do_update: if do_update:
if not self.module.check_mode: if self.module.check_mode:
result = new_record
else:
result, info = self._cf_api_call('/zones/{0}/dns_records/{1}'.format(zone_id,records[0]['id']),'PUT',new_record) result, info = self._cf_api_call('/zones/{0}/dns_records/{1}'.format(zone_id,records[0]['id']),'PUT',new_record)
self.changed = True self.changed = True
return result,self.changed return result,self.changed
else: else:
return records,self.changed return records,self.changed
if not self.module.check_mode: if self.module.check_mode:
result = new_record
else:
result, info = self._cf_api_call('/zones/{0}/dns_records'.format(zone_id),'POST',new_record) result, info = self._cf_api_call('/zones/{0}/dns_records'.format(zone_id),'POST',new_record)
self.changed = True self.changed = True
return result,self.changed return result,self.changed