a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Call parent super() in RoleDefinition init before doing other stuff 

This only impacts the use of RoleDefinition directly, but it was a tricky
bug to spot.
pull/4420/head
James Cammarata 2017-02-10 08:26:01 -06:00
parent 0d418789a2
commit b5bf525828
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ansible/playbook/role/definition.py
View File

@ -49,6 +49,9 @@ class RoleDefinition(Base, Become, Conditional, Taggable):
_role = FieldAttribute(isa='string') _role = FieldAttribute(isa='string')
def __init__(self, play=None, role_basedir=None, variable_manager=None, loader=None): def __init__(self, play=None, role_basedir=None, variable_manager=None, loader=None):
super(RoleDefinition, self).__init__()
self._play = play self._play = play
self._variable_manager = variable_manager self._variable_manager = variable_manager
self._loader = loader self._loader = loader
@ -56,7 +59,6 @@ class RoleDefinition(Base, Become, Conditional, Taggable):
self._role_path = None self._role_path = None
self._role_basedir = role_basedir self._role_basedir = role_basedir
self._role_params = dict() self._role_params = dict()
super(RoleDefinition, self).__init__()
#def __repr__(self): #def __repr__(self):
# return 'ROLEDEF: ' + self._attributes.get('role', '<no name set>') # return 'ROLEDEF: ' + self._attributes.get('role', '<no name set>')