a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

redfish_utils: remove undocumented default applytime (#9114) 

* redfish_utils: remove undocumented default applytime

The `@Redfish.OperationApplyTime` parameter is optional as per Redfish
spec version 1.21.0, paragraph 7.11 [1]. Some systems reject the
request rather than ignore it, causing failures that can not be
workarounded.

Removing this default resolves compatibility issues.

[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.21.0.html

Signed-off-by: Tan Siewert <tan@siewert.io>

* redfish_utils: fix changelog fragment to bugfix

Signed-off-by: Tan Siewert <tan@siewert.io>

---------

Signed-off-by: Tan Siewert <tan@siewert.io>
pull/9145/head
Tan Siewert 2024-11-11 11:04:14 -08:00 committed by GitHub
parent d27d86ecb1
commit bafb8aca29
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/9114-redfish-utils-update-remove-default-applytime.yml Normal file
View File

@ -0,0 +1,2 @@
bugfixes:
- redfish_utils module utils - remove undocumented default applytime (https://github.com/ansible-collections/community.general/pull/9114).

2
plugins/module_utils/redfish_utils.py
View File

@ -1958,7 +1958,7 @@ class RedfishUtils(object):
update_uri = data['MultipartHttpPushUri'] update_uri = data['MultipartHttpPushUri']
# Assemble the JSON payload portion of the request # Assemble the JSON payload portion of the request
payload = {"@Redfish.OperationApplyTime": "Immediate"} payload = {}
if targets: if targets:
payload["Targets"] = targets payload["Targets"] = targets
if apply_time: if apply_time: