From bfc6a2a8d6342c7f36038c2216dc8f3e50a6244a Mon Sep 17 00:00:00 2001 From: Ondra Machacek Date: Tue, 26 Mar 2019 15:00:27 +0100 Subject: [PATCH] ovirt: Require SDK v4.3.0 (#54385) --- lib/ansible/module_utils/ovirt.py | 4 ++-- lib/ansible/modules/cloud/ovirt/ovirt_auth.py | 4 ++-- lib/ansible/plugins/doc_fragments/ovirt.py | 4 ++-- lib/ansible/plugins/doc_fragments/ovirt_facts.py | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/ansible/module_utils/ovirt.py b/lib/ansible/module_utils/ovirt.py index 2114e93d60..254826e205 100644 --- a/lib/ansible/module_utils/ovirt.py +++ b/lib/ansible/module_utils/ovirt.py @@ -34,7 +34,7 @@ try: import ovirtsdk4 as sdk import ovirtsdk4.version as sdk_version import ovirtsdk4.types as otypes - HAS_SDK = LooseVersion(sdk_version.VERSION) >= LooseVersion('4.2.4') + HAS_SDK = LooseVersion(sdk_version.VERSION) >= LooseVersion('4.3.0') except ImportError: HAS_SDK = False @@ -51,7 +51,7 @@ BYTES_MAP = { def check_sdk(module): if not HAS_SDK: module.fail_json( - msg='ovirtsdk4 version 4.2.4 or higher is required for this module' + msg='ovirtsdk4 version 4.3.0 or higher is required for this module' ) diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_auth.py b/lib/ansible/modules/cloud/ovirt/ovirt_auth.py index 407ee88033..bcc8eb61d9 100644 --- a/lib/ansible/modules/cloud/ovirt/ovirt_auth.py +++ b/lib/ansible/modules/cloud/ovirt/ovirt_auth.py @@ -98,14 +98,14 @@ options: requirements: - python >= 2.7 - - ovirt-engine-sdk-python >= 4.2.4 + - ovirt-engine-sdk-python >= 4.3.0 notes: - "Everytime you use ovirt_auth module to obtain ticket, you need to also revoke the ticket, when you no longer need it, otherwise the ticket would be revoked by engine when it expires. For an example of how to achieve that, please take a look at I(examples) section." - "In order to use this module you have to install oVirt/RHV Python SDK. To ensure it's installed with correct version you can create the following task: - I(pip: name=ovirt-engine-sdk-python version=4.2.4)" + I(pip: name=ovirt-engine-sdk-python version=4.3.0)" - "Note that in oVirt/RHV 4.1 if you want to use a user which is not administrator you must enable the I(ENGINE_API_FILTER_BY_DEFAULT) variable in engine. In oVirt/RHV 4.2 and later it's enabled by default." diff --git a/lib/ansible/plugins/doc_fragments/ovirt.py b/lib/ansible/plugins/doc_fragments/ovirt.py index d564854fd1..3667b7d886 100644 --- a/lib/ansible/plugins/doc_fragments/ovirt.py +++ b/lib/ansible/plugins/doc_fragments/ovirt.py @@ -94,9 +94,9 @@ options: default: 3 requirements: - python >= 2.7 - - ovirt-engine-sdk-python >= 4.2.4 + - ovirt-engine-sdk-python >= 4.3.0 notes: - "In order to use this module you have to install oVirt Python SDK. To ensure it's installed with correct version you can create the following task: - I(pip: name=ovirt-engine-sdk-python version=4.2.4)" + I(pip: name=ovirt-engine-sdk-python version=4.3.0)" ''' diff --git a/lib/ansible/plugins/doc_fragments/ovirt_facts.py b/lib/ansible/plugins/doc_fragments/ovirt_facts.py index db687b8e25..374745bcad 100644 --- a/lib/ansible/plugins/doc_fragments/ovirt_facts.py +++ b/lib/ansible/plugins/doc_fragments/ovirt_facts.py @@ -48,9 +48,9 @@ options: required: true requirements: - python >= 2.7 - - ovirt-engine-sdk-python >= 4.2.4 + - ovirt-engine-sdk-python >= 4.3.0 notes: - "In order to use this module you have to install oVirt Python SDK. To ensure it's installed with correct version you can create the following task: - pip: name=ovirt-engine-sdk-python version=4.2.4" + pip: name=ovirt-engine-sdk-python version=4.3.0" '''