From d8d4dc3f526f808389e84362e69d857acbe8b5b6 Mon Sep 17 00:00:00 2001
From: Abhijeet Kasurde <akasurde@redhat.com>
Date: Tue, 5 Feb 2019 11:50:15 +0530
Subject: [PATCH] VMware: Check for category id before assigning (#51684)

Check if user specified category exists in environment,
before assigning it to the tag creation operation.

Fixes: #51381

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
---
 .../modules/cloud/vmware/vmware_tag.py        | 34 ++++++++++++-------
 1 file changed, 22 insertions(+), 12 deletions(-)

diff --git a/lib/ansible/modules/cloud/vmware/vmware_tag.py b/lib/ansible/modules/cloud/vmware/vmware_tag.py
index 46988825ac..9a3f17741d 100644
--- a/lib/ansible/modules/cloud/vmware/vmware_tag.py
+++ b/lib/ansible/modules/cloud/vmware/vmware_tag.py
@@ -109,7 +109,7 @@ results:
 from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.vmware_rest_client import VmwareRestClient
 try:
-    from com.vmware.cis.tagging_client import Tag
+    from com.vmware.cis.tagging_client import Tag, Category
 except ImportError:
     pass
 
@@ -121,10 +121,11 @@ class VmwareTag(VmwareRestClient):
         self.global_tags = dict()
         self.tag_name = self.params.get('tag_name')
         self.get_all_tags()
+        self.category_service = Category(self.connect)
 
     def ensure_state(self):
         """
-        Function to manage internal states of tags
+        Manage internal states of tags
 
         """
         desired_state = self.params.get('state')
@@ -142,7 +143,7 @@ class VmwareTag(VmwareRestClient):
 
     def state_create_tag(self):
         """
-        Function to create tag
+        Create tag
 
         """
         tag_spec = self.tag_service.CreateSpec()
@@ -151,6 +152,17 @@ class VmwareTag(VmwareRestClient):
         category_id = self.params.get('category_id', None)
         if category_id is None:
             self.module.fail_json(msg="'category_id' is required parameter while creating tag.")
+
+        category_found = False
+        for category in self.category_service.list():
+            category_obj = self.category_service.get(category)
+            if category_id == category_obj.id:
+                category_found = True
+                break
+
+        if not category_found:
+            self.module.fail_json(msg="Unable to find category specified using 'category_id' - %s" % category_id)
+
         tag_spec.category_id = category_id
         tag_id = self.tag_service.create(tag_spec)
         if tag_id:
@@ -162,14 +174,14 @@ class VmwareTag(VmwareRestClient):
 
     def state_unchanged(self):
         """
-        Function to return unchanged state
+        Return unchanged state
 
         """
         self.module.exit_json(changed=False)
 
     def state_update_tag(self):
         """
-        Function to update tag
+        Update tag
 
         """
         changed = False
@@ -187,7 +199,7 @@ class VmwareTag(VmwareRestClient):
 
     def state_delete_tag(self):
         """
-        Function to delete tag
+        Delete tag
 
         """
         tag_id = self.global_tags[self.tag_name]['tag_id']
@@ -198,18 +210,16 @@ class VmwareTag(VmwareRestClient):
 
     def check_tag_status(self):
         """
-        Function to check if tag exists or not
+        Check if tag exists or not
         Returns: 'present' if tag found, else 'absent'
 
         """
-        if self.tag_name in self.global_tags:
-            return 'present'
-        else:
-            return 'absent'
+        ret = 'present' if self.tag_name in self.global_tags else 'absent'
+        return ret
 
     def get_all_tags(self):
         """
-        Function to retrieve all tag information
+        Retrieve all tag information
 
         """
         for tag in self.tag_service.list():