a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

removes command caching on retrieve from netcli 

The caching of commands in CommandRunner is providing no useful feature
and causing problems.  This removes the code and simply returns the
requested command results.
pull/4420/head
Peter Sprygada 2016-09-06 16:53:14 -04:00
parent 37f721f315
commit da931b04ad
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/ansible/module_utils/netcli.py
View File

@ -127,7 +127,6 @@ class CommandRunner(object):
self.match = 'all' self.match = 'all'
self._cache = dict()
self._default_output = module.connection.default_output self._default_output = module.connection.default_output
@ -140,15 +139,9 @@ class CommandRunner(object):
self.commands.append(cmd) self.commands.append(cmd)
def get_command(self, command, output=None): def get_command(self, command, output=None):
output = output or self._default_output for cmd in self.commands:
try: if cmd.command == command:
cmdobj = self._cache[(command, output)] return cmd.response
return cmdobj.response
except KeyError:
for cmd in self.commands:
if cmd.command == command and cmd.output == output:
self._cache[(command, output)] = cmd
return cmd.response
raise ValueError("command '%s' not found" % command) raise ValueError("command '%s' not found" % command)
def get_responses(self): def get_responses(self):