From dd9b2c077472eaf446ff932c8ae1877d00147299 Mon Sep 17 00:00:00 2001 From: Adam Miller Date: Fri, 2 Feb 2018 10:52:58 -0600 Subject: [PATCH] make v2_playbook_on_notify method signatures consistent This was causing an exception in the TaskQueueManager when a third party handler plugin was processed that inherited or explicitly called the callback method from super because the method signature was incorrect in callback/__init__ and it processed the arguments as incorrect data types as a side effect. Signed-off-by: Adam Miller --- lib/ansible/plugins/callback/__init__.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ansible/plugins/callback/__init__.py b/lib/ansible/plugins/callback/__init__.py index 982f06ab83..14f1b9d0bd 100644 --- a/lib/ansible/plugins/callback/__init__.py +++ b/lib/ansible/plugins/callback/__init__.py @@ -348,8 +348,7 @@ class CallbackBase(AnsiblePlugin): def v2_playbook_on_start(self, playbook): self.playbook_on_start() - def v2_playbook_on_notify(self, result, handler): - host = result._host.get_name() + def v2_playbook_on_notify(self, handler, host): self.playbook_on_notify(host, handler) def v2_playbook_on_no_hosts_matched(self):