d9337fbd9c
update current_link without downtime
...
fix support of check mode
fix check module when needn't update current link
2016-12-08 11:33:39 -05:00
40a4247611
Sync minor fixes from OpenStack Infra
...
Infra has been keeping a local copy of this waiting for ansible 2 to
release. In getting ready for ansible 2 (and our ability to delete our
local copy of the file, I noticed we had a couple of minor cleanups.
Also, the timeout command is there to improve life and workaround puppet
deficiencies. However, it's not working around deficiencies on systems
that do not have the timeout command if we blindly use it.
The puppet specific timeout options are more complex and out of scope of
this.
Issue: #1273
2016-12-08 11:33:39 -05:00
7ecbd8e34e
cloudstack: cs_instance: fixes and improvements
...
- cs_instance: fix VM not updated with states given stopped, started, restarted
A missing VM will be created though but an existing not updated. This fixes the lack of consistency.
- cs_instance: fix user data can not be cleared
- cs_instance: fix deleted VM not recovered on state=present
2016-12-08 11:33:39 -05:00
9387c842a1
Use "" for AppParameters if it's null
2016-12-08 11:33:39 -05:00
5f43afff5b
cloudstack: cs_facts: fix wrong description of returns cloudstack_public_ipv4, cloudstack_public_hostname
...
Also see http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/4.6/api.html#user-data-and-meta-data
2016-12-08 11:33:39 -05:00
73c6a35cae
cloudstack: cs_instance: implement state=restored
2016-12-08 11:33:39 -05:00
fa852c14fe
Fixed bug to recognize haproxy changes
2016-12-08 11:33:39 -05:00
ccb5829673
added missing version_added to new options
2016-12-08 11:33:39 -05:00
42d89dec18
win_chocolatey: Clean up documentation
2016-12-08 11:33:39 -05:00
633773f386
win_chocolatey: Add install_args, params and ignoredependencies
2016-12-08 11:33:39 -05:00
cb338ccb46
Doc fix ec2_vpc_route_table.py
2016-12-08 11:33:39 -05:00
74a0665530
Doc fix on route53_health_check.py. Fixed first example. Should be register instead of record.
2016-12-08 11:33:39 -05:00
6f663fa7bf
Set latest as version argument default value
2016-12-08 11:33:38 -05:00
a9abec5a03
updated version version_added to 2.1
2016-12-08 11:33:38 -05:00
766b53b066
added version option
2016-12-08 11:33:38 -05:00
f1f98a15ca
Fixes #634 - multiple param handling by modprobe.py
2016-12-08 11:33:38 -05:00
4db5119893
corrected version_added for new monit timeout opt
2016-12-08 11:33:38 -05:00
d577fedc26
monit: Set a high timeout waiting for status changes
...
Instead of waiting for up to a certain number of retries we set a high
timeout and only re-check every five seconds. Certain services can
take a minute or more to start and we want to avoid waisting resources
by polling too often.
2016-12-08 11:33:38 -05:00
69e9bd3406
monit: Add version_added and type for new argument
2016-12-08 11:33:38 -05:00
757c9bffee
monit: Wait for pending state changes for reloads
...
@mpeters reported that we're not checking that the named service is
actually there after a reload. And that sometimes monit doesn't actually
return anything at all after a reload.
2016-12-08 11:33:38 -05:00
469bf9ebd0
monit: Add retry for pending/initializing services
...
If there are already ongoing actions for a process managed by monit, the
module would exit unsuccessfully. It could also give off false positives
because it did not determine whether the service was started/stopped
when it was in a pending state. Which might be turning the service off,
but the action was to start it.
For example "Running - pending stop" would be regarded as the service
running and "state=enabled" would do nothing.
This will make Ansible wait for the state to finalize, or a timeout decided
by the new `max_retries` option, before it decides what to do.
This fixes issue #244 .
2016-12-08 11:33:38 -05:00
5f743c4fdc
maven_artifact: check whether snapshot is the latest snapshot
2016-12-08 11:33:38 -05:00
d24f02fd39
Fix up vsphere_copy after open_url change
...
* Remove leading module parameter on open_url call as it's no longer used
by module_utils.urls.open_url
* Force basic auth otherwise vsphere will just return a 401
2016-12-08 11:33:38 -05:00
33ee8d6f89
Correct 'object not iterable' TypeError
2016-12-08 11:33:38 -05:00
e5970186ad
Remove extraneous space from end of command string in nagios_cmd
2016-12-08 11:33:38 -05:00
ab7aa73cdb
Correct problem with changed:true
...
I have just changed a small piece of this module to avoid to return always that the task is changed
2016-12-08 11:33:38 -05:00
0606233431
Changing docs to reflect vm_name as the default vm_id_type
2016-12-08 11:33:38 -05:00
103be7ab51
Added missing else statement that caused existing rules to be discarded
2016-12-08 11:33:38 -05:00
caea50ba4d
pep8 whitespace
2016-12-08 11:33:37 -05:00
a1efe9486a
upped version added, search by vm_name by default
2016-12-08 11:33:37 -05:00
8f362afc34
vmware_vm_shell: add the ability to start program without network connection
2016-12-08 11:33:37 -05:00
6f40bab20f
Simplify code
2016-12-08 11:33:37 -05:00
13deae9b8f
zypper: Add returncode to result
...
This will be used in integration tssts and makes the whole thing
more similar to the yum module.
2016-12-08 11:33:37 -05:00
c23162c04b
Fix documentation to prevent formatting error where each letter has its own line.
2016-12-08 11:33:37 -05:00
30da816c54
Fix #1101 : win_webpicmd strict mode fixes
2016-12-08 11:33:37 -05:00
c60d6cad72
corrected version added to 2.1
2016-12-08 11:33:37 -05:00
f547c37db4
Use doc fragment and fix examples
2016-12-08 11:33:37 -05:00
2b0fc33fd5
Tolerate missing classic_link_enabled attribute
2016-12-08 11:33:37 -05:00
a873e9a3cb
New module - ec2_vpc_net_facts
2016-12-08 11:33:37 -05:00
6278cef67b
Enable to resize a volume with cs_volume
2016-12-08 11:33:37 -05:00
5b3363d178
Replace slashes in the parameter string Also remove duplicate documentation
2016-12-08 11:33:37 -05:00
4e4085ad7e
Add a more explicit error message, fix #1282
2016-12-08 11:33:37 -05:00
28baed011d
Appending "Registry::" is not needed and no longer works.
2016-12-08 11:33:37 -05:00
af12e6d3a3
Resolves #1312 , Improve pam_limits documentation
...
Adds comment parameter and improve examples.
2016-12-08 11:33:37 -05:00
bee443c983
Fix error 'fail_json() takes exactly 1 argument'
...
Fixes bug #1257
2016-12-08 11:33:36 -05:00
058feb47c2
Fix mongodb_user docs typo
...
Bob's last name is Belcher: http://bobs-burgers.wikia.com/wiki/Bob_Belcher .
These docs made me chuckle, so thanks :)
2016-12-08 11:33:36 -05:00
5bd1bcaa2d
Don't raise or catch StandardError in amazon modules
2016-12-08 11:33:36 -05:00
5fbc5cb529
Resolves #1290 , Adds limit_type choice "-"
2016-12-08 11:33:36 -05:00
2715cbffb7
cloudstack: new module cs_volume
2016-12-08 11:33:36 -05:00
f30dbc9b20
Added stdout and stderr to puppet output for rc=2
2016-12-08 11:33:36 -05:00
fa9e1fd384
Ensure tag values get updated in ec2_vpc_subnet
2016-12-08 11:33:36 -05:00
1899e9e6cc
Use boto normalized location for bucket creation
...
If a bucket is being created in us-east-1, the module passed
'us-east-1' to boto's s3.create_bucket method rather than
Location.DEFAULT (an empty string). This caused boto to generate
invalid XML which AWS was unable to interpret.
2016-12-08 11:33:36 -05:00
b3ffcd7c6c
fix race condition and missing property
2016-12-08 11:33:36 -05:00
d4d24bac60
Adding yumrepo module
...
This patch is adding a new module which allows to add and remove YUM
repository definitions. The module implements all repository options
as described in the `yum.conf` manual page.
2016-12-08 11:33:36 -05:00
4ddb181d71
removed json import
2016-12-08 11:33:36 -05:00
f68b88b84d
Quote strings that make the module docs fail to build
2016-12-08 11:33:36 -05:00
d6db0f3981
Switch StrictVersion for LooseVersion since some distros ship beta versions and StrictVersion would fail on that.
...
Also clean up some minor style things
2016-12-08 11:33:36 -05:00
c048990419
Add requirement and check for compatible version of docker-py
2016-12-08 11:33:36 -05:00
64838bb52d
Set no_log for password argument
2016-12-08 11:33:35 -05:00
7c8d1a1d0a
Improve registry key parity between clients * Don't extract hostname part from docker_url since this leads to docker CLI client not recognizing Docker Hub credentials set by docker_login module anymore (looks for the full URL as a key).
2016-12-08 11:33:35 -05:00
b826aa6b35
Rework change detection
2016-12-08 11:33:35 -05:00
348cab4511
Adapt to new dockercfg file location and structure
2016-12-08 11:33:35 -05:00
d330f72213
Make module importable for unit tests
2016-12-08 11:33:35 -05:00
32862e737f
Set default for email parameter to None
2016-12-08 11:33:35 -05:00
dab1588253
Add requirement for python >= 2.6
2016-12-08 11:33:35 -05:00
4ea0125dc6
Default registry to docker hub
2016-12-08 11:33:35 -05:00
a64bae30b5
Added more meaningful fail messages on Docker API
2016-12-08 11:33:35 -05:00
dfaa1ec528
Added default email address
2016-12-08 11:33:35 -05:00
36330d00ad
Removed unused import of sys module
2016-12-08 11:33:35 -05:00
e998090d52
Extract only the hostname part from self.registry This is needed for update_dockercfg() to register only the host part of a specified registry URL in the .dockercfg.
2016-12-08 11:33:35 -05:00
c42d94edd1
Remove registry from exit_json because misleading docker-py is not returning the name of the registry if already logged in. It can differ from the registry specified by the user, which was return as registry.
2016-12-08 11:33:35 -05:00
9d69e78f18
Update PR based on review from @resmo
2016-12-08 11:33:34 -05:00
d23f78c799
Add docker_login module - Ansible version of "docker login" CLI command - Persists Docker registry authentification in .dockercfg (only login once - no need to specify credentials over and over again anymore) - Works for all other docker-py based modules (docker, docker_images) as well as the Docker CLI client
2016-12-08 11:33:34 -05:00
e8b5b8bd20
Editing iptable module to use -m state --state instead of -m conntrack --ctstate
2016-12-08 11:33:34 -05:00
a7b90cf456
Fix return documentation
2016-12-08 11:33:34 -05:00
bbdebd7548
Add openstack project module
2016-12-08 11:33:34 -05:00
66569ab725
Sendgrid docs fix
2016-12-08 11:33:34 -05:00
507986703c
corrected choices which was meant to be type
2016-12-08 11:33:34 -05:00
df517b5f03
Version bump for new beta 2.0.0-0.5.beta3
2016-12-08 11:33:34 -05:00
c277a8b191
Added style= and more colors.
2016-12-08 11:33:34 -05:00
ae72b7c12c
New module: blockinfile
2016-12-08 11:33:34 -05:00
92efb6eb51
homebrew: Aditional examples for documentation
2016-12-08 11:33:34 -05:00
273d1c51e6
homebrew: Add explicit documentation for 'path' argument (with expected default)
...
In Homebew, a formula is installed in a location relative to the actual
`brew` command. The documentation clarifies that.
Additionally, removed redundant 'path' reconstruction in multiple places.
2016-12-08 11:33:34 -05:00
a364ec5483
exchange name contains chars that needs to be quoted
2016-12-08 11:33:34 -05:00
5bedb1f12d
Add sns_topic module to manage AWS SNS topics
...
This adds an sns_topic module which allows you to create and delete AWS
SNS topics as well as subscriptions to those topics.
2016-12-08 11:33:34 -05:00
0fbfcc3b20
Add new module to allow for getting and listing of Route53 relevant details
2016-12-08 11:33:34 -05:00
c908c0663d
revert to unbreak pull request
2016-12-08 11:33:34 -05:00
c766cbd98a
in order for replication setup to work, some errors should be ignored
2016-12-08 11:33:33 -05:00
4e401fc4e6
including error code and error number when database connection creation fails
2016-12-08 11:33:33 -05:00
85f2165273
better cope with rpm not returning package name
...
if the rpm query is missing a package name (or giving some error): fail soft
before the patch: the module fails because the installed_state dict is missing the package name
after the patch: the missing package is assumed to not be in the correct state and is installed/removed with zypper
2016-12-08 11:33:33 -05:00
b36b12e968
Allow NPM to update packages
2016-12-08 11:33:33 -05:00
83bf44c78f
allows user to not update zabbix host config if host is present.
2016-12-08 11:33:33 -05:00
9802112dd4
fixes a typo in Datadog Monitor docs
2016-12-08 11:33:33 -05:00
40e6b3870e
Fix documentation, the correct parameter is "name"
2016-12-08 11:33:33 -05:00
4e72c23bae
Fixed call to module.log
2016-12-08 11:33:33 -05:00
f475a123c0
Add new SMEs for Zabbix
2016-12-08 11:33:33 -05:00
482f0a8d1c
Prevent ec2_remote_facts from failing when listing a terminated instance
2016-12-08 11:33:33 -05:00
3ef5be470f
Fixing limit type from list to string
2016-12-08 11:33:33 -05:00
fbad76e86a
Adding limit feature to iptables module
2016-12-08 11:33:33 -05:00
61ba4b98e1
made ctstate default to [] and evaluation conditional on the list being popoulated
2016-12-08 11:33:33 -05:00
fb3aec47ca
fixed default from None to [] for ctstate
2016-12-08 11:33:33 -05:00
eae8942583
avoid index error on empty list, key being true means its not None nor [] fixes #13009
2016-12-08 11:33:33 -05:00
9ab42a98ca
no-suggests is obsolete, switch to no-recommends
2016-12-08 11:33:33 -05:00
2b860bbae8
Adds examples for win_iis_virtualdirectory
2016-12-08 11:33:32 -05:00
d8dc9485f4
Refactor ec2_remote_facts to use filters
2016-12-08 11:33:32 -05:00
6d166d75bc
Fix: support for virtual directories in applications
2016-12-08 11:33:32 -05:00
b8fbbdbff0
Fixing Some Issues with out Parameters are passed around. Also some refactoring.
2016-12-08 11:33:32 -05:00
3ad86e383e
added start mode feature
2016-12-08 11:33:32 -05:00
b2f666a2dd
strict variables fix
2016-12-08 11:33:32 -05:00
349c4a2a48
added dependency and user settings
2016-12-08 11:33:32 -05:00
51b1cd061a
Strict-Mode fixes
...
Changes to missing member handling to support running top-level script under Strict-Mode v2 (as Ansible 2.0.0 does now)
2016-12-08 11:33:32 -05:00
426613b00d
Fix broken examples in docs
2016-12-08 11:33:32 -05:00
42a27ce558
added missing : to docs
2016-12-08 11:33:32 -05:00
eb4fe5a0d8
made ctstate accept lists
2016-12-08 11:33:32 -05:00
d332a9a8e4
Add conntrack module ctstate support to iptables
2016-12-08 11:33:32 -05:00
a47427cddf
Return errno and http status as requested by @bcoca
2016-12-08 11:33:32 -05:00
24ce8887bf
Better status conditional from dagwieers
2016-12-08 11:33:32 -05:00
117f640bb9
Port vsphere_copy from httplib to open_url for TLS cert validation
2016-12-08 11:33:32 -05:00
185761bfcb
BUGFIX: misnamed function name breaks check mode
2016-12-08 11:33:32 -05:00
86bea2d6ab
fixed composer usage example
2016-12-08 11:33:31 -05:00
ae18a1d877
added constraint for space in composer command
2016-12-08 11:33:31 -05:00
662fa86f07
removed check for empty composer response
2016-12-08 11:33:31 -05:00
6e4b42ebbc
added version info for params 'arguments'
2016-12-08 11:33:31 -05:00
ae59ea7deb
allow specify arguments for composer
2016-12-08 11:33:31 -05:00
8c8c63110e
Move existing check for root before we make expensive network calls
2016-12-08 11:33:31 -05:00
8e255afbec
switched to 'support check mode' as it does not make changes and gathers information that might be needed for other tasks to check
2016-12-08 11:33:31 -05:00
83021279a1
new module ipify_facts
2016-12-08 11:33:31 -05:00
b7372b509a
corrected extension in module spec fixes #1190
2016-12-08 11:33:31 -05:00
92cbe5be0e
Fix #1107 : Prepend registry type on key path
2016-12-08 11:33:31 -05:00
6fed60c1bd
Fix #1107 : Use Get-Attr in win_regedit
2016-12-08 11:33:31 -05:00
9b9464ab89
Revert "Change show_diff to default to yes"
...
This was originally to match what puppet agent --test is, since the
rest of the options defaulted to on are grabbed from --test. However,
some security concerns have since been raised - namely that since this
is not the same invocation as --test but instead a remote orchestration
of puppet, the fact that passwords leak into the diff is a dangerous
default.
This reverts commit b86762c1806aa7f021a4780d06db2d3937910a62.
2016-12-08 11:33:31 -05:00
d90f91e802
Various improvements to win_package
2016-12-08 11:33:31 -05:00
9c75b5eac3
Make the pkg/name param into a list so that changes to make changes to _squash_items easier
2016-12-08 11:33:31 -05:00
682b7ce3bd
cloudstack: cs_portforward: fix example does not match description
2016-12-08 11:33:31 -05:00
29fad0223d
whitespace fixes
2016-12-08 11:33:30 -05:00
e4ce38fa0b
Adding comment support for iptables module
2016-12-08 11:33:30 -05:00
50905e5673
fixed typos in cryptab, thanks @timw fixes #1176
2016-12-08 11:33:30 -05:00
c3ecf5a0bf
added author to module doc string.
2016-12-08 11:33:30 -05:00
34ba9fa4f8
Added RETURN doc string for all modules and few minor enhancements.
2016-12-08 11:33:30 -05:00
e6fe4b10f5
Fix docs for ec2_vpc_route_table
...
The documentation pointed to vpc_peering_connection, not vpc_peering_connection_id.
2016-12-08 11:33:30 -05:00
5c494fb37b
Remove @lorin from list of reviewers
2016-12-08 11:33:30 -05:00
8e557dfc45
Made win_iis_webapppool Strict Compliant
2016-12-08 11:33:30 -05:00
8e509c2736
fix typo error
...
fix spell error for whether
2016-12-08 11:33:30 -05:00
164e1f3baa
Fix ZFS create
...
This was failing due to the createparent variable being referenced but
never actually loaded from properties
2016-12-08 11:33:30 -05:00
d9a29f394f
fixed missed passing use-sudo
2016-12-08 11:33:30 -05:00
d43d4718f3
system: pam_limits: add support for unlimited/infinity/-1
...
Early pam_limits module didn't support special values for items.
This patch is adding support to special values unlimited, infinity and -1.
Issue: https://github.com/ansible/ansible-modules-extras/issues/1033
Signed-off-by: Ondra Machacek <machacek.ondra@gmail.com>
2016-12-08 11:33:30 -05:00
451a05c1a2
Change show_diff to default to yes, to match what puppet agent --test is, since the rest of the options defaulted to on are grabbed from --test
2016-12-08 11:33:30 -05:00
c2a4e230aa
More consistent use of run_command() wrapper function, which now adds the default binary location to the search path
2016-12-08 11:33:30 -05:00
d26e062331
Version bump for new beta 2.0.0-0.4.beta2
2016-12-08 11:33:30 -05:00
79352b5e38
module guideline changes
2016-12-08 11:33:29 -05:00
c0b69067d7
added the folder structure and general explanation to examples, removed module name typo
2016-12-08 11:33:29 -05:00
88ac3eca78
removed link to guide, and added more documentation and examples
2016-12-08 11:33:29 -05:00
7841bf9c91
adding the deploy_helper module
2016-12-08 11:33:29 -05:00
a1dbb83075
fix errorhandling in zypper.py module
...
package_latest was calling package_present but did not care
about the return code so errors in package_present were hidden
and everthing look ok on the console when zypper update did not fail,
but no packages where installed.
2016-12-08 11:33:29 -05:00
d15b3776f0
added version_added to new feature, removed unused aliases
2016-12-08 11:33:29 -05:00
04efe69c34
configurable timeout for creating gce image
2016-12-08 11:33:29 -05:00
6777f634d5
tpyo in doc string
2016-12-08 11:33:29 -05:00
5e529a6afc
Use filters attribute rather than eni id so facts can be filtered on much more. Matches the new ec2_vpc_route_table_facts and ec2_vpc_subnet_facts modules
2016-12-08 11:33:29 -05:00
7c6175af3d
lookupMib=False for pysnmp 4.3.0
2016-12-08 11:33:29 -05:00
2dcbacd48e
Fix doc build by moving misplaced CIDR documentation
2016-12-08 11:33:29 -05:00
577566139f
fixed undefined msg and now actually return something meaningful fixes #1127
2016-12-08 11:33:29 -05:00
ea6fdeb585
cloudstack: add new loadbalancer rule modules
2016-12-08 11:33:29 -05:00
29d6313366
Handling dry run exception
2016-12-08 11:33:29 -05:00
253d177dc3
Check mode support for VPC route table creation
2016-12-08 11:33:29 -05:00
5574516934
pkgin: Support multiple matching packages
...
pkgin searches for packages such as 'emacs' can return multiple matches,
the first of which is not guaranteed to match. So, iterate through
found packages until we have an appropriate match. Should we *not* find
a match, then return False indicating match failure.
2016-12-08 11:33:29 -05:00
2f6f6cedf8
Fix #1099 : Only populate site result when it is there
2016-12-08 11:33:28 -05:00
002fc53863
minor change to remove extra brackets
2016-12-08 11:33:28 -05:00
85c09c9944
fixed typos
2016-12-08 11:33:28 -05:00
d13e34e131
corrected a typo
2016-12-08 11:33:28 -05:00
56cdaba0ab
ansible module for managing anti affinity policy in centurylink cloud has been added
2016-12-08 11:33:28 -05:00
843ad8e7e8
minor refactor to remove un-used parameter
2016-12-08 11:33:28 -05:00
fd09597267
removed empty aliases from doc string
2016-12-08 11:33:28 -05:00
a2c2efb2ae
Corrected a typo
2016-12-08 11:33:28 -05:00
4a8e3e9632
ansible module for managing alert policy in centurylink cloud has been added
2016-12-08 11:33:28 -05:00
01847f7bfc
Ansible module for managing server snapshots in Centurylink Cloud
2016-12-08 11:33:28 -05:00
60c495f18c
Fix win_acl docs build
2016-12-08 11:33:28 -05:00
0111b616d7
Fix docs to build
2016-12-08 11:33:28 -05:00
ebfb8bc7cf
iptables: add note about rules
2016-12-08 11:33:28 -05:00
8d93747275
iptables: expand rule options
2016-12-08 11:33:28 -05:00
1790722dd4
module: system/iptables
2016-12-08 11:33:28 -05:00
0524904dda
fixes examples in docs to use updated param name
2016-12-08 11:33:28 -05:00
43074a736d
changes param src to path, and updates docs accordingly
2016-12-08 11:33:27 -05:00
00a4ec5e3b
updates user search verification for local/domain - Thanks to @trondhindenes for implementing this strategy - also updated documentation
2016-12-08 11:33:27 -05:00
9ad30acd96
changes check for src
2016-12-08 11:33:27 -05:00
6abfcffc70
check if the rule exists or not before allow/deny rules are added/removed, and fixes where result changed would be true on all executions.
2016-12-08 11:33:27 -05:00
25a3793a49
inital commit win_acl
2016-12-08 11:33:27 -05:00
a65647efee
added version_added and fixed some doc parsing issues
2016-12-08 11:33:27 -05:00
c8e0f3a552
Add consul http checks to consul.py
...
Consul module already supports ttl and script checks. This commit adds
http checks.
2016-12-08 11:33:27 -05:00
fea8995df1
Fix bug #1105 - incorrect use of lstrip()
...
Remove only the literal prefix '/dev/mapper/' - not any of the characters
in '/dev/mapper/' - from the name param of the crypttab module.
2016-12-08 11:33:27 -05:00
d530764c49
fixed option in examples
2016-12-08 11:33:27 -05:00
3913de1c43
reference instance_id in docs, fixes for calls to fail_json
2016-12-08 11:33:27 -05:00
15ac8e9141
turned out strict msi code checking
2016-12-08 11:33:27 -05:00
4fc4030c58
Adding fix to get around bug found with the New-Webstire command when running playbook on a vanilla machine.
2016-12-08 11:33:27 -05:00
40a1bd1962
fix: Add 'enable:' flag for enabling existing rules which are disabled by default.
...
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.
Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.
But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
2016-12-08 11:33:27 -05:00
e0da4a3362
fix: update documentation with new module name "win_firewall_rule"
2016-12-08 11:33:27 -05:00
7188ae4fe1
fix: The names of firewall profiles are different on win10 & win2008r2
...
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).
For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.
Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.
Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
2016-12-08 11:33:27 -05:00
f64e438150
fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch.
...
In win10 (and pribably win8x also):
The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".
This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".
There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
2016-12-08 11:33:26 -05:00
b9dd3568f3
fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()'
...
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
2016-12-08 11:33:26 -05:00
1d09eaf6d0
updated the examples to the new Slack API
2016-12-08 11:33:26 -05:00
918012a42f
module guidelines compliency
2016-12-08 11:33:26 -05:00
Robert Lu
Monty Taylor
Rene Moser
gfrank
autotune
Brian Coca
Guido Lorenz
Vladimir Dimov
Kirill Kozlov
Dylan Martin
Will Keeling
Björn Andersson
Björn Andersson
Michal Svab
Matthew Jones
twmartin
Bruce Pennypacker
daveres
Chrrrles Paul
Rob
Charles Paul
Ritesh Khadgaray
Toshio Kuratomi
Guido Günther
Gordon Fierce
Brian Geihsler
Rob
whiter
Atsushi Sasaki
Michael Scherer
Adam Keech
Guillaume Grossetie
Michael Weber
Josh Gachnang
GUILLAUME GROSSETIE
Xav Paice
Tom Bamford
Ryan Sydnor
Hans-Joachim Kliemeck
Jiri tyr
Olaf Kilian
Romain Brucker
Alberto Gireud
Jonathan Davila
James Cammarata
Jonathan Mainguy
YAEGASHI Takeshi
Indrajit Raychaudhuri
Caduri
Joel Thompson
Etherdaemon
Kenny Gryp
Robin Roth
xiaclo
Kerim Satirli
Jimmy Tang
root
Greg DeKoenigsberg
pmakowski
Henrik Wallström
nitzmahone
Daniel Vigueras
Javier Palacios
Ramunas Dronga
Ramunas
Trond Hindenes
Siva Popuri
Matteo Acerbi
Corwin Brown
Alexander
Matt Carroll
Ondra Machacek
Jonathan Mainguy
Ramon de la Fuente
M0ses
daniel-sc
ogenstad
Shawn Siefkas
Christopher M. Fuhrman
Linus Unnebäck
Phil
Jeremy Wells
Steve
Nicolas Landais
Dreamcat4