Commit Graph

1485 Commits (1b71fb0499cc4591bfc32f7b05096002c49ac28f)

Author SHA1 Message Date
rahushen 169fbc4c94 Fixes #28493 (#29061) 2017-09-13 08:00:13 -07:00
rahushen 5537218c94 fixes #27066 - nxos_acl errors when there are 0 or 1 access lists configured (#29076)
* fixes #27066

* replace type() with isinstance()
2017-09-13 18:07:06 +05:30
rahushen f1cc5a928c Fixes #27336 - nxos_gir_profile_management issue while creating profile (#29151)
* Fixes #27336

* Correct documentation errors
2017-09-13 17:54:35 +05:30
Mike Wiebe 7292dd20ed Fix nxos_overlay_global networking modules (#28943) 2017-09-13 17:33:06 +05:30
rahushen bc6e015a86 Fixes #27138 (#29064) 2017-09-13 17:11:00 +05:30
Trishna Guha 578ae3b238 fix nxos_file_copy and provider getting set to None when transport is cli (#30262)
* nxos_file_copy bug fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* provider gets set to None in module level when transport is cli

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-13 16:36:41 +05:30
Ganesh Nalawade d8371cec91 Fix ios_system lookup enable issue (#30263)
Fixes #29974

Add `None` check while comparing module parameter values (want) with the actual
configuration present on device (have).
2017-09-13 15:19:09 +05:30
Matt Clay 442af3744e Miscellaneous pylint fixes.
The following rules are no longer disabled:

- bad-format-string
- duplicate-key
- lost-exception
- trailing-newlines
- unexpected-keyword-arg
- useless-suppression
- using-constant-test
2017-09-13 01:53:08 -07:00
Mike Wiebe cef7ed0310 Fix nxos_mtu nxapi failure (#30153) 2017-09-13 10:51:46 +05:30
Jacob McGill 2489eeece0 ACI EPG TO DOMAIN: Add vm_provider docstring and add support for micr… (#29114)
* ACI EPG TO DOMAIN: Add vm_provider docstring and add support for microsoft and openstack

* Fix typo

* Fix whitespace
2017-09-12 22:53:17 +01:00
Mike Wiebe f973f93963 Fix nxos_smu error (#30157) 2017-09-12 22:17:07 +01:00
Trishna Guha 5b1c91bf19 nxos_system parse name_servers fix (#29944)
* nxos_system parse name_servers fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix nxos_system tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-12 13:25:01 +05:30
Matt Clay 68aeaa58a8 Fix dangerous default args. (#29839) 2017-09-12 00:11:13 -07:00
Ganesh Nalawade 5caa47feb9 Add port and host check for neighbor args in junos_interface (#29941) 2017-09-12 11:16:20 +05:30
Tim Rupp 74ace093b8 Renames the bigip_configsync_actions module (#29747)
Retains the old name by making a symlink. We can remove it in a later
release.
2017-09-12 05:53:44 +01:00
Tim Rupp a36ebd979d Adds missing docs and downstream fixes (#29664)
Partition docs are not a documentation fragment, so they need to
be added
2017-09-11 23:30:34 +01:00
Jonathan Karras e5d247fdc0 Fixes #20443 - Adjust version checking regex to account fo no comma in IOS-XE (#29157)
* Adjust version checking regex to account fo no comma in IOS-XE
* Adjusted regex to include last character of version number
2017-09-11 07:08:12 -07:00
Toshio Kuratomi 6797221107 Romain dartigues fixes (#29169)
* cloud: azure: fix typo introduced in commit 16d23e9

The commit "Add reference to VNET resource group (#26052)"
removed an used variable.

* network: aos: error hint never shown
2017-09-09 16:20:53 -07:00
Trishna Guha 588bddbc35 nxos_banner CI fix (#29134)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-08 19:33:41 +05:30
Ganesh Nalawade 772dab55c6 Add check for port and host in ios_interface (#29119)
Fixes #29118
2017-09-08 09:10:38 +05:30
Ganesh Nalawade 0b2619ff2b Add lldp neighbor intent argument for vyos_interface (#29092)
* Add lldp neighbor intent argument for vyos_interface

* Add version_added info for neighbor argument

* Fix CI issue
2017-09-08 08:28:43 +05:30
Ricardo Carrillo Cruz f9f0472ba5 Ignore routes that are not static manually added (#29094)
Fixes #28841
2017-09-07 17:56:09 +02:00
Ganesh Nalawade 49658f9437 Add lldp nighbors intent arg support for junos_interface (#29057)
* Add lldp neighbor state arg for junos_interfaces

* minor change
2017-09-07 12:01:40 +05:30
Nathaniel Case f84ff216b6 Generalize nxos_bgp event-history detection (#28890)
* More general handling of event-history

* Update unit tests
2017-09-06 17:37:44 -04:00
Ganesh Nalawade 3b6b004570 Add support for neighbor argument in ios_interface (#29035)
Add missing support for lldp neighbor argument in ios_interface
2017-09-06 10:15:02 +05:30
marinus81 d69c803353 Fixed typo in resolution_immediacy values dict 2017-09-05 09:10:45 -07:00
Dag Wieers a200ecf966 aci_rest: Accept YAML input and validate content input
This PR includes:
- Accept inline YAML, YAML string, inline JSON, JSON string input and
  XML string input
- Validate YAML, JSON and XML input
2017-09-05 00:59:15 -07:00
Dag Wieers a796391c9b aci_rest: Implement idempotency
This PR includes:
- A new function to modify query strings in URLs
- Add rsp-subtree=modified to post/delete requests
- Test the ACI response for changes and report back
- Return the used URL back to the user
- Remove check-mode support (as it was non-functional anyway)
- Fix a bug related to method=delete and not having content set

This fixes datacenter/aci-ansible#111
2017-09-05 00:17:35 -07:00
Ganesh Nalawade cc9ed352dd Ensure proper conversion while backing up of junos config (#28958)
* Ensure proper conversion while backing up of junos config

* Minor changes

* Fix review comment

*  Open config backup file in binary mode
2017-09-04 20:12:11 +05:30
Jacob McGill 6e79dfb5f3 ACI_BD_*: Fix missing default for state parameter 2017-09-01 21:59:34 +02:00
Nathaniel Case 8bfdbd0f73 nxos_bgp_neighbor: Fix regex &report warnings (#28888)
* Fix over-detection of log-neighbor-as

* Report nxos warnings

* Update nxos_bgp_neighbor unit tests to test remove-private-as
2017-09-01 15:17:42 -04:00
Mike Wiebe fb1aa54341 Rel240/fix nxos interface ospf (#28898)
* Fixes 28897 nxos_interface_ospf idempotence

* Handle all characters upper or lower with tests
2017-09-01 11:07:18 -04:00
Nathaniel Case ae6d27fa29 Revert "Bring nxos_snmp_host in line"
This reverts commit 43247c8dfe.

Revert "Bring nxos_snmp_community in line"

This reverts commit 0df77408d7.

Revert "Clean up nxos_snmp_contact & nxos_snmp_location"

This reverts commit 9e4cdd2fce.

I should probably not be up this early
2017-09-01 08:00:00 -04:00
Nathaniel Case 43247c8dfe Bring nxos_snmp_host in line 2017-09-01 07:43:05 -04:00
Nathaniel Case 0df77408d7 Bring nxos_snmp_community in line 2017-09-01 07:15:24 -04:00
Nathaniel Case 9e4cdd2fce Clean up nxos_snmp_contact & nxos_snmp_location 2017-09-01 07:12:49 -04:00
Trishna Guha 252efcebf5 module should fail if eos_user is added without configured_password or nopassword or sshkey (#28780)
* module should fail if eos_user is added without configured_password or nopassword or sshkey

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix eos_user unit test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix eos_user integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-31 15:29:57 -04:00
rahushen 07c1d7e1ca update nxos_facts to handle n3k power table (#28891)
* handle power table for n3k
2017-08-31 14:59:14 -04:00
Nathaniel Case 74daf2381b Fix nxos_config `save` parameter (#28838)
Also fix saving in general
2017-08-31 10:01:19 -04:00
Ganesh Nalawade a6af204cee Fix junos_user purge option failures (#28867)
* Fix junos_user pruge option failures

Fixes #25989

Add seperate handling for purge option which
fetches configured users on remote device
and delete the one not present in aggregate
list.

* Minor changes
2017-08-31 17:46:13 +05:30
Jacob McGill 8ffb842963 ACI Config Rollback: Add new module to support config rollbacks in ACI (#28811)
* ACI Config Rollback: Add new module to support config rollbacks in ACI

* Fix EXAMPLES

* Fix whitespace
2017-08-30 07:26:17 +02:00
Jacob McGill 42db02c249 aci_config_snapshot: Module to manage ACI config snapshots (#28784)
* ACI Config Snapshot: Add module to support managing config snapshots on the APIC.

* add comma back

* Fix docstring errors

* Fix typo

* add quotes for notes section
2017-08-30 06:31:14 +02:00
Mike Wiebe d9fc3def94 Fixes #28779 eth_mode key error (#28782)
* Fixes #28779 eth_mode key error

* Remove unused get_config references

* Addressed PR comment
2017-08-29 17:07:46 -04:00
Nathaniel Case 64dac346c9 Fix nxos_pim_interface dr-priority handling (#28472)
* Fix nxos_pim_interface dr-priority handling

* Prefer execute_show over `| json`

* Mock get_config

* Fix sparse-mode detection
2017-08-29 14:42:09 -04:00
Jacob McGill e3b66a8016 ACI Rest: Fix issue with XML response (#28785) 2017-08-29 20:41:17 +02:00
Jacob McGill 6aaa0c3252 Net Ping: Add new action plugin for *_ping network modules (#28558) 2017-08-29 13:28:58 -04:00
René Moser c97f4653be fix typos in various modules and docsite (#28747) 2017-08-29 17:59:41 +02:00
rahushen 2cf836772d Add passive_interface property to nxos_ospf_vrf module (#28288)
* add passive_interface property to nxos_ospf_vrf module

* Add version_added for
2017-08-29 11:31:11 -04:00
Jacob McGill 1c4fe510d0 IOS Ping: Add new module to support ping tests from IOS devices (#28557)
* IOS Ping: Add new module to support ping tests from IOS devices

* Add tests

* Add fixtures for ios_ping
2017-08-29 11:21:49 -04:00
Nathaniel Case 40907d7db2 Fix detection of associate-vrf parameter (#28725) 2017-08-29 09:47:27 -04:00
Nathaniel Case 862cde5e82 [WIP] Fix nxos_banner (#28607)
* Fix `'state': 'absent'`

* Replace idempotence tests with references

* Fix issues with nxos_banner
2017-08-28 17:09:54 -04:00
Trishna Guha 0a8ec4ddef fix nxos_igmp_interface output (#28735)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-28 17:06:30 -04:00
Brayneded 335e804c0c Add junos_vrf vrf-table-label support (#28727)
* Added VRF Table Label Support

* Added table_label docs and set as default=true
2017-08-29 00:44:51 +05:30
Mike Wiebe 3d46258cff Refactor/fix nxos_nxapi to use show run (#28675)
* Refactor/fix nxos_nxapi to use show run

* Fix unit tests

* Python 3 compatibility
2017-08-28 15:00:56 -04:00
George Nikolopoulos 869eee0762 Deprecate citrix/netscaler module (#28280)
* Deprecate citrix/netscaler module

* 	renamed:    netscaler.py -> _netscaler.py

* Fix legacy files list
2017-08-25 13:51:15 -04:00
George Nikolopoulos 8d14f9d578 Lowercase enabled, disabled option values (#27764) 2017-08-25 13:11:48 -04:00
George Nikolopoulos c01dd6470c Add disable operation for netscaler_servicegroup (#28327) 2017-08-25 17:03:21 +01:00
George Nikolopoulos 2281a6676b Add enable, disable operation in netscaler_service (#28321) 2017-08-25 16:58:51 +01:00
Nathaniel Case fbeb3b9ac5 Nxos ping (#28665)
* Update documentation & results, clean up code

* Change numeric results to int/float
2017-08-25 11:45:46 -04:00
Ivan Bojer 9b8abc8a7f panos_sag: static address group (#28041)
* - Create a static address group object in the firewall used for policy rules.

* PEP8 changes

* add function to check for devicegrp name

* fix exception handling

* PEP8 fixes

* update metadata_version
2017-08-25 16:35:35 +01:00
Evgeny Fedoruk 71313ce04d Module for uploading templates into vDirect server (#27570)
* Module for uploading templates into vDirect server

Module for uploading configuration and workflow templates
into Radware vDirect server

* Module for uploading templates into vDirect server

Module for uploading configuration and workflow templates
into Radware vDirect server
2017-08-25 16:23:36 +01:00
Peter Sprygada 75293d83ca configures address-families when vrf is created (#28615)
* configures address-families when vrf is created

fixes #26725

* fix up unit test cases
2017-08-25 07:51:20 -04:00
Jacob McGill a03a1cde88 ACI Tenant SPAN Src Grp to Dst Grp: Add new module to support managin… (#28645)
* ACI Tenant SPAN Src Grp to Dst Grp: Add new module to support managing Tenant SPAN Source Group and Dest Group Bindings

* Fix docstring errors

* Fix Metadata version

* Fix Shippable issues
2017-08-25 11:33:41 +02:00
Jacob McGill 6401478883 ACI Tenant SPAN Src Grp: Add new module to support managing Tenant SP… (#28644)
* ACI Tenant SPAN Src Grp: Add new module to support managing Tenant SPAN Source Groups

* Fix docstring errors

* Fix Metadata version

* Fix Shippable issue
2017-08-25 11:32:41 +02:00
Jacob McGill 05a17164e3 ACI EPG: Update module to use new URL Method (#28647) 2017-08-25 08:37:56 +02:00
Jacob McGill eaea574e3b ACI Tenant EP Retention Policy: Add new module to support managing En… (#28642)
* ACI Tenant EP Retention Policy: Add new module to support managing End Point Retention Policies

* Fix docstring errors

* Fix Metadata version
2017-08-25 08:37:28 +02:00
Jacob McGill bac617acef ACI Taboo Contract: Update module to use new URL Method (#28639) 2017-08-25 08:37:12 +02:00
Jacob McGill 8b641688e9 ACI Tenant Action Rule Profile: Update module to use new URL Method (#28641) 2017-08-25 08:36:51 +02:00
Jacob McGill a12ff4468d ACI SPAN Dest Group: Update module to use new URL Method (#28643) 2017-08-25 08:36:34 +02:00
Jacob McGill 8a966a48c8 ACI VRF: Update module to use new URL Method (#28646) 2017-08-25 08:35:45 +02:00
Jacob McGill f7a466cbb4 ACI Intf Policy Port Security: Update module to use new URL Method (#28638) 2017-08-25 08:35:26 +02:00
Jacob McGill f9036133bb ACI Tenant: Update module to use new URL Method (#28640) 2017-08-25 08:35:00 +02:00
Jacob McGill 9c564de765 ACI L3Out Route Tag: Update module to use new URL Method (#28637) 2017-08-25 08:34:35 +02:00
Jacob McGill a6614a132d ACI Intf Policy Port Channel: Update module to use new URL Method; add support for ctrl (#28636) 2017-08-25 08:33:57 +02:00
Jacob McGill 1bec0e5753 ACI BD: Update module to use new URL Method (#28625)
* ACI BD: Update module to use new URL Method

* fix docstring errors
2017-08-25 08:33:27 +02:00
Jacob McGill 2e61760659 ACI Contract Subject: Add new module to support managing Contract Sub… (#28620)
* ACI Contract Subject: Add new module to support managing Contract Subjects in ACI

* Fix Metadata

* Fix Metadata version
2017-08-25 08:33:00 +02:00
Jacob McGill e434c291ca ACI Intf Policy MCP: Update module to use new URL Method (#28635) 2017-08-25 04:21:08 +02:00
Jacob McGill fa6da960db ACI Intf Policy LLDP: Update module to use new URL Method (#28634) 2017-08-25 03:57:03 +02:00
Jacob McGill 6109a6c093 ACI Filter: Update module to use new URL Method (#28630) 2017-08-25 03:56:18 +02:00
Jacob McGill f5f2a2fac2 ACI Intf Policy L2: Update module to use new URL Method (#28633) 2017-08-25 03:55:45 +02:00
Jacob McGill 25d1ef3493 ACI Intf Policy FC: Update module to use new URL Method (#28632) 2017-08-25 03:55:27 +02:00
Jacob McGill 85ca2234fd ACI Filter Entry: Update module to use new URL Method (#28631) 2017-08-25 03:51:21 +02:00
Jacob McGill 0577bf688c ACI EPG to Contract: Update module to use new URL Method (#28628) 2017-08-25 03:45:32 +02:00
Jacob McGill a4087841a8 ACI EPG to Domain: Update module to use new URL Method (#28629) 2017-08-25 03:45:12 +02:00
Jacob McGill d186c9eda2 ACI EPG Mon Policy: Update module to use new URL Method (#28627) 2017-08-25 03:43:10 +02:00
Jacob McGill 9582e7e549 Ap (#28626)
* ACI Ap: Update module to use new URL Method

* ACI Ap: Update module to use new URL Method
2017-08-25 03:21:10 +02:00
Jacob McGill 0b1ea2be9b ACI BD Subnet: Update module to use new URL Method (#28624) 2017-08-25 03:17:01 +02:00
Jacob McGill dc232737ba ACI BD to L3Out: Update module to use new URL Method (#28623) 2017-08-25 03:16:17 +02:00
Jacob McGill 28f76166d0 ACI Contract: Update module to use new URL Method (#28622) 2017-08-25 03:15:23 +02:00
Jacob McGill 037ef743c3 ACI Contract Subject to Filter: Update module to use new URL Method (#28621) 2017-08-25 03:14:36 +02:00
Jacob McGill 061fe51e9a ACI AEP: Update module to use new URL Method (#28619)
* ACI AEP: Update module to use new URL Method

* ACI AEP: Update module to use new URL Method

* ACI AEP: Update module to use new URL Method
2017-08-25 02:46:09 +02:00
Peter Sprygada b34cfd03b3 implements missing code to handle before and after arguments (#28612)
fixes #21683
2017-08-24 16:00:54 -04:00
Nathaniel Case 07cd4fda0e Remove module_utils.shell (#28560)
* Get rid of module_utils.shell

* There is no way this actually raises ShellError
2017-08-24 14:55:03 -04:00
CsilLAB 8d3546af60 Update eos_config documentation. (#28512)
Added note to documentation about Jinja2 file used as src.
2017-08-24 21:40:36 +05:30
Ganesh Nalawade 55fa4d54aa Add tested against junos version for junos modules (#28598)
* Add tested against junos version for junos modules
2017-08-24 10:31:47 -04:00
Trishna Guha 10467efaba Tested against VYOS version (#28562)
* Tested againset VYOS version

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix duplicate dict key error vyos_command

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-24 19:08:05 +05:30
Nathaniel Case ada7f248c0 Add 'Tested on' string to NX-OS modules (#28531) 2017-08-24 08:27:39 -04:00
Trishna Guha cfc6d9f904 Tested against IOS XR version (#28563)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-23 22:55:21 +05:30
Trishna Guha 4070a22c5b Tested against IOS version (#28559)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-23 21:03:09 +05:30
Trishna Guha 340f52ae96 tested against eos version (#28556)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-23 20:39:31 +05:30