Felix Fontein
ed22efb2a6
Clarify that uninstalling docker-py can break docker (and vice versa). ( #43238 )
2018-08-28 17:53:43 +01:00
Martin Szulecki
2653bd3f50
Fix docker_image archive features to work with Python 3
...
Without binary mode, ansible shows a "write() argument must be str,
not bytes" error when using Python 3.
2018-07-19 12:30:07 -04:00
Felix Fontein
765a5130d5
Docker modules: improve documentation on docker vs. docker-py Python package requirements ( #42457 )
...
* Make sure all docker-py/docker requirements are listed, and clarify about docker vs. docker-py.
* Adjusting changes made in #40839 .
2018-07-11 17:57:39 -04:00
Alberto Murillo
0f3480d359
docker_image: Fix idempotency of pull ( #31956 )
...
when pulling an image with force=yes the task was marked as changed
everytime even when the image hasn't changed.
This was due to a bad comparison of the image tag before the pull
and after the pull.
Fixes #22596
Signed-off-by: Alberto Murillo <albertomurillosilva@gmail.com>
2018-04-25 12:58:29 -04:00
jctanner
2f32e0ba2d
Remove me from botmeta ( #39263 )
...
* Remove myself from team_vmware
* Remove myself from maintainership of all modules
2018-04-24 19:55:04 -04:00
Thierry BOUVET
4117b2dd29
Fix documentation fragments for docker ( #38378 )
2018-04-17 08:51:56 -07:00
skylerbunny
d984afa5ba
Add compatibility for docker-py version 3 ( #36973 )
2018-03-06 07:14:31 -05:00
John Barker
c57a7f05e1
Bulk autopep8 (modules)
...
As agreed in 2017-12-07 Core meeting bulk fix pep8 issues
Generated using:
autopep8 1.3.3 (pycodestyle: 2.3.1)
autopep8 -r --max-line-length 160 --in-place --ignore E305,E402,E722,E741 lib/ansible/modules
Manually fix issues that autopep8 has introduced
2017-12-07 20:25:55 +00:00
Alvaro Aleman
f8e79eb481
Fix changed event for docker_image in force mode
2017-08-17 10:42:09 -04:00
Toshio Kuratomi
f203ca7907
Update metadata to 1.1
2017-08-15 23:12:08 -07:00
Toshio Kuratomi
1ee08c0f06
Get rid of more wildcard imports and add boilerplate to more modules
...
This commit cleans up the following module categories:
* messaging
* inventory
* crypto
* commands
* clustering
* cloud/webfaction
* cloud/docker
* cloud/digital_ocean
2017-07-29 07:02:12 -07:00
Toshio Kuratomi
225fa5d092
Fix undefined variables, basestring usage, and some associated python3 issues
2017-07-25 15:58:23 -07:00
Matthew Schick
846174b4ba
Update nocache to be the proper bool type instead of string ( #24358 )
...
* Update nocache to be the proper bool type instead of string
* Add proper bool type for params
2017-06-19 11:24:19 +01:00
Andrea Tartaglia
1d0a629dcc
Fixed docs for cloud modules ( #23745 )
...
* Fixed docs for cloud modules
* removed blank line in ec2_snapshot_facts
2017-04-27 12:01:11 +01:00
Ilya Simonenko
dba8edf735
cloud: docker: Fixes #22638 load image to memory when archive_path provided ( #22642 )
2017-03-16 10:06:19 -07:00
Dylan Silva
9ffad27319
Changed supported_by from curated to community ( #22654 )
2017-03-15 14:28:33 -07:00
John R Barker
9857ce8ddb
Fix render issue ( #22650 )
2017-03-15 16:31:37 +00:00
Toshio Kuratomi
eb1214baad
New metadata 1.0 ( #22587 )
...
Changes to the metadata format were approved here:
https://github.com/ansible/proposals/issues/54
* Update documentation to the new metadata format
* Changes to metadata-tool to account for new metadata
* Add GPL license header
* Add upgrade subcommand to upgrade metadata version
* Change default metadata to the new format
* Fix exclusion of non-modules from the metadata report
* Fix ansible-doc for new module metadata
* Exclude metadata version from ansible-doc output
* Fix website docs generation for the new metadata
* Update metadata schema in valiate-modules test
* Update the metadata in all modules to the new version
2017-03-14 09:07:22 -07:00
John R Barker
e5b990a55a
Fix invalid fields in module DOCUMENATION ( #22297 )
...
* fix module doc fields
* More module docs corrections
* More module docs corrections
* More module docs corrections
* More module docs corrections
* correct aliases
* Review comments
* Must quote ':'
* More authors
* Use suboptions:
* restore type: bool
* type should be in the same place
* More tidyups
* authors
* Use suboptions
* revert
* remove duplicate author
* More issues post rebase
2017-03-09 16:20:25 +00:00
Tomas Tomecek
30026cfb84
[cloud] module docker_image: print output on failure ( #20757 )
...
Fixes https://github.com/ansible/ansible-modules-core/issues/5161
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
2017-02-16 09:47:18 -05:00
Matt Martz
7c00346714
Validate EXAMPLES as YAML
2017-02-15 13:01:43 -08:00
Matt Clay
cb76200c7d
PEP 8 E111 & E114 cleanup. ( #20838 )
2017-01-30 15:01:47 -08:00
Matt Clay
95789f3949
PEP 8 whitespace cleanup. ( #20783 )
...
* PEP 8 E271 whitespace cleanup.
* PEP 8 W293 whitespace cleanup.
* Fix whitespace issue from recent PR.
2017-01-27 15:45:23 -08:00
dariko
e2a1ce2916
[docker] Add compatibility with docker-py v2.0
2017-01-18 14:39:18 -05:00
Jun Guo
31526595c5
docker_image: docs: won't be pushed to private registry without push parameter. ( #19691 )
2016-12-27 08:15:12 +01:00
Andrea Tartaglia
ef391a11ec
Removed dict.iteritems() in modules. ( #18859 )
...
This is for py3 compatibility, addressed in #18506
2016-12-12 15:16:23 -08:00
Toshio Kuratomi
7319104552
Refreshed metadata for core modules
2016-12-08 11:25:35 -05:00
Asara
dddf810a19
Fixed typo in docker_image.py docs ( #5764 )
2016-12-08 11:25:34 -05:00
Patrick F. Marques
dc4cff7350
Remove duplicated option from examples
2016-12-08 11:25:28 -05:00
Chris Houseknecht
0e4b470ee2
Let docker-py handle decoding and JSON parsing of stream data. Fixes #4930 .
2016-12-08 11:25:14 -05:00
Chris Houseknecht
2514ec5056
Add buildargs parameter to support Dockerfile ARG directive. ( #4349 )
...
* Add buildargs parameter to support Dockerfile ARG directive.
* Fix doc_strings. Doc string for load_path was completely missing.
2016-12-08 11:24:48 -05:00
chouseknecht
f6b126d412
Default repository tag value to tag parameter value or 'latest'.
2016-12-08 11:24:48 -05:00
chouseknecht
3dab1785ba
Always returns changed when state present and name includes :tag.
2016-12-08 11:24:48 -05:00
Chris Houseknecht
1cf9d3e68e
Add *build* to state parameter choices. Updated deprecation message. Will be deprecated in release 2.3. Removed ( #4342 )
...
mention of *tagged* state in the force parameter doc strings. There is no *tagged* state.
2016-12-08 11:24:48 -05:00
chouseknecht
2ea29fee3f
Fix image tag operation. Allows repository in form of repo:tag. If no tag value, defaults to 'latest'.
2016-12-08 11:24:48 -05:00
Chris Houseknecht
7ffa6a43c5
Add push parameter. Let API handle registry authentication check.
2016-12-08 11:24:43 -05:00
Rodríguez, Jorge
82c26ad2d7
Do not forcibly push when building, either.
2016-12-08 11:24:39 -05:00
Rodríguez, Jorge
89e8787d65
Don't forcibly push loaded images to registry. Fixes #3763
2016-12-08 11:24:39 -05:00
Stefan Hajnoczi
38013de366
Stream image data in load_image() to avoid out-of-memory
...
Reading the entire tar file into memory can result in out-of-memory
conditions such as this traceback:
Traceback (most recent call last):
File "/tmp/ansible_YELTSu/ansible_module_docker_image.py", line 486, in load_image
self.client.load_image(image_data)
File "/usr/local/lib/python2.7/dist-packages/docker/api/image.py", line 147, in load_image
res = self._post(self._url("/images/load"), data=data)
...
File "/usr/lib/python2.7/httplib.py", line 997, in endheaders
self._send_output(message_body)
File "/usr/lib/python2.7/httplib.py", line 848, in _send_output
msg += message_body
MemoryError
Luckily docker-py's load_image(), which calls requests post(), accepts a
file-like object instead of a string. Pass in the file object to avoid
reading the full file into memory. This allows larger tar files to load
succesfully.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
2016-12-08 11:24:36 -05:00
chouseknecht
d5b82d67b8
Fail gracefully when build path is not found.
2016-12-08 11:24:27 -05:00
chouseknecht
1d6517489b
Add doc string for container_limits. Fixed push fail message. Use path type.
2016-12-08 11:24:25 -05:00
chouseknecht
a67e9f3122
Updated version_added on options to reflect options added for 2.1.
2016-12-08 11:24:24 -05:00
chouseknecht
f2e7f1935b
Clean up and fixes post API version 1.20 testing.
2016-12-08 11:24:24 -05:00
chouseknecht
6f122bdc88
Fix github credentials
2016-12-08 11:24:24 -05:00
chouseknecht
f257fb3efa
Fix unfriendly exeption handling.
2016-12-08 11:24:23 -05:00
chouseknecht
6aa76b835a
Updater per PR comments
2016-12-08 11:24:23 -05:00
chouseknecht
fd0554c67e
Adding refactored docker_image module.
2016-12-08 11:24:23 -05:00
Andrey Gubarev
edde3b49cf
update docker_image's path param type to 'path'. Fixes #3175
2016-12-08 11:24:10 -05:00
Toshio Kuratomi
2619ec5321
Fix issues version_added and chaged => changed typo
2016-12-08 11:23:45 -05:00
Michael Schuett
e61a4f2fb5
Fix message
...
Previous fix did not actual work. This fix does however.
2016-12-08 11:23:45 -05:00