Commit Graph

13170 Commits (23c94295dc2b7928999319c28305f503f6b14c69)

Author SHA1 Message Date
Felix Fontein a727a1ee67 [aws] route53 module: fix idempotency for CAA records (#46049)
* Fixing record order for CAA records to properly handle idempotency.

* Add integration tests that reproduce CAA failure
2018-09-27 15:08:47 -04:00
Susant Sahani aedcf9fed7 nmcli: set hairpin to str to bool (#45908)
Fix: nmcli module always sets hairpin mode to 1 for bridge slaves.

Closes #42569

Signed-off-by: Susant Sahani<susant@redhat.com>
2018-09-27 22:46:19 +05:30
Dag Wieers 04de52da2c Clean up common module docs (#45888)
Some of the older modules have evolved documentation that does not
follow a consistent style. This is a clean-up in form and style.
2018-09-27 11:27:01 -04:00
Adam Miller 71280ee773 Handle dnf immutable mutable datatypes (#46176)
In DNF < 3.0 are lists, and modifying them works
In DNF >= 3.0 < 3.6 are lists, but modifying them doesn't work
In DNF >= 3.6 have been turned into tuples, to communicate that
modifying them doesn't work

Further explanation of this is available via Adam Williamson from
the Fedora QA Team.

    https://www.happyassassin.net/2018/06/27/adams-debugging-adventures-the-immutable-mutable-object/

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-09-27 03:45:58 -04:00
David Passante 382641ff24 cs_account: Implement role parameter support (#46166) 2018-09-27 07:37:56 +02:00
Kevin Subileau ac9d506a61 win_nssm: tests and several bug fixes (#44755)
* win_nssm: add failing tests for issue #44079

* win_nssm: use Run-Command instead of Invoke-Expression to prevent interpretation issue

Fix #44079

* win_nssm: add more failing tests

These tests highlight several issues with this module:
 * Service not started when state=started
 * Errors with app_parameters (see #25265)
 * Exception when passing several dependencies separated by comma as specified in doc

* win_nssm: fix service not started when state=started

Nssm status returns a multiline output that doesn't match any of the strict patterns in the switch statement.

* win_nssm: fix incorrect separator in doc for service dependencies

The dependencies parameter works with space as separator, but not with comma as shown in the documentation

* win_nssm: fix error with app_parameters parameter

Fix #25265

* win_nssm: add idempotence tests

* win_nssm: fix several idempotence issues and misbehaviors

Add missing space between arguments when app_parameters contains several keys.
Use Argv-ToString and Escape-Argument to improve arguments handling (parameters with quotes, backslashes or spaces).

* win_nssm: test parameters with spaces, quotes or backslashes

* win_nssm: restore comma as separator for service dependencies

Revert commit ddd4b4b

* win_nssm: restore support of string as dict form for app_parameters and remove support of literal YAML dict

* win_nssm: wrong variable in tests
2018-09-27 13:15:04 +10:00
Yunge Zhu 69594c5370 add azure_rm_cdnprofile and azure_rm_cdnprofile_facts (#45097)
* add cdn profile with facts

* fix merge issue

* fix version

* fix lint

* move cdn client out of azure_rm_common

* fix lint

* fix helper

* fix code bug

* fix bug

* fix import

* fix typo

* fix test
2018-09-27 10:10:01 +10:00
aaronk1 8498b58ad5 Update win_robocopy.py (#38633)
* Update win_robocopy.py

<!--- Show example of UNC path copy of a single file, noting trailing backslash required -->

+label: docsite_pr

* addresses jborean comment, removes double quotes

* Remove trailing slash part
2018-09-27 06:28:15 +10:00
Sandra McCann 08c392477e made sros_config docs match code for match options (#46135)
* made docs match code for match options

* fixed shippable error
2018-09-26 19:08:26 +05:30
tstoner b427499e3e Added feature facts to nxos_facts (#45934)
* Added feature facts to nxos_facts

* Fixed ansibot indentation

* Resolved ansibot whitespace missing after ','

* Per PR suggestion, created method in base class to gather switch config
and store in global variable to prevent multiple calls to switch.

* Addressed ansibot blank line & whitespace after ,
2018-09-26 15:57:09 +05:30
saichint 2b216384eb fix for banner idempotent issue (#46001)
* fix for banner issue

* review comments
2018-09-26 15:48:56 +05:30
René Moser f73996e6eb
cs_resourcelimit: use query_api for error handling (#46036) 2018-09-26 09:05:48 +02:00
René Moser 48b9992446
cs_ip_address: use query_api, fixes error handling (#46034) 2018-09-26 09:05:07 +02:00
René Moser 7f92a8c94c
cs_staticnat: fix sanity (#46037) 2018-09-26 09:03:16 +02:00
René Moser c09b785a66
cs_instance: doc: fix typo in examples (#46035) 2018-09-26 09:02:06 +02:00
Felix Fontein 95cfcac694 docker-py: bump minimal version to 1.8.0 (#46134)
* Bumping docker-py minimal version to 1.8.0.
* Improve docs formatting.
2018-09-26 11:58:32 +05:30
Abhijeet Kasurde c98cec17e0 VMware: trigger customization for customization_spec (#45415)
This fix allows to trigger VM customization if user specifies
customization spec.

Fixes: #44159

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-26 02:26:45 -04:00
Abhijeet Kasurde a6b095756c
VMware: Add support for service type (#40651)
* Add support for - Replication, Provisioning
* Update documentation
* Update example

Fixes: #40529

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-26 11:53:45 +05:30
Jordan Borean d0d4f2e406
win_setup: don't fail when running as non-admin and EAP is set to Stop (#46149) 2018-09-26 13:46:24 +10:00
Nathan Webster 3b786acb86 EC2_ASG: Enable support for launch_templates (#45647)
* Enable support for launch_templates in ec2_asg

* Fix asg create with LT and no version number

* Update mutually exclusive list

* Better function names
2018-09-25 16:39:34 -04:00
José Maia 923a7bd30f [azure] Fix name for the symbol * in docs (#46119)
Correct name is "asterisk", not "asterix", which is a popular franco-belgian comic character!

+label: docsite_pr
2018-09-25 15:21:24 -04:00
Zim Kalinowski 6056b89675
fix for managed disk facts (#46021) 2018-09-26 00:48:22 +08:00
abarbare 98b0594352 feat: add scaleway security group module (#45686)
fix: pep8 coding style

fix: error order requests
2018-09-25 16:39:49 +01:00
René Moser e7926cf9f4
cs_instance: fix host migration without volume (#46115) 2018-09-25 16:48:45 +02:00
Abhijeet Kasurde 4b4b21d745 [docs] Fix typos in aws_s3 and s3_bucket module docs (#46106)
Eucalypus to Eucalyptus

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-25 08:57:44 -04:00
newtonne aac1ce7333 homebrew_cask: Pass install_options during uninstall (#44938)
Until https://github.com/Homebrew/homebrew-cask/issues/40866 is fixed,
install_options should be passed when uninstalling casks to ensure that
all artefacts are removed.
2018-09-25 12:21:52 +01:00
Dan f20938788a fixed nxos_aaa_server_host issue with type 7 encrypt key (#46015)
* fixed nxos_aaa_server_host issue with type 7 encrypt and added test cases

* added idempotence tests
2018-09-25 16:39:22 +05:30
Hirshr c11c3506cd spotinst_aws_elastigroup elastic_ips example (#41190)
* Update spotinst_aws_elastigroup.py
2018-09-25 11:41:07 +01:00
tomww c44de1069c Update synchronize.py, mention variable ansible_rsync_path needed for different local rsync binary (#41870)
* Update synchronize.py

If you want a different rsync binary on the local side, you need to set task variable ansible_rsync_path.
See examples.

Variable ansible_rsync_path looks to not be documented anywhere. If documented, needs to be said that is does not belong to synchronise options, instead belongs to tasks. (Sorry, I have no better wording)
2018-09-25 11:27:24 +01:00
Anoop Sood d1688adefc Update sl_vm.py (#43966)
* Update sl_vm.py

Updated the list of datacenters to include new datacenters.
2018-09-25 11:15:51 +01:00
akira6592 8213096b7f The sshkey option is available in version 2.7 and above (#46103) 2018-09-25 10:41:23 +01:00
Gustavo Muniz do Carmo 7a747341fb Fix iterator to list conversion in ldap_entry module
PR #45778 fixes #45417
2018-09-25 11:24:44 +02:00
Joachim Mathes 30314c15c7 Generalize config retrieval in ios_l3_interface module (#45270)
This makes it work with Cisco 3750E.
2018-09-25 12:28:32 +05:30
Dan a6c20488d3 Add ospf net type (#45904)
* Added ospf network type option to nxos_interface_ospf module

* Added documentation and example for the 'network' parameter

* adding version
2018-09-25 11:38:39 +05:30
Tobias Wolf d5f8738bf2 [rabbitmq_binding] Fix the quoting of vhost and other names (#45109)
* [rabbitmq_binding] Fix the quoting of vhost and other names, which was broken in PR #35651
* Merge missing urllib_parse.quote from PR #42422
* Missed one line, where  also needs to be escaped, i.e., the destination
2018-09-25 11:04:41 +05:30
tstoner e74e8b8e75 Additional feature enhancements to nxos_logging (#45844)
* Various changes to nxos_logging.  Plus added purge capibility.

* Made a few new nxapi_logging test cases conditional based on version
and/or platform.

* Addressed PR comments and ansibot shippable.  Fixed up nxos_logging documentation format.

* Addressed ansibot shippable issues with whitespaces and documentation.

* Resolved ansibot codestyle trailing whitespace
2018-09-25 11:02:09 +05:30
Horie Issei d8d4be40b0 Update typetalk.py to use com domain (#46045)
Typetalk now uses "com" domain.
FYI: https://www.typetalk.com/blog/typetalk-gets-new-top-level-domain-typetalk-com/

+label: docsite_pr
2018-09-24 16:42:06 -05:00
Sandra McCann c5a8a911b3 fix doc links (#46094) 2018-09-24 16:08:05 -05:00
Dominik Holler 67e87d3d1c ovirt_host_network: Add save parameter to example (#45965)
The parameter 'save' is added to an example and the default
behavior is mentioned in the description of the other
examples.
2018-09-24 16:44:07 -04:00
Susant Sahani 8ef18839a6 Add `systemctl daemon-reexec` to `systemd` module
```
- name: systemctl daemon-reexec
  - systemd:
       daemon_reexec=yes
```

Closes: #38880

Signed-off-by: Susant Sahani <susant@redhat.com>
2018-09-24 15:51:44 -04:00
Rémy Léone 53886ecc9b Add an Online servers fact 2018-09-24 21:03:50 +02:00
Vinay Dandekar fe6b7f6b5d [aws] Change IAM role name parsing to come from the ARN (#45534) 2018-09-24 12:41:23 -04:00
Sloane Hertel 485320aab8 [sns_topic] Don't mask non-authorization errors (#46030) 2018-09-24 11:58:46 -04:00
Dag Wieers db5b65f5d6 win_get_url: Clarify the encoded slash issue (#45376)
* win_get_url; Clarify the encoded slash issue
2018-09-24 10:18:06 -05:00
Dag Wieers f90fc8a9a2 Fix author in modules (#46068)
Fix a few cases where the author was incomplete or incorrect.
2018-09-24 10:14:29 -05:00
santascsi 6ddfd912dc Update cron.py (#46055)
<!--- Your description here -->
The documentation states the use of the "value" attribute for environment variables while this should also be the "job" attribute.
+label: docsite_pr
2018-09-24 10:06:33 -05:00
José Maia 9039002886 Fix typo in Azure ARM module documentation (#46065) 2018-09-24 09:57:23 -05:00
jgkirschbaum 0fd1a71027 New module: Manage RabbitMQ global parameters [messaging/rabbitmq_global_parameter] (#26080)
* Created rabbitmq_global_parameter.py for managing RabbitMQ global parameters

* Contributed rabbitmq_global_parameter.py for managing RabbitMQ global parameters

* Contributed rabbitmq_global_parameter.py for managing RabbitMQ global parameters

* Contributed rabbitmq_global_parameter.py for managing RabbitMQ global parameters

* Contributing rabbitmq_global_parameter.py for managing RabbitMQ global parameters

* Update rabbitmq_global_parameter.py

* Update rabbitmq_global_parameter.py

* Updated Copyright Statement

* __future__ and __metaclass__ added

* Typo corrected

* Example changed

* Import Statement changed

* Returning of values changed

* Fixed Typo

* type for parameters added

* JSON fix

* Reverted

* missing conditional when calling main added

* version_added and PEP issues corrected

* Trigger build

* version_added bumped

version_added bumped to 2.6

* Bumped version_added

* version_added bumped to 2.8

* pep8 issue corrected
2018-09-24 10:24:58 -04:00
Rémy Léone 6d7004f367 Add a Scaleway IP module (#45121)
- Add an option to enable public ip at server creation
2018-09-24 10:14:23 -04:00
Felix Fontein 7caf70db42 docker_container: fix various idempotency problems and non-working options (#45905)
* Sorting args.

* Doing comparisons of options with container parameters in a more context-sensitive way.

This prevents unnecessary restarts, or missing restarts (f.ex. if parameters are removed from ``cmd``).

* Make blkio_weight work.

* Fix cap_drop idempotency problem.

* Making groups idempotent if it contains integers.

* Make cpuset_mems work.

* Make dns_opts work.

* Fixing log_opts: docker expects string values, returns error for integer.

* Adding tests from felixfontein/ansible-docker_container-test#2.

* Make uts work.

* Adding changelog entry.

* Forgot option security_opts.

* Fixing typo.

* Explain strict set(dict) comparison a bit more.

* Improving idempotency tests.

* Making dns_servers a list, since the ordering is relevant.

* Making dns_search_domains a list, since the ordering is relevant.

* Improving dns_search_domains/dns_servers.

* Fixing entrypoint test.

* Making sure options are only supported for correct docker-py versions.
2018-09-24 10:40:05 +01:00