Commit Graph

187 Commits (2579934ae0d11e8c6a72d314ed30d9f1efce2d32)

Author SHA1 Message Date
Toshio Kuratomi f159597914 Make documentation of win_unzip work on python3 as well 2016-12-08 11:34:20 -05:00
jjshoe 2ba75b7082 A couple of touch ups (#2288)
I peeked at #2281 a little late, thought this might help some as well.
2016-12-08 11:34:19 -05:00
René Moser 99646d5dbb fix build and doc cleanups (#2286) 2016-12-08 11:34:17 -05:00
jhawkesworth ac44058457 Add info about where you can find product ids for changed checking on win_package module (#2281) 2016-12-08 11:34:17 -05:00
Nicolas Landais e93f7241be Fix problem with 'restarted' state not restarting the apppool when it is in running state (#1451)
* Fix problem with 'restarted' state not restarting the apppool when it is in running state

* Implemeting code review comments

Comment from previous commit “You basically want to start the pool if
it's stopped and requested state is started or restarted, otherwise if
requested state is restarted, restart it.” This commit implements the
behavior stated in the PR comment
2016-12-08 11:34:16 -05:00
Corwin Brown d0ada049f2 Add Win Robocopy module (#1078)
* Added more robust error handling

* Add Win Synchronize module

Renamed win_synchronize to win_robocopy

Updating email address

Adding "flags" argument.

Adding a "flags" argument that will allow the user to pass args
directly to robocopy.

If "flags" is set, recurse and purge will be ignored.

Add return code to output

Added bits to support check mode

Fixing typo in Documentation

Updated Documentation to have "RETURNED" field

Updated win_robocopy.py to have the RETURNED field. I also noticed
that win_robocopy.ps1 wasn't really using the "changed" attribute,
so I went in and made sure it was being set appropriately.

Forcing bool type for recurse and purge flag

Updated "version_added"
2016-12-08 11:34:16 -05:00
jhawkesworth@users.noreply.github.com e878cf43f6 Fix for https://github.com/ansible/ansible-modules-extras/issues/2090 2016-12-08 11:34:10 -05:00
Hans-Joachim Kliemeck b36fc23a50 suggestion by @nitzmahone to not use Get-Attr in combination with ConvertTo-Bool, improved documentation regarding organize 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck ba0c75f5a7 fixed version added and tests 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck 867b7a9649 fixed bugs with flipped protection attribute 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck 632df80276 introduced state to differentiate between enabled/disabled inheritance. renamed copy to reorganize, since the meaning for inheritance=enabled is different 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck bdf0a888bb suggestions by @marcind 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck a240b14e09 added module to disable acl inheritance 2016-12-08 11:34:09 -05:00
jhawkesworth@users.noreply.github.com b94a614b7e fix problem where you couldn't compare empty strings in win_regedit following my previous change 2016-12-08 11:34:08 -05:00
Dreamcat4 314843b431 win-firewall-rule: temp disable strict-mode for the time being 2016-12-08 11:34:08 -05:00
Dreamcat4 820d5a7a3e fix: win-environment strict-mode fixes 2016-12-08 11:34:08 -05:00
Dreamcat4 572b6669c4 fix: win-scheduled-task strict-mode fixes 2016-12-08 11:34:08 -05:00
jhawkesworth@users.noreply.github.com b08b1cf2f3 Documentation improvements 2016-12-08 11:34:07 -05:00
jhawkesworth@users.noreply.github.com aaa9541abd Further fixes to support binary data. Added boolean return values and return documentation. 2016-12-08 11:34:07 -05:00
jhawkesworth@users.noreply.github.com c2ca0a9e93 adding the ability to manage binary registry data 2016-12-08 11:34:07 -05:00
Andrea Scarpino b4064a352e The enable parameter is a boolean, then convert to a boolean. (#1607)
At the moment, this only works when 'enable' is equals to 'yes' or 'no'.

While I'm on it, I also fixed a typo in the example and added a required
parameter.
2016-12-08 11:34:05 -05:00
nitzmahone bd3172b2e8 win_updates fix to use documented InstanceGuid property name 2016-12-08 11:34:03 -05:00
nitzmahone e20eac089f win_updates shouldn't install hidden updates 2016-12-08 11:34:03 -05:00
Hans-Joachim Kliemeck e3d8facc7f fixxed tests 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck c82d72e12a fixed problems related to userpricincipalname (user@domain) and undefined variables fixed variable capitalization 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck 186197397c fixxed problem with match @ 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck 9ba30d2cea only call set-acl if necessary 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck 700ca56c61 as suggested by @marcind, convert to boolean 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck 404483ea83 fixed documentation 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck de4a271dd0 added userprincipal support 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck 65d5658553 added separate module to change owner, since win_acl is ACL only and should not be more complex 2016-12-08 11:34:02 -05:00
Tyler Cross c84bd72496 Add note server 2012 note to win_scheduled_task.
This change adds a note to the win_scheduled_task module
docs that indicates Windows Server 2012 or later is required.
This is because the module relies on the Get-ScheduledTask
cmdlet, which is a part of the Server 2012 OS. Previous
versions, like Server 2008, simply can't work with this
module.
2016-12-08 11:34:00 -05:00
Andrea Scarpino 45a32137ad win_unzip: Use absolute path for src and dest
win_unzip fails to extract files when either src or dest contains
complex paths such as "..\..\" or "C:\\Program Files" (double slashes).
Fix this by fetching absolute path of both before invoking CopyHere
method.
2016-12-08 11:33:58 -05:00
jhawkesworth@users.noreply.github.com d2fe2287f9 Added return documentation to win_regmerge module 2016-12-08 11:33:58 -05:00
Andrea Scarpino f56c557a93 Fix issue #1406 about win_firewall_rule
I changed the logic here to always use 'netsh ... show rule' keywords as keys for $fwsettings map. While the translation (e.g. Enabled -> enable) is performed when invoking 'netsh ... add rule' command.

I tested rule creation and rule creation when the rule was already existing on Windows Server 2012.
2016-12-08 11:33:58 -05:00
Andrea Scarpino e16bd19401 win_unzip: overwrite any existing file 2016-12-08 11:33:58 -05:00
nonshankus 30d76cd37c Fixing win_updates example for listing available updates. 2016-12-08 11:33:57 -05:00
liquidat 7abe6b0e8c correct win_firewall state parameter
- original parameter comment was probably copy&paste error
- new comment highlights that firewall rules can be
  added or removed altering this parameter
2016-12-08 11:33:55 -05:00
Toshio Kuratomi 32ff89b30e Fix module docs 2016-12-08 11:33:55 -05:00
nitzmahone 2afecc7198 fix version_added issues in win_iis_website 2016-12-08 11:33:54 -05:00
nitzmahone 2e4cb9c651 added doc note to win_iis_website site_id arg 2016-12-08 11:33:54 -05:00
Corwin Brown 659c1078ba Updated Documentation to include site_id param 2016-12-08 11:33:54 -05:00
Corwin Brown 2c9512aece Adding Site_ID param 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck bb27e38578 corrected replacement of last backslash 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck cd0e97dc77 corrected requirements 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck 5f9eaf193e fixxed problems related to path input 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck 0d01a36dd9 first implementation of win_share module 2016-12-08 11:33:54 -05:00
Marcin Dobosz 6f68db5c1a Fix win_iis_webapppool module to not null ref when removing an apppool using PS4 2016-12-08 11:33:54 -05:00
nitzmahone 092c3ccbde fix default arg handling and error messages in win_file_version 2016-12-08 11:33:54 -05:00
nitzmahone db58300aa7 fix missing bracket in win_file_version 2016-12-08 11:33:54 -05:00