2d81a1fa77
Complete the change from $FILE{} to $FILE()
...
Otherwise, parsing e.g. '$FILE(myfile)'.find("stuff") will include
everything up to the last ) as the filename.
2012-09-29 21:16:13 +02:00
be9d7df6c4
Allow multiline strings to work okay in only_if
...
Fixes issue #1137
2012-09-29 21:13:19 +02:00
e655e2f051
Raise AnsibleError if $FILE() or $PIPE() fail
2012-09-29 21:09:57 +02:00
aa5ef9561d
ANSIBLE_CONFIG take precedence over ./ansible.cfg
2012-09-29 10:44:14 -04:00
9377c3f525
Merge pull request #1130 from commandtab/templates-trim-blocks
...
Setting trim_blocks to True
2012-09-29 05:25:56 -07:00
08a77135f3
Merge pull request #1126 from dagwieers/choices-fix
...
Fix to make sure only strings are being joined
2012-09-28 16:12:17 -07:00
7c600ae0d3
Setting trim_blocks to True
2012-09-28 14:58:05 -07:00
27b2ae8ddc
Fix to make sure only strings are being joined
...
Since BOOLEANS also contains integers, joining the list returns an error. Easy to test by giving a wrong value to a boolean argument:
service name=httpd enabled=True
Since True is not in the allowed BOOLEANS, it will cause the error, which in its turn bails out because it joins strings and integers.
We may want to remove the integers from the choices since '0' and '1' are already in the list as strings. Personally I would expect only strings as arguments, not sure where these could be integers ??
2012-09-28 17:51:59 +02:00
c84e76e31d
Make sure we retain facts between playbooks
...
This is mandatory if we want to make facts-modules (like network_facts, ilo_facts and esx_facts) work.
2012-09-28 17:44:51 +02:00
d25ee940c4
Close zeromq context and socket.
2012-09-28 08:22:53 -04:00
4b29c2cf74
Revert pull request #1091
...
Automatic quoting of variables in only_if breaks existing playbooks
where entire statements are put in a variable, and other cases. See
issue #1120 for details.
2012-09-28 13:58:23 +02:00
618a519ee3
Merge branch 'varreplace-lessre' of git://github.com/dhozac/ansible into devel
2012-09-27 22:08:38 -04:00
e7af005408
Revert only_if for variables and templating prompt
...
Since the condition was not templated, it wasn't working.
Only variables in local scope were used, which made this not very practical
2012-09-28 01:32:09 +02:00
9e4fac5ebd
Create a string parser for varReplace instead of using re
...
This fixes a few issues,
- ${foo}${bar} would be parsed as a variable named foo}${bar,
which wouldn't be easily fixed without breaking ${foo.${bar}}
- allows escaping . in variable parts so e.g.
${hostvars.{test.example.com}.foo} works
This is slower than using re. 3 million templating calls take about
about twice as long to complete with this compared to the regexp,
from ~65 seconds to ~115 seconds on my laptop.
2012-09-28 01:03:34 +02:00
6506e17eff
Merge pull request #1109 from dhozac/fix-varReplace-repr
...
Fix only_if statements referencing non-string types
2012-09-27 15:57:50 -07:00
6c6f2b46b4
Merge pull request #1110 from dhozac/rm-assemble-ap
...
Remove assemble action plugin, fix daisychaining
2012-09-27 15:54:27 -07:00
ee5246fc36
Merge pull request #1113 from jpmens/file_pipe
...
Strip trailing white space from $FILE()/$PIPE()
2012-09-27 15:54:09 -07:00
42620d2f19
Strip trailing white space from $FILE()/$PIPE()
2012-09-27 23:47:34 +02:00
b55ef665ba
Fix only_if statements referencing non-string types
...
This fixes e.g. only_if: ${task.changed} which would always
evaluate to true due to it having been replaced by a string for its
boolean value. Also adds a test case to ensure it doesn't get
missed again.
2012-09-27 18:36:52 +02:00
66d0acfde3
Remove assemble action plugin, fix daisychaining
2012-09-27 18:30:08 +02:00
0db5ccfecb
Don't use ssh-agent if password is specified.
2012-09-27 14:57:06 +07:00
69612ba16d
The very first start of 'fireball mode', which uses ansible in SSH mode to deploy a ephemeral zeromq daemon (entirely optional) that is will die after
...
it is no longer used. No key signing will be required. At this point, development use only -- NOT complete.
2012-09-26 23:51:59 -04:00
c63189f650
Make output be cleaner on multi-line failed commands and parse errors.
2012-09-25 20:38:12 -04:00
07101085ca
Merge pull request #1093 from brainpage/make_local_action_consistant
...
2 improvements to delegate_to
2012-09-25 17:17:33 -07:00
84f98534ae
Make varReplace recursive instead of iterative
2012-09-25 20:14:58 -04:00
d181a64315
Use repr on replacements for only_if
2012-09-25 20:14:58 -04:00
489844f960
Merge pull request #1095 from pas256/devel
...
Getting negative host pattern matching to work with external inventory
2012-09-25 17:13:32 -07:00
df147ab921
Merge pull request #1089 from tbielawa/runner_pause
...
Add 'pause' action plugin and support plugins skipping the host loop.
2012-09-25 17:11:54 -07:00
8a4e969b93
Getting negative host pattern matching to work with external inventory
...
(same as commit 4caf85e37b
2012-09-25 16:16:25 -07:00
faed650bb1
allow vars in delegate_to
2012-09-26 03:47:17 +08:00
620accf117
make delegate_to localhost act like local_action
2012-09-26 02:57:00 +08:00
f8a9541405
add __init__ to action plugins
2012-09-25 08:24:35 -04:00
730b617186
Add init, though it's not really used.
2012-09-25 08:21:59 -04:00
8e71b26264
Fix up 'changed' playbook output patch
2012-09-25 08:07:11 -04:00
6b6e3c64c8
Fix a typo in the prompt code
...
This is unfortunately related to not being able to reuse the same code that was tested.
2012-09-25 11:51:33 +02:00
58a4d2f7b4
Add 'pause' action plugin and support plugins skipping the host loop.
2012-09-25 01:13:35 -04:00
5dab2efcdf
Fixed obvious bug with missing self parameter to is_executable method
2012-09-24 21:03:45 -04:00
29ac1a8efc
Replace os.access with stat calls for determining the executability of a given path.
2012-09-24 21:03:45 -04:00
734db4ffe9
Merge pull request #1080 from dagwieers/prompt-only_if
...
Add an only_if option to vars_prompt to make prompts conditional
2012-09-24 17:42:17 -07:00
9778eaf4f9
Merge branch 'module_args-argument' of git://github.com/dhozac/ansible into devel
2012-09-24 20:39:48 -04:00
4e9a970616
Add an only_if option to vars_prompt to make prompts conditional
...
Sometimes you may want to allow variables through host_vars or inventory, but prompt for a value if it is not set or if the value does not conform to something specific. This option allows you to specify when you want to offer a prompt.
This patch also moves check_conditional to utils, and adds an is_unset() function which is nicer to read:
only_if: "not is_set('${var}')"
vs
only_if: "is_unset('${var}')"
2012-09-24 23:55:54 +02:00
b355dca7dd
Merge pull request #1081 from dsummersl/changelabel
...
Modified 'ok' to 'changed' when a change has occured
2012-09-24 13:46:06 -07:00
069feb5d9c
Template the variable prompt to customize the message
...
We have a password-prompt for a configurable login name. Since we require to ask the password for this specific login, it is important to indicate what password needs to be prov ided on the prompt. So the prompt needs to be templated. That's what this patch does.
2012-09-24 22:37:51 +02:00
04c535b1e9
Modified 'ok' to 'changed' when a change has occured
2012-09-24 16:07:56 -04:00
34f7e6ffa0
Pass module arguments as argument instead of keeping it in runner
2012-09-23 23:38:26 +02:00
3939f7a812
Merge pull request #1076 from SleeplessAnnoyedNerd/Issue-1075
...
[Issue #1075 ] Fixing setup module fails if PATH is not set on target hos...
2012-09-23 10:23:18 -07:00
f5f17e98ff
Merge pull request #1065 from dhozac/varreplace-include
...
Allow including files through variables
2012-09-23 10:20:26 -07:00
78b7a3a115
[Issue #1075 ] Fixing setup module fails if PATH is not set on target host
2012-09-22 17:01:37 +02:00
8d97bb4f8e
Add an ansible_ssh_host inventory variable
2012-09-22 00:57:55 +02:00
4ded8cb3b3
Change $FILE{} and $PIPE{} to $FILE() and $PIPE()
2012-09-19 17:58:16 +02:00
cc948f339c
Allow including files through variables
...
$FILE{file} will be replaced with the contents of "file"
$PIPE{cat file} will be replaced with the output of "cat file"
2012-09-19 17:57:17 +02:00
b8c4bb9e6e
Revert "Allow including files through variables"
...
This reverts commit bf47bb4753
2012-09-19 10:31:23 -04:00
b2af95e4a6
Change $FILE{} and $PIPE{} to $FILE() and $PIPE()
2012-09-18 21:34:55 -04:00
b25b9fd840
Merge pull request #1058 from jkleint/devel
...
Support iteration over command output in with_items.
2012-09-18 17:55:40 -07:00
544a8e44d7
Merge pull request #1053 from dhozac/varreplace-include
...
Allow including files through variables
2012-09-18 17:53:02 -07:00
2a002f5c0b
Support iteration over command output in with_items.
...
When the output of a command is stored in a register, this will create a
stdout_lines field in the result object that contains stdout split into a list
of lines. This list can then be iterated over using with_items.
2012-09-17 16:57:33 -04:00
dd11b01350
Keep delegate_to so all auxiliary logic based on that works
2012-09-17 20:28:14 +02:00
5bb0f6908b
Allow transport on tasks, and use it for local_action
2012-09-17 18:28:37 +02:00
bf47bb4753
Allow including files through variables
...
$FILE{file} will be replaced with the contents of "file"
$PIPE{cat file} will be replaced with the output of "cat file"
2012-09-17 16:03:59 +02:00
58ad934283
Merge pull request #1024 from tima/groups-pb
...
Made $groups and $group_names variables accessible in with_items
2012-09-11 14:59:05 -07:00
1829d519b5
Merge pull request #1030 from lorin/import-playbook-pathfix
...
Support import of playbooks in other directories
2012-09-11 14:58:27 -07:00
d7f83471ae
Merge pull request #1032 from mavimo/patch-2
...
Add support for ./ansible.cfg file
2012-09-11 14:56:22 -07:00
1f8696f5c1
Fix inventory.get_hosts when hosts is a list.
2012-09-11 13:00:40 -04:00
0cdd081b53
Add support for ./ansible.cfg file
...
Ansible support configuration in:
```
~/.ansible.cfg
/etc/ansible/ansible.cfg
```
this patch add current user (usefull where user have some different projects) with the oreder:
```
./ansible.cfg
~/.ansible.cfg
/etc/ansible/ansible.cfg
```
2012-09-10 17:57:32 +03:00
9d5a79f586
Made groups.groupname and group_names variables accessible in playbooks.
...
Also modified code that feeds the groups data structure to templates so
that it resolves groups inside of groups to hostnames.
2012-09-10 10:42:26 -04:00
b9e100a506
Support import of playbooks in other directories
...
Previously, importing a playbook in a different directory didn't
work because all of the relative paths were resolved relative to
the top-level playbook.
This patch resolves relative paths on a per-play level instead of
relative to the directory of the top-level playbook.
Also removes the dirname argument from the Play._get_vars method
since this argument wasn't used in the metho dbody.
2012-09-09 22:59:56 -04:00
e795fa1ec2
Merge pull request #1014 from marktheunissen/journald
...
Fix regex that allows passwords to get into syslog, use journal if available.
2012-09-08 05:22:27 -07:00
20fc6a29d3
Made groups.groupname and group_names variables accessible in playbooks.
2012-09-07 18:07:52 -04:00
eabbaaec46
Have ansible respect private_key_file option
...
The ansible command-line tool was ignoring the private_key_file option.
2012-09-07 14:37:32 -04:00
f456d999a9
Fix templates for non root sudo_user
...
When using template module, if a restrictive umask is set, the
sudo_user won't be able to read the /tmp/ansible-dir/source file
after it is copied across following _transfer_str
I wonder if this behaviour shouldn't be abstracted somehow (as
this correction also happens after put_file in the copy module too)
2012-09-07 16:35:53 +10:00
c25ead382c
Adapt module common code to use the systemd journal if it's available
2012-09-06 17:59:38 -07:00
dc14681530
rename isset to is_set
2012-09-06 20:55:27 -04:00
8621539341
Merge branch 'only_if-isset' of https://github.com/dhozac/ansible into devel
2012-09-06 20:55:11 -04:00
ba97ad13e3
Merge pull request #1010 from tima/yaml-jinja
...
Added to_yaml and from_yaml filters to Jinja environment.
2012-09-06 17:50:01 -07:00
8a09e1281b
Fixup modularized template module
2012-09-06 19:04:27 -04:00
633e513a65
Modular server-side actions (squash merge)
2012-09-06 18:57:04 -04:00
975c323e39
Release version bump
2012-09-06 18:56:38 -04:00
2bf9a92bb6
Don't load plugins starting with "_".
2012-09-06 18:46:15 -04:00
6fb1884a03
Add __init__'s to git
2012-09-06 18:43:28 -04:00
23cd7ad08a
Added to_yaml and from_yaml filters to Jinja environment.
2012-09-06 10:19:56 -04:00
02510ec2ff
--version is now taking the correct head
2012-09-06 15:18:29 +03:00
14db2fa376
Add an isset("$var") function to only_if
2012-09-05 23:18:47 +02:00
f41d3b9bd2
Fix skipped callback
2012-09-04 21:56:32 -04:00
96f257cea1
Fix invocation-output-supression code to still provide invocation data to the callbacks.
2012-09-04 21:16:12 -04:00
2843e31e09
Don't add 'n/a' because if running from source there will be no git
2012-09-04 21:07:29 -04:00
0c386b0514
Merge pull request #993 from andronat/repo-as-submodule
...
Fixed a parsing HEAD problem, when ansible is checked out as a submodule
2012-09-05 17:04:09 -07:00
ba707f56c1
except now returns a 'n/a' version. Some changes in comments
2012-09-05 12:40:14 +03:00
aa704a6111
backuplocal => backup_local for API standardization reasons
2012-09-04 19:49:49 -04:00
b97e2a6f5a
Merge branch 'backup-common' of https://github.com/dhozac/ansible into devel
2012-09-04 19:45:39 -04:00
7a201dbb2e
Keep result pristine for ignore_errors
2012-09-04 22:40:07 +02:00
63b4f8dd80
small typo
2012-09-04 17:12:16 +03:00
44a28838db
Fault handling for YAML file and gitdir value.
2012-09-04 17:05:00 +03:00
dfcb9d3c2d
Move backup to module_common
2012-09-04 16:04:53 +02:00
6c8171f6f9
Appended repo_path
2012-09-04 16:28:57 +03:00
4e94db3d78
Fixed a parsing HEAD problem, when ansible is checked out as a submodule
...
Fixed a parsing HEAD problem, when ansible is checked out as a
submodule in git
2012-09-04 16:12:39 +03:00
c04f00e3a6
Fix async callback
2012-09-02 11:20:56 -04:00
a37c6ea936
Jinja2 filter from_json added, to_json renamed
2012-08-31 07:30:18 +02:00
f140332ff6
Make it possible in the inventory file to have spaces in host variables
2012-08-30 19:51:46 -04:00
6742e9c3f4
Add option required=(True|False) to get_bin_path and update modules
...
Added required as optional argument to get_bin_path(). It defaults to
false. Updated following modules to use required=True when calling
get_bin_path(): apt_repository, easy_install, group, pip,
supervisorctl, and user.
Also removed _find_supervisorctl() from supervisorctl module and updated
_is_running() to not need it.
2012-08-30 11:01:37 -07:00
4e7b67a45a
Add option to pass list of dirs to get_bin_path in module_common.py
...
The optional list is prepended to PATH.
Fix get_bin_path() to use os.path.join().
2012-08-29 17:08:45 -07:00
Daniel Hokka Zakrisson
Lorin Hochstein
Michael DeHaan
Collin Allen
Dag Wieers
Ralph Bean
Jan-Piet Mens
Aleksej Romanov
Peter Sankauskas
Jonathan Palley
Tim Bielawa
Michael Lambert
Dane Summers
Dietmar Schinnerl
John Kleint
Marco Vito Moscaritolo
Timothy Appnel
willthames
Mark Theunissen
Anastasis Andronidis
Stephen Fromm