2afecc7198
fix version_added issues in win_iis_website
2016-12-08 11:33:54 -05:00
2e4cb9c651
added doc note to win_iis_website site_id arg
2016-12-08 11:33:54 -05:00
659c1078ba
Updated Documentation to include site_id param
2016-12-08 11:33:54 -05:00
2c9512aece
Adding Site_ID param
2016-12-08 11:33:54 -05:00
bb27e38578
corrected replacement of last backslash
2016-12-08 11:33:54 -05:00
cd0e97dc77
corrected requirements
2016-12-08 11:33:54 -05:00
5f9eaf193e
fixxed problems related to path input
2016-12-08 11:33:54 -05:00
0d01a36dd9
first implementation of win_share module
2016-12-08 11:33:54 -05:00
6f68db5c1a
Fix win_iis_webapppool module to not null ref when removing an apppool using PS4
2016-12-08 11:33:54 -05:00
092c3ccbde
fix default arg handling and error messages in win_file_version
2016-12-08 11:33:54 -05:00
db58300aa7
fix missing bracket in win_file_version
2016-12-08 11:33:54 -05:00
a077c4bc9d
fix some error for passing CI build.
2016-12-08 11:33:53 -05:00
b174416895
Fixed: exception swallowing
2016-12-08 11:33:53 -05:00
d5fe7633e2
new module win_file_version
2016-12-08 11:33:53 -05:00
62e8f46390
Converting result to snake_case before returning
2016-12-08 11:33:52 -05:00
ac620b79dd
Added UseBasicParsing flag
...
win_uri uses "Invoke-WebRequest" under the covers, which apparently
uses Internet Explorer to parse a webpage. The problem is if a user
has never run Internet Explorer, it will be unable to do that. The
work around for this is to set the "-UseBasicParsing" flag.
The only advantage to having the Internet Explorer parsed page is
that you can then access the DOM as if it was a powershell
argument. That doesn't seem super useful for Ansible to be able
to do, so I set the default to be "-UseBasicParsing"
2016-12-08 11:33:52 -05:00
20284fed88
bug fixes
2016-12-08 11:33:52 -05:00
88e4faa1ac
Using Get-AnsibleParam
...
conflict
typo
2016-12-08 11:33:52 -05:00
a979624b88
Adding win_uri module
2016-12-08 11:33:52 -05:00
27be34ef9d
DOCUMENTATION fixes for a few modules
2016-12-08 11:33:51 -05:00
e3cffb0de4
Fix version_added for recently added modules
2016-12-08 11:33:51 -05:00
d5ad463a5a
Add extra PS Drives so you can access other parts of the registry
2016-12-08 11:33:50 -05:00
55c671a18b
removed hardcoded paths, check for .exe error exit code, use get-attr for required param check.
2016-12-08 11:33:50 -05:00
f1579a1207
init commit win_timezone
2016-12-08 11:33:50 -05:00
061365e892
First pass at adding win_regmerge module for handling bulk registry changes
2016-12-08 11:33:50 -05:00
84a5a7a831
fail if type parameter is empty
2016-12-08 11:33:47 -05:00
9a533f1b5f
added credits, fixed documentation
2016-12-08 11:33:47 -05:00
464fb89698
made win_acl strict compliant
2016-12-08 11:33:47 -05:00
8f7517ac21
fixed problem with sid/windows 2008 by using SID. fixed problems related to default accounts like BUILTIN\SYSTEM
2016-12-08 11:33:47 -05:00
dd918401f8
Added Error messages to the Try/Catch blocks
2016-12-08 11:33:47 -05:00
e0fa5fa74c
Switching to Get-AnsibleParam
...
Switching to Win_Unzip
2016-12-08 11:33:47 -05:00
34ff61e24f
Made Powershell Strict Complient
2016-12-08 11:33:47 -05:00
255c4b01a8
Remove duplicate documentation fields
2016-12-08 11:33:46 -05:00
7a1284fe70
Fix #1512 add missing property in win_firewall_rule
2016-12-08 11:33:46 -05:00
49fe0b7815
win_regedit: fixes #1404
...
When 'value:' is set to be the key's "(default)" property value
2016-12-08 11:33:44 -05:00
8687151f7c
fix error with misArg not being declared
...
also fixed test to work on empty string or not for error reporting
2016-12-08 11:33:39 -05:00
9387c842a1
Use "" for AppParameters if it's null
2016-12-08 11:33:39 -05:00
ccb5829673
added missing version_added to new options
2016-12-08 11:33:39 -05:00
42d89dec18
win_chocolatey: Clean up documentation
2016-12-08 11:33:39 -05:00
633773f386
win_chocolatey: Add install_args, params and ignoredependencies
2016-12-08 11:33:39 -05:00
ab7aa73cdb
Correct problem with changed:true
...
I have just changed a small piece of this module to avoid to return always that the task is changed
2016-12-08 11:33:38 -05:00
30da816c54
Fix #1101 : win_webpicmd strict mode fixes
2016-12-08 11:33:37 -05:00
5b3363d178
Replace slashes in the parameter string Also remove duplicate documentation
2016-12-08 11:33:37 -05:00
28baed011d
Appending "Registry::" is not needed and no longer works.
2016-12-08 11:33:37 -05:00
b3ffcd7c6c
fix race condition and missing property
2016-12-08 11:33:36 -05:00
2b860bbae8
Adds examples for win_iis_virtualdirectory
2016-12-08 11:33:32 -05:00
6d166d75bc
Fix: support for virtual directories in applications
2016-12-08 11:33:32 -05:00
b8fbbdbff0
Fixing Some Issues with out Parameters are passed around. Also some refactoring.
2016-12-08 11:33:32 -05:00
3ad86e383e
added start mode feature
2016-12-08 11:33:32 -05:00
b2f666a2dd
strict variables fix
2016-12-08 11:33:32 -05:00
349c4a2a48
added dependency and user settings
2016-12-08 11:33:32 -05:00
51b1cd061a
Strict-Mode fixes
...
Changes to missing member handling to support running top-level script under Strict-Mode v2 (as Ansible 2.0.0 does now)
2016-12-08 11:33:32 -05:00
92cbe5be0e
Fix #1107 : Prepend registry type on key path
2016-12-08 11:33:31 -05:00
6fed60c1bd
Fix #1107 : Use Get-Attr in win_regedit
2016-12-08 11:33:31 -05:00
d90f91e802
Various improvements to win_package
2016-12-08 11:33:31 -05:00
8e557dfc45
Made win_iis_webapppool Strict Compliant
2016-12-08 11:33:30 -05:00
2f6f6cedf8
Fix #1099 : Only populate site result when it is there
2016-12-08 11:33:28 -05:00
60c495f18c
Fix win_acl docs build
2016-12-08 11:33:28 -05:00
0524904dda
fixes examples in docs to use updated param name
2016-12-08 11:33:28 -05:00
43074a736d
changes param src to path, and updates docs accordingly
2016-12-08 11:33:27 -05:00
00a4ec5e3b
updates user search verification for local/domain - Thanks to @trondhindenes for implementing this strategy - also updated documentation
2016-12-08 11:33:27 -05:00
9ad30acd96
changes check for src
2016-12-08 11:33:27 -05:00
6abfcffc70
check if the rule exists or not before allow/deny rules are added/removed, and fixes where result changed would be true on all executions.
2016-12-08 11:33:27 -05:00
25a3793a49
inital commit win_acl
2016-12-08 11:33:27 -05:00
15ac8e9141
turned out strict msi code checking
2016-12-08 11:33:27 -05:00
4fc4030c58
Adding fix to get around bug found with the New-Webstire command when running playbook on a vanilla machine.
2016-12-08 11:33:27 -05:00
40a1bd1962
fix: Add 'enable:' flag for enabling existing rules which are disabled by default.
...
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.
Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.
But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
2016-12-08 11:33:27 -05:00
e0da4a3362
fix: update documentation with new module name "win_firewall_rule"
2016-12-08 11:33:27 -05:00
7188ae4fe1
fix: The names of firewall profiles are different on win10 & win2008r2
...
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).
For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.
Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.
Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
2016-12-08 11:33:27 -05:00
f64e438150
fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch.
...
In win10 (and pribably win8x also):
The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".
This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".
There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
2016-12-08 11:33:26 -05:00
b9dd3568f3
fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()'
...
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
2016-12-08 11:33:26 -05:00
17d1c8916d
Document module limitations to resolve https://github.com/ansible/ansible-modules-extras/issues/908
2016-12-08 11:33:25 -05:00
4134b7a04d
doc formatting fixes
2016-12-08 11:33:25 -05:00
bf59d1cc1e
win_updates rewrite for 2.0
...
uses scheduled job to run under a local token (required for WU client)
supports check mode
no external PS module deps
2016-12-08 11:33:24 -05:00
86be6b1dba
added module author
2016-12-08 11:33:24 -05:00
6890cc81be
fixes #984
2016-12-08 11:33:24 -05:00
07af4c3627
Fix doc build
2016-12-08 11:33:24 -05:00
cb88c17856
win_chocolatey bugfixes
2016-12-08 11:33:23 -05:00
3ea3b9efc9
Move comments to the documentation
2016-12-08 11:33:22 -05:00
6fa4292bed
Remove unnecessary aliases arrays
2016-12-08 11:33:22 -05:00
ebbe086d3a
Clean up unneeded comment and comma
2016-12-08 11:33:22 -05:00
fbf6c2ddc3
Adding nssm requirement note
2016-12-08 11:33:22 -05:00
d6c42c0e6f
Adding win_nssm module
2016-12-08 11:33:22 -05:00
9fd59bde6d
Remove duplicate action declaration.
2016-12-08 11:33:22 -05:00
6f752a871b
Note parameters that are not idempotent
2016-12-08 11:33:22 -05:00
141b3ce41f
Fix logging of error message
2016-12-08 11:33:22 -05:00
0f9c81a8c2
Add support for specifying user for scheduled task to run as
2016-12-08 11:33:22 -05:00
7ea34369f7
Add support for command arguments
2016-12-08 11:33:22 -05:00
f1e8de2f67
Show order of operations with parenthesis
2016-12-08 11:33:22 -05:00
0d78c01d32
Use helper methods to validate vars. Cleanup logic.
2016-12-08 11:33:22 -05:00
dae8cfe0a9
Remove accidental newlines
2016-12-08 11:33:22 -05:00
e3c6dbf14e
Cleanup enable/disable logic
2016-12-08 11:33:22 -05:00
66d9d896e4
Update method to determine if task exists, add days of week parameter to weekly triggers
2016-12-08 11:33:22 -05:00
28164d2ae4
Ability to add/remove scheduled task
2016-12-08 11:33:21 -05:00
8cb80ce7bf
upon request, added the license
2016-12-08 11:33:20 -05:00
12a26a8f81
add version_added: "2.0"
2016-12-08 11:33:20 -05:00
8aa14ac4aa
renamed profile var
2016-12-08 11:33:20 -05:00
c7fb582b9c
windows default to current instead of all
2016-12-08 11:33:20 -05:00
3511497dc1
renamed the module
2016-12-08 11:33:20 -05:00
115fb59136
added the profile option + updated the docs for it
2016-12-08 11:33:20 -05:00
nitzmahone
Corwin Brown
Corwin Brown
Hans-Joachim Kliemeck
Marcin Dobosz
Sam Liu
Matt Martz
jhawkesworth@users.noreply.github.com
Phil
Toshio Kuratomi
tcr
Dreamcat4
Brian Coca
gfrank
Guido Lorenz
daveres
Brian Geihsler
Adam Keech
Henrik Wallström
Trond Hindenes
Nicolas Landais
Michael Perzel
TimothyVandenbrande
Timothy Vandenbrande