a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
38,011 Commits
13 Branches
186 Tags
290 MiB
Commit Graph

606 Commits (2e68811c34c382c8f8f5d6223b30a79e9fbd8e67)

Author SHA1 Message Date
saichint 3a144b290d fix for nxos_vxlan_vtep_vni issues (#34946) 
* fix vxlan_vtep_vni issues

* pep8 errors
 2018-01-17 11:07:29 +05:30
Matt Clay 227ff61f9d
Add module support to yamllint sanity test. (#34964) 
* Add module support to yamllint sanity test.
* Fix duplicate keys in module RETURN docs.
* Fix syntax in return_common docs fragment.
* Fix duplicate keys in module EXAMPLES docs.
 2018-01-16 15:08:56 -08:00
Trishna Guha a727930f07
Remove deprecated params from module argspec nxos modules (#34911) 
* Remove deprecated param from module argspec nxos modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix nxos_vrrp syntaxerror

* Add choices for version _nxos_ip_interface

* remove check_args function

* remove include_defaults
 2018-01-16 18:23:58 +05:30
John R Barker 195beebcb4
Module DOCUMENTATION should match argspec (#34895) 
* Module DOCUMENTATION should match argspec

Large update of many modules so that DOCUMENTATION option name and
aliases match those defined in the argspec.

Issues identified by https://github.com/ansible/ansible/pull/34809

In addition to many typos and missing aliases, the following notable
changes were made:

* Create `module_docs_fragments/url.py` for `url_argument_spec`
* `dellos*_command` shouldn't have ever had `waitfor` (was incorrectly copied)
* `ce_aaa_server_host.py` `s/raduis_server_type/radius_server_type/g`
* `Junos_lldp` enable should be part of `state`.
 2018-01-16 12:18:51 +00:00
Trishna Guha a65f702155
add config option to replace argument (#34342) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-15 21:17:02 +05:30
saichint c04cd8642d fix vxlan idempotent issue (#34750) 2018-01-15 12:27:37 +05:30
Trishna Guha 303894dd17
fix nxos_banner (#34695) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-11 21:13:00 +05:30
Trishna Guha df8b01aaf7
Handle platform os version for sandbox nxos_nxapi (#34490) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-11 21:12:00 +05:30
saichint 6f8d3ad70d Fixes for nxos_bgp (#34590) 
* fix bgp issues

* add new tests cases

* review comments
 2018-01-10 10:52:26 +05:30
Trishna Guha 5e6b2495c0
Convert nxos_vrf to DI module (#34274) 
* Convert nxos_vrf to DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add purge example and improve logic

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* revert version_added for rd param

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update test to use network_cli

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-08 10:10:34 +05:30
Nathaniel Case c371ed8d30
nxos tests to use network_cli (#34474) 
* Fix over-byte

* Fix nxos_l2_interface docs

* Update connections for tasks

* Add default ssh port

* Only report provider when using connection=local

* Send empty provider when connection=network_cli

* Fix find tasks
 2018-01-05 12:39:04 -05:00
John R Barker 2be5ad4f08 deprecation dict not live yet (#34493) 2018-01-05 03:28:53 -05:00
Trishna Guha 9d2182bcf8 Deprecate nxos_switchport and Add nxos_l2_interface DI module (#33813) 
* Deprecate nxos_switchport

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_l2_interface DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fixes

* aggregate test for nxos_l2_interface

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* revert nxos_switchport test change

* gundalow's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-05 07:44:02 +00:00
Pilou e9a5ff912a nxos_file_copy: fix broken import and 2.6 compatibility (#34480) 
* Fix broken import: paramiko could be missing

* doc: use formatting function

* Use Python 2.6 compatible format string
 2018-01-05 11:36:11 +05:30
Ganesh Nalawade ab67539bef
Add nxos_lldp module (#34453) 
* Add nxos_lldp module

*  Implemetation for nxos_lldp module
*  Integration test for nxos_lldp module

* Minor change
 2018-01-04 18:06:15 +05:30
bdowling 552d1df901 Adds parents to mutually_exclusive with src for *_config modules (#33957) 
* mutually_exclusive add - ios_config parents works with lines by not src

* mutually_execlusive parents,src added to all other net modules

* tests for mutually_exclusive parents,src and whitespce removal
 2018-01-03 09:47:12 -05:00
Trishna Guha 80ba767204
Convert nxos_interface to DI (#34240) 
* Convert nxos_interface to DI

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* commit for ganeshrn's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-12-28 16:41:09 +05:30
Trishna Guha 60f3649ebd
Convert nxos_vlan to DI module (#31866) 
* Convert nxos_vlan to DI

* fix conflict

* push fix for qalthos's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-12-21 14:08:33 +05:30
Trishna Guha 4a4da2b774
nxos_static_route DI module (#33797) 
* nxos_static_route DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add version_added
 2017-12-20 17:08:29 +05:30
Trishna Guha be89822bb5
Deprecate nxos_portchannel and add nxos_linkagg DI module (#33376) 
* deprecate nxos_portchannel

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_linkagg DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* remove nxos_portchannel unit test

* fix syntax issues

* fix ansible-doc failure

* update nxos_portchannel unittest

* minor fixes and integration test

* update nxos_linkagg
 2017-12-20 11:26:07 +05:30
Trishna Guha 3cce8dfafd
Deprecate nxos_ip_interface and Add nxos_l3_interface DI module (#33866) 
* Deprecate nxos_ip_interface module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_l3_interface DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fixes

* Add nxapi cli test

* Improve complexity

* manage layer3 interface

* fix unit test
 2017-12-20 11:07:23 +05:30
Trishna Guha 27be2a0f5a
Handle nxos platform diffs with cli conf implementation (#34020) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-12-20 10:41:10 +05:30
Trishna Guha 9f86b923e9
[CLI_CONF] Refactor nxos module common library to use cliconf plugin (#31524) 
* refactor nxos modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* get_config update

* fix get_config

* update nxos module

* device_info

* fix conflict

* add failure message check

* pep8 fixes

* use get_capabilities to check cliconf

* Add logic to detect platform in get_capabilities and cache in module_utils

* return msg in edit_config

* fix conflicts

* make modules compatible

* fix nxos cliconf api

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* cache capabilities

* Update transport queries to get_capabilities in module level

* fix unit tests

* load_config error code

* remove unnecessary change

* Refactor nxos_install_os module
 2017-12-19 12:22:33 +05:30
Ganesh Nalawade ea18b9021a
Revert "Deprecate Entity, EntityCollection and use subspec in network modules (#33575)" (#33849) 
This reverts commit 4349b56643.
 2017-12-13 13:07:52 +05:30
Trishna Guha c2b4fd7f1e
Convert non-DI module to DI nxos_user (#33770) 2017-12-11 20:55:05 +05:30
Ganesh Nalawade 4349b56643
Deprecate Entity, EntityCollection and use subspec in network modules (#33575) 
* Deprecate Entity, EntityCollection and use subspec in network modules

*  As per proposal https://github.com/ansible/proposals/issues/76
   deprecate use of Entity, EntityCollection, ComplexDict, ComplexList
   and use subspec instead.
*  Refactor ios modules
*  Refactor eos modules
*  Refactor vyos modules
*  Refactor nxos modules
*  Refactor iosxr modules
*  Add support for key in suboptions handling

* Fix CI issues
 2017-12-11 20:31:25 +05:30
John Barker 10cd2cd1b7 Manually fix issues that autopep8 introduced 
* iam.py 161 -> 160 chars
* lamba -> single line function -> multiline function

Avoid redefining key

iam line length

iam.py now clean
 2017-12-07 20:25:55 +00:00
John Barker c57a7f05e1 Bulk autopep8 (modules) 
As agreed in 2017-12-07 Core meeting bulk fix pep8 issues

Generated using:
autopep8 1.3.3 (pycodestyle: 2.3.1)
autopep8 -r  --max-line-length 160 --in-place --ignore E305,E402,E722,E741 lib/ansible/modules

Manually fix issues that autopep8 has introduced
 2017-12-07 20:25:55 +00:00
rahushen 1a12e733b9 nxos_facts: add check for ipv6 (#33594) 2017-12-06 09:41:31 -05:00
Abhijeet Kasurde 961c3fcca7 Add missing comma in lists (#33557) 
This fix adds missing comma in different modules.
This removes implicit string concatenation in given list.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2017-12-05 15:44:56 +01:00
Ganesh Nalawade 11c9ad23d5
Refactor common network shared and platform utils code into package (#33452) 
* Refactor common network shared and platform specific code into package (part-1)

As per proposal #76 refactor common network shared and platform specific
code into sub-package.
https://github.com/ansible/proposals/issues/76

*  ansible.module_utils.network.common - command shared functions
*  ansible.module_utils.network.{{ platform }} - where platform is platform specific shared functions

*  Fix review comments

* Fix review comments
 2017-12-03 21:42:30 +05:30
Trishna Guha 819f9ee8fa Add port arg to establish ssh connection in nxos_file_copy (#33304) 
* Add port arg to establish ssh connection in nxos_file_copy

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* resolve kedar's comment
 2017-11-28 10:54:23 +05:30
Trishna Guha 7b19c28438
nxos_vrf_interface fix (#33249) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-27 22:56:39 +05:30
Trishna Guha 25a465ffcb
loopback doesn't support passive_interface (#33252) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-27 22:56:16 +05:30
Matt Clay c6bb6c72cc Fix anomalous backslashes and enable pylint test. 2017-11-21 23:22:51 -08:00
Mike Wiebe 95a2140f4b Use show command to support wider platform set for nxos_interface module (#33037) 
* Use show command to support wider platform set

* Fix unit tests
 2017-11-20 18:59:09 +00:00
Arnaud 84117e57ba nxos: 32 bits AS in as-dot format not recognized by regexp asn_regex (#30569) 
* added test for 32 bits AS

* Lint not happy.
 2017-11-20 10:09:16 +00:00
Mike Wiebe 208208ab8f Fix nxos_snmp_host bug (#32916) 
* Fix nxos_snmp_host bug

* Enable nxos_snmp_host tests
 2017-11-16 06:17:42 +00:00
chifu1234 e2fef7beed nxos_facts: cdp support (#31202) 
* nxos_facts get CPD neighbor

* nxos_fact: cdp support

* remove blank spaces

* add ansible_net_neighbors cdp informations
 2017-11-15 07:38:19 -07:00
Trishna Guha 3ee2501c83
multiple fixes nxos (#32903) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-14 15:23:11 +00:00
Trishna Guha c40de24e9c
fix mtu check nxos_interface (#32880) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-14 10:40:37 +00:00
rahushen 1360ae6518 nxos_config and nxos_facts - fixes for N35 platform. (#32762) 
* update nxos_facts to handle errors in n35 platform

* switch show commands to output text

* replace basestring which is not supported in python3

* do it like the other modules: use string_types

* incorporate PR review
 2017-11-14 05:03:37 +00:00
Trishna Guha f49555d494
nxos_bgp_neighbor_af feature idea disable-peer-as-check (#32665) 
* nxos_bgp_neighbor_af feature idea disable-peer-as-check

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add unit test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-13 14:48:31 +00:00
Trishna Guha e4052c1261
Add mtu option nxos_interface feature idea (#32680) 
* Add mtu option nxos_interface feature idea

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add unit test for mtu feature

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-13 14:48:04 +00:00
Trishna Guha b0e7c71716
nxos_interface TypeError fix (#32114) 
* nxos_inteface TypeError fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Make sure that run_commands does not list of strings for json output

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* return default value to handle exception

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-13 10:47:20 +00:00
Mike Wiebe de8d00b401 Fix snmp bugs on Nexus 3500 platform (#32773) 
* Add n35 platform support

* Fix regex bug and add snmp_location it tests

* Enable nxos_snmp_location tests
 2017-11-13 08:03:06 +00:00
Mike Wiebe fedd1779cc Add ISSU capability and fix workflow bug for nxos_install_os module (#32540) 
* Initial issu support

* Enhance ISSU support

* Additional refactoring to simplify code flow

* Remove debugs and bug fixes

* Update doc example output

* Update provider line in task example

* Remove unneeded else clause and comments

* Fix ansible-doc errors

* Satisfy ansibot requirements

* Update header docs

* Update nxos_install_os.py
 2017-11-09 14:54:19 +00:00
Pilou 7fe69daa4d Modules metadata: fix invalid GitHub ID in author field (#31856) 
* Replace Twitter username with GitHub ID

See 8bfa19c4af

* Replace Twitter username with GitHub ID

See 22766906b0

* Fix GitHub ID: add missing letters

See:
- nxos_banner.py: 9c6ee8d0bb
- nxos_logging.py: e37e736ddb
- net_user.py: f6a4803669

* Remove nonexistent author, use GitHub organization

See https://github.com/ansible/ansible-modules-core/pull/2880

Not sure how Ansibullbot will handle an organization ID, but
other deprecated modules already use it.

* Replace Twitter username with GitHub ID

* Replace Twitter username with GitHub ID

See bf59d1cc1e

* Replace Twitter username with GitHub ID

See d02a9016a2

* Author: use GitHub ID

See 0847bfecd672f6b2e0e4429e998df7c6e7042b1c

* Replace Twitter username with GitHub ID

See a59684fddd

* Replace Twitter username with GitHub ID

See 94f9bb962f

* Replace Twitter username with GitHub ID

See 40b7dffea8
 2017-11-02 06:52:18 -04:00
Sean Cavanaugh 1068aa3ce7 Fixing nxos_vlan to match platform agnostic net_vlan part2 (#32410) 
* adding active and suspend to state to match net_vlan module

although this is backwards compatible (for now)

* removing bad config

* getting rid of bad yml syntax
 2017-11-01 14:56:38 +05:30
Trishna Guha 529b7a7b78 fix nxos_igmp_snooping (#31688) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-10-23 09:40:07 +05:30
Trishna Guha f94ef03625 Fixes #30529 nxos_facts ipv6 interface (#31286) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-10-16 18:19:44 +05:30
Kenny Gillen 1234a79349 Fix gender pronouns and the odd typo (#31709) 2017-10-13 13:52:38 -04:00
rahushen 046d430a26 Fixes #31056 (#31057) 2017-10-13 10:38:44 +05:30
Trishna Guha c002b47a79 fix nxos_vlan unexpected deprecation warning (#31624) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-10-12 12:00:35 +05:30
rahushen 025386c56b Fix nxos_banner removal idempotence issue in N1 images (#31259) 
* Fix nxos_banner removal idempotence issue in N1 images

* handle pep8 error
 2017-10-11 16:26:17 +05:30
Toshio Kuratomi 2f8831c787 Fix get_exception and wildcard imports for nxos modules 2017-10-09 21:41:02 -07:00
rahushen 48f4643a66 nxos_snmp_* fixes : Fixes #30997, #30999 (#31000) 
* add codeblock to handle 5K platform for nxos_snmp_host

* fix get_snmp_traps for 5K platform

* Make shippable happy
 2017-10-06 18:21:59 +05:30
rahushen 0218fdcd80 Fixes #30846 (#30862) 2017-10-06 17:10:03 +05:30
rahushen 266c2f5831 fixes #31080 (#31081) 2017-10-05 14:33:59 +05:30
Trishna Guha 9f72b32c5d nxos_config intended_config docfix (#31337) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-10-05 14:25:50 +05:30
rahushen 1378861fe7 Fixes nxos_igmp_interface idempotence issue for N1 images (#31220) 2017-10-04 12:53:44 +05:30
rahushen a12a05c219 Fixes #30769 - nxos_vtp_version errors out on N1 images. (#30770) 
* Fixes #30769

* add the same fix for 2 more vtp modules
 2017-10-03 17:24:14 +05:30
Kedar K 916e6be888 - Fix to return error message back to the module. (#31035) 2017-09-29 17:06:30 +05:30
Ganesh Nalawade 879ea24a74 Fix documentation issue for nxos_snmp_user module (#31029) 
*  Change auth to authentication in module document
   to be in sync with module params
 2017-09-28 13:04:20 +05:30
Kedar K 4c21563ac6 - Adds sub-interface support for nxos_interface and nxos_ip_interface (#30830) 
- Support dot1 encapsulation on routed sub-interface
 2017-09-26 21:34:51 +05:30
Ganesh Nalawade d72eb08902 Fix nxos provider transport warning issue (#30610) 
* Fix nxos provider transport warning issue

*  Add default value of transport arg in provider spec
*  Remove default value if transport arg in top level spec
   This ensure deprecation warning is seen only in case transport
   is given as a top level arg in task
*  Refactor nxos modules to reference transport value from provider
   spec

* Fix unit test

* Remove transport arg assignment in nxos action plugin

* As assigning transport value is handled in provider spec
  top level task arg assignment is no longer required
 2017-09-22 10:32:25 +05:30
Trishna Guha ae044f507f fix nxos_reboot command format (#30549) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-09-20 10:06:57 +05:30
Trishna Guha e308176f3e fix write_on_file nxos_snapshot (#30545) 
* fix write_on_file nxos_snapshot

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* some more logic

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-09-20 10:06:38 +05:30
Nathaniel Case 7dc60c3f24 nxos_install_os install_state fix 2017-09-15 15:34:32 -04:00
Kedar K ff84fc969c Fixes nxos_pim_rp_address module idempotence (#29620) 
* Fixes nxos_pim_rp_address module idempotence

*  * Adds a note in header comment to indicate no support for absent state
 2017-09-15 14:21:34 -04:00
Mike Wiebe 9af6dc4751 Fix nxos_snmp_community idempotence issue (#30388) 
* Fix nxos_snmp_community idempotence issue

* Use passed in name to filter

* Test updates and remove unused method
 2017-09-15 07:45:51 -07:00
Mike Wiebe 173c41aefe Rel240/fix nxos pim interface (#29885) 
* fix nxos_pim_interface

* Add integration test coverage and fix unit test

* Add clarifying comments

* Make ansibot happy
 2017-09-14 13:36:32 -07:00
Mike Wiebe 3faba93a2b Fix nxos_interface error for nxapi and idempotence problem (#29136) 
* Fix nxos_interface nxapi error and idempotence

* Make shippable happy
 2017-09-14 10:25:35 -07:00
rahushen 37f68bffc0 fixes #27177 - nxos_aaa_server_host multiple issues (#29103) 2017-09-14 09:29:53 -07:00
saichint 4e32c92166 nxos_udld_interface: improve interface detection (#28682) 
* fix for nxos_udld_interface

* Tested Note added back
 2017-09-13 11:06:56 -07:00
Nathaniel Case 8c03609e54 nxos_snmp cleanup (#28922) 
* Clean up nxos_snmp_contact & nxos_snmp_location

* Bring nxos_snmp_community in line

* Bring nxos_snmp_host in line

* And I would have gotten away with it too,

if it weren't for those meddling sanity tests

* Bring nxos_snmp_traps & nxos_snmp_user in line

* Appease Shippable
 2017-09-13 08:23:36 -07:00
rahushen 1a266e29a7 Fixes #28793, #27484 (#29745) 2017-09-13 08:08:22 -07:00
rahushen 169fbc4c94 Fixes #28493 (#29061) 2017-09-13 08:00:13 -07:00
rahushen 5537218c94 fixes #27066 - nxos_acl errors when there are 0 or 1 access lists configured (#29076) 
* fixes #27066

* replace type() with isinstance()
 2017-09-13 18:07:06 +05:30
rahushen f1cc5a928c Fixes #27336 - nxos_gir_profile_management issue while creating profile (#29151) 
* Fixes #27336

* Correct documentation errors
 2017-09-13 17:54:35 +05:30
Mike Wiebe 7292dd20ed Fix nxos_overlay_global networking modules (#28943) 2017-09-13 17:33:06 +05:30
rahushen bc6e015a86 Fixes #27138 (#29064) 2017-09-13 17:11:00 +05:30
Trishna Guha 578ae3b238 fix nxos_file_copy and provider getting set to None when transport is cli (#30262) 
* nxos_file_copy bug fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* provider gets set to None in module level when transport is cli

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-09-13 16:36:41 +05:30
Matt Clay 442af3744e Miscellaneous pylint fixes. 
The following rules are no longer disabled:

- bad-format-string
- duplicate-key
- lost-exception
- trailing-newlines
- unexpected-keyword-arg
- useless-suppression
- using-constant-test
 2017-09-13 01:53:08 -07:00
Mike Wiebe cef7ed0310 Fix nxos_mtu nxapi failure (#30153) 2017-09-13 10:51:46 +05:30
Mike Wiebe f973f93963 Fix nxos_smu error (#30157) 2017-09-12 22:17:07 +01:00
Trishna Guha 5b1c91bf19 nxos_system parse name_servers fix (#29944) 
* nxos_system parse name_servers fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix nxos_system tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-09-12 13:25:01 +05:30
Trishna Guha 588bddbc35 nxos_banner CI fix (#29134) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-09-08 19:33:41 +05:30
Nathaniel Case f84ff216b6 Generalize nxos_bgp event-history detection (#28890) 
* More general handling of event-history

* Update unit tests
 2017-09-06 17:37:44 -04:00
Nathaniel Case 8bfdbd0f73 nxos_bgp_neighbor: Fix regex &report warnings (#28888) 
* Fix over-detection of log-neighbor-as

* Report nxos warnings

* Update nxos_bgp_neighbor unit tests to test remove-private-as
 2017-09-01 15:17:42 -04:00
Mike Wiebe fb1aa54341 Rel240/fix nxos interface ospf (#28898) 
* Fixes 28897 nxos_interface_ospf idempotence

* Handle all characters upper or lower with tests
 2017-09-01 11:07:18 -04:00
Nathaniel Case ae6d27fa29 Revert "Bring nxos_snmp_host in line" 
This reverts commit 43247c8dfe.

Revert "Bring nxos_snmp_community in line"

This reverts commit 0df77408d7.

Revert "Clean up nxos_snmp_contact & nxos_snmp_location"

This reverts commit 9e4cdd2fce.

I should probably not be up this early
 2017-09-01 08:00:00 -04:00
Nathaniel Case 43247c8dfe Bring nxos_snmp_host in line 2017-09-01 07:43:05 -04:00
Nathaniel Case 0df77408d7 Bring nxos_snmp_community in line 2017-09-01 07:15:24 -04:00
Nathaniel Case 9e4cdd2fce Clean up nxos_snmp_contact & nxos_snmp_location 2017-09-01 07:12:49 -04:00
rahushen 07c1d7e1ca update nxos_facts to handle n3k power table (#28891) 
* handle power table for n3k
 2017-08-31 14:59:14 -04:00
Nathaniel Case 74daf2381b Fix nxos_config `save` parameter (#28838) 
Also fix saving in general
 2017-08-31 10:01:19 -04:00
Mike Wiebe d9fc3def94 Fixes #28779 eth_mode key error (#28782) 
* Fixes #28779 eth_mode key error

* Remove unused get_config references

* Addressed PR comment
 2017-08-29 17:07:46 -04:00
Nathaniel Case 64dac346c9 Fix nxos_pim_interface dr-priority handling (#28472) 
* Fix nxos_pim_interface dr-priority handling

* Prefer execute_show over `| json`

* Mock get_config

* Fix sparse-mode detection
 2017-08-29 14:42:09 -04:00
rahushen 2cf836772d Add passive_interface property to nxos_ospf_vrf module (#28288) 
* add passive_interface property to nxos_ospf_vrf module

* Add version_added for
 2017-08-29 11:31:11 -04:00
Nathaniel Case 40907d7db2 Fix detection of associate-vrf parameter (#28725) 2017-08-29 09:47:27 -04:00
Nathaniel Case 862cde5e82 [WIP] Fix nxos_banner (#28607) 
* Fix `'state': 'absent'`

* Replace idempotence tests with references

* Fix issues with nxos_banner
 2017-08-28 17:09:54 -04:00
Trishna Guha 0a8ec4ddef fix nxos_igmp_interface output (#28735) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-08-28 17:06:30 -04:00
Mike Wiebe 3d46258cff Refactor/fix nxos_nxapi to use show run (#28675) 
* Refactor/fix nxos_nxapi to use show run

* Fix unit tests

* Python 3 compatibility
 2017-08-28 15:00:56 -04:00
Nathaniel Case fbeb3b9ac5 Nxos ping (#28665) 
* Update documentation & results, clean up code

* Change numeric results to int/float
 2017-08-25 11:45:46 -04:00
Nathaniel Case ada7f248c0 Add 'Tested on' string to NX-OS modules (#28531) 2017-08-24 08:27:39 -04:00
Nathaniel Case e1def05ba2 fix networking *_command check_mode (#28407) 
* Fix check_mode in nxos_command

* Fix check_mode for ios_command

* fix check_mode for iosxr_command

* Fix check_mode in vyos_command

* Fix check_mode in eos_command

* Fix check_mode in junos_config
 2017-08-22 14:02:55 -04:00
Nathaniel Case 96abfde189 Fix idempotence for nxos_vrf_af (#28419) 2017-08-22 14:02:01 -04:00
Mike Wiebe ec11cd2696 nxos_bgp_neighbor_af fix problem with advertise-map properties (#28413) 
* Fix problem with advertise-map properties

* Change limit_to back to run all tests

* Fix unit tests

* Move advertise_map out of get_custom_value
 2017-08-21 15:28:02 -04:00
David Kretch beed59f303 Fix trailing space in ec2_vol example, fix 'the the' typos (#28440) 
* Fix 'the the' typos, fix 'pahting' filename typo

* Change 'the the' typos to a single 'the'.
* Change `playbook_pahting.rst` to `playbook_pathing.rst`.

* Delete trailing space in ec2_vol example

Delete the trailing space in `instance: "{{ item.id }} "`, which makes the
example fail when run because it looks for instance "i-xxxx ".
 2017-08-19 23:00:51 +02:00
Nathaniel Case 33f342435a Attempt to detect and abort when 'fex-fabric' is present (#28342) 2017-08-18 16:13:12 -04:00
Nathaniel Case db5d799122 Fix nxos_pim idempotence (#28348) 2017-08-18 09:47:41 -04:00
David Newswanger b818e986b6 Change network *_user modules to use configured_password to set a users password (#28187) 
* WIP, update eos_user args

* refactor password for ios_user

* add eos tests, fix ios tests

* fixed password check

* refactor iosxr_user password

* fixed password arg for nxos

* [WIP] fix vyos_user password

* fix vyos tests

* update docs for net_user

* fix typo

* fix eos tests

* add warning when attempting to use password arg

* fix sanity/unit tests

* fix eos unit tests

* fix vyos_user aggregate

* fix typo in eos documentation string

* re add configured_password to vyos tests after rebase
 2017-08-17 19:06:44 +05:30
Peter Sprygada 6886153b54 refactors nxos_vrf_af module (#28208) 
* refactors nxos_vrf_af module

fixes #27595

* fix up unit test cases

* add commands to result dict

* add route-target on afi create

* adds deprecation note to safi argument
 2017-08-16 10:11:12 -04:00
Toshio Kuratomi d8b1cb9a63 Assign network modules maintained by the network team the network metadata 2017-08-15 23:12:08 -07:00
Toshio Kuratomi f203ca7907 Update metadata to 1.1 2017-08-15 23:12:08 -07:00
David Newswanger b7d886840b standardized agreggate as arg, and collection and users as aliases for user modules (#28244) 2017-08-16 09:31:25 +05:30
saichint 064ab7a92d fix for remove idempotent issue (#28226) 2017-08-15 13:14:40 -04:00
saichint d69440c4ef Fix nxos_vpc issues (#28188) 
* fix for nxos_vpc issues

* fix unit tests

* clean documentation
 2017-08-15 12:08:55 -04:00
Nathaniel Case 1d13624eae Clean up nxos_aaa_server (#28177) 
* cleanup nxos_aaa_server

* Specify nxos_aaa_server output format

Fixes #27289
 2017-08-15 12:08:03 -04:00
saichint 9d84a4e530 fix for nxos_ospf_vrf invalid cmd and ntp errors (#27977) 
* fix for nxos_ospf_vrf invalid cmd

* fix for nxos_ntp issues
 2017-08-14 16:09:16 -04:00
Nathaniel Case 19a6000d97 Fix nxos_bgp_af networks parameter (#28169) 
* Split 'networks' and 'redistribute' in get_value

* Add missing `'` in docs
 2017-08-14 15:18:10 -04:00
rahushen b74300b657 Additional fix for #27167: port-channel interface idempotence (#27979) 2017-08-14 11:44:12 -04:00
Nathaniel Case 820d7e805a Streamline nxos_smu (#28030) 2017-08-14 10:54:50 -04:00
rahushen b9c3329950 nxos_ip_interface: Fixes for #27170, #27172 (#27935) 
* Fixes for #27170, #27172

* Add nxos_ip_interface IT tests

* For ipv6 check if ip address configured before doing a no ip address
 2017-08-14 10:16:08 -04:00
David Newswanger cfda267b2b fixes pipe issue (#28127) 2017-08-14 17:21:32 +05:30
Trishna Guha 60ce6438e3 fix nxos_overlay_global idempotence (#28150) 
* fix nxos_overlay_global idempotence

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* modify nxos_overlay_global unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-08-14 16:09:53 +05:30
David Newswanger a01aa6e9df Fix structured output not supported in nxos_pim_interface (#28125) 
* fixed unstructured error

* fix unit tests so they accept commands in dictionary form
 2017-08-14 12:34:05 +05:30
Trishna Guha aef4e3d8fa fix nxos_snapshot (#27993) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-08-11 12:16:37 -04:00
Peter Sprygada 17a259a163 fixes command to be sent over nxapi for nxos_file_copy (#28029) 
fixes #27347
 2017-08-11 12:14:52 -04:00
Nathaniel Case 0464a21a85 Fix nxos_snmp_contact, others (#28000) 
* Fix nxos_snmp_contact

Fixes #27714

* Fix nxos_snmp_community

Fixes #27711

* Fix nxos_install_os

Fixes #27604

* Update nxos_ntp_auth

Fixes #27521

* Fix nxos_igmp_snooping

Fixes #27501
 2017-08-11 10:12:43 -04:00
David Newswanger d0485779e8 nxos_smu: fix Structured output unsupported error in nxapi (#27976) 
* fixed structured output unsupported error
 2017-08-10 14:12:15 -04:00
Nathaniel Case ed8a5af3dc nxos_bgp: Fix idempotence for event-history (#27329) 
* Fix idempotence for event-history

* `event-history detail` defaults to `False`, the rest to `size_small`
 2017-08-10 08:55:43 -04:00
Nathaniel Case a78f3faa6c nxos_bgp_neighbor_af does not want required_together (#26370) 
* nxos_bgp_neighbor_af does not want required_together

* fixup tests

* Fix max_prefix_* issues

* Require address-family

* Fix idempotency for next_hop_third_party

* Fix idempotency for allowas_in*

* Fix idempotency for *_in and *_out

* Reorder command generation again

`default` is first, then `max-prefix`, then booleans
 2017-08-09 15:54:34 -04:00
Peter Sprygada 4fb114174b fixes Traceback generated by nxos_igmp module (#27869) 
* fixes Traceback generated by nxos_igmp module

* update module code to reflect review comments

* doh!...remove q
 2017-08-09 15:52:37 -04:00
saichint 14186af558 Fix for nxos_ospf idempotent issue (#27913) 2017-08-09 11:25:35 -04:00
Nathaniel Case 01dda25e0f fix nxapi transport in nxos_snmp_location (#27849) 
* fix nxapi transport in nxos_snmp_location

* Appease Shippable
 2017-08-09 09:44:02 -04:00
Nathaniel Case c1bf74283e Network load_config: Capture configuration output and display as warnings (#27851) 
* Capture configuration output and display as warnings

* Don't break on nxapi

nxapi errors very loudly instead, so no need to muck about with warnings
 2017-08-09 09:43:04 -04:00
saichint babec35faa Fix nxos_vtp_password and nxos_vrf_interface for remove idempotency tests (#27724) 
* fixes for 27600 27676

* add sanity tests
 2017-08-08 12:40:22 -04:00
Peter Sprygada 0b67ef4232 fixes #27527 (#27868) 2017-08-08 10:12:02 -06:00
rahushen 441376c754 Fix #26024: suppress_fib_pending imdepotence for nxos_bgp (#27862) 2017-08-07 21:08:46 -04:00
Mike Wiebe 65cf31e1ce Fix nxos_interface_ospf idempotence issue (#27783) 
* Add tests and fix 27167

* Add modify test
 2017-08-07 13:54:31 -04:00
Nathaniel Case b9e80b6117 nxos_vrf_interface cleanup (#27642) 
* Update RETURN, results, & execute_show_command
 2017-08-07 10:57:45 -04:00
Trishna Guha edb5760723 nxos_vpc doc update to handle confirmation prompt (#27796) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-08-05 11:05:38 +05:30
rahushen e0f482a8c5 Fixes #27340 - make indent consistent for nxos_config (#27652) 2017-08-03 07:09:31 -04:00
Nathaniel Case 123b5e222f nxos_bgp_neighbor fixes (#27348) 
* Fix `timers` idempotency

* `shutdown` is not documented as having a `default` option

* dynamic_capability is the inverse of BOOL_PARAMS
 2017-08-02 11:07:46 -04:00
Nathaniel Case b93878b685 Minor cleanup to nxos_vrrp (#27593) 
* Safe changes

* Fold `[0]` into `execute_show_command()`

We only ever execute one command, so only return the one response

* Streamline `results`
 2017-08-02 08:46:44 -04:00
saichint 37392318a6 fix nxos_vlan and nxos_switchport issues (#27505) 2017-08-01 16:27:12 -04:00
Trishna Guha 407dc2dc68 fix nxos_vrf removal failure (#27547) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-08-01 11:51:25 -06:00
Dennis Israelsson d7202e6155 Add fabricpath support for nxos_vlan (#26013) 
* Add files via upload

Fix for issue #25720

* nxos_vlan fabricpath (#25720)

Fix for issue #25720

* Add files via upload

* Add files via upload

* Delete nxos_vlan.py

* Add files via upload

* Add files via upload
 2017-08-01 11:27:47 -06:00