Commit Graph

3596 Commits (2fe150a1ef4abd3308b94a084f3d9cf516a420cc)

Author SHA1 Message Date
Zim Kalinowski 6d0b0f8338 added missing facts in container instance (#45380)
* returning tags in container instance facts

* small fix
2018-09-10 01:10:40 -04:00
Stéphane Travassac 0f7ef141ad VMware: more detail error on bad http code return for vmware_guest_file_operation.py (#41897)
Fixes: #41721
2018-09-10 09:21:00 +05:30
Zim Kalinowski 376082c37d added tags to webapp documentation (#45375) 2018-09-10 09:51:17 +08:00
kryptsi 1325ddbb0b VMware: new plugin for setting an object's role/permission (#39988) 2018-09-07 19:03:58 +05:30
Ryan Brown 4d7e261074 [aws] Remove deprecated `ec2_vpc_dhcp_options_facts` alias of ec2_vpc_dhcp_option_facts (#45322) 2018-09-07 09:09:28 -04:00
Ryan Brown 8d363f7693 [aws] Remove deprecated `ec2_vpc_dhcp_options` alias of ec2_vpc_dhcp_option (#45321) 2018-09-07 09:08:09 -04:00
Pieter Avonts 1a810f8f11 VMware: Rewrite get_resource_pool method for correct resource_pool selection (#39792)
* rewrite get_resource_pool method for correct resource_pool selection
* only keep name if path is given for cluster, esxi_hostname or resource_pool
* Revert "only keep name if path is given for cluster, esxi_hostname or resource_pool"
* This reverts commit 50293ec763c024b0eaceac5d775ccc0ad3ff8bd7.
* if the name argument contains a path, only use the last part for matching
* remove path from cluster argument in tests
* remove find_objs in favour of reusing find_obj with an extra folder argument
* fix find_obj ignoring first if name is not given
2018-09-07 18:23:26 +05:30
Abhijeet Kasurde fd985db72d
VMware: Refactor disc logic (#39285)
* Refactoring related to network device
* Assign unique random temporary key while creating SCSI or/and IDE controller devices
* Add testcase for this change

Fixes: #38679

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-07 17:04:02 +05:30
Armin Ranjbar Daemi 778b789c84 VMware: New module vmware_guest_vnc (#36282) 2018-09-07 16:00:37 +05:30
John Imison 38a714833d pyvcloud requirement documented (#44347) 2018-09-07 01:01:49 -04:00
Mike Klebolt b14206a578 [New Module] vmware_guest_tools_upgrade (#42698)
New module to manage VMware guest tools upgrade.
2018-09-07 09:54:50 +05:30
Abhijeet Kasurde e653a93044
VMware: update vmware_local_role_manager with action (#44566)
With this fix user can add, remove and set privileges to
an existing role with privileges.

Fixes: #44391

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-07 09:33:50 +05:30
kobayashi 46856b0747 Delete parameters created with init (#42777) 2018-09-07 09:31:34 +05:30
Sloane Hertel 8b341619ae Fix backwards compatibility without providing prefix since boto3 does more parameter validation than boto (#45308)
Use .get() instead of assuming a rule has a Transitions or Filter key (both of which are optional)
2018-09-06 15:44:26 -04:00
Andrew McGilvray 71c4355d58 check for change of role arn in ecs task definition (#44942)
* check role arn for ecs task definition

If the task role in a ECS task definition changes ansible should create a new revsion of the task definition.
2018-09-06 15:43:30 -04:00
Vinay Dandekar 4ce09ea62d [aws] ec2_metadata_facts URL encode the metadata URL to avoid errors (#43394)
- If a field in the URL has a space it would result in a 400 without making it URL safe
- Fixes #42371 and #43378
2018-09-06 15:24:25 -04:00
Rob 7e426b0381 Fix health check configurations being ignored - #43244 (#43247)
* Fix health check configurations being ignored - #43244

* Ensure health_check_protocol is not None before check

* Simplify long indented if statement
2018-09-06 15:19:04 -04:00
Ryan Brown 079299db4d
[aws] ec2_group multi-account and peered VPC bugfix (#45296)
* Add tests to replicate bug #44788 

* Handle when userId is same account due to in-account peering

* Module defaults for main.yml

* Turn off VPC peering tests in CI
2018-09-06 15:06:03 -04:00
Adam Miller 12e2d6d01f fix version number because this was backported
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-09-06 11:35:39 -07:00
Rémy Léone eb882e4b01 Select image facts by region (#44965) 2018-09-06 11:57:43 -04:00
Abhijeet Kasurde 270082a51c
VMware: Handle systemError in host_config_manager (#45263)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-06 08:59:53 +05:30
Yunge Zhu 2955d7cd1b add publish url in webapp facts output (#45131)
* add publish url in webapp facts output

* update name

* fix test
2018-09-06 08:04:09 +08:00
chalupaa 1f3e7ea061 [aws] lambda_policy fix update when principal is an account number (#44871)
Fix KeyError on update when principal is an account number
2018-09-05 14:59:14 -04:00
Ryan Brown 20f21779d3
Fix ec2_group for numbered protocols (GRE) (#42765)
* Fix spurious `changed=True` when int is passed as tag

* Fix for all AWS module using compare_aws_tags

* Handle improperly stringified protocols and allow inconsistency between None/-1 on non-tcp protocols

* Add integration test that reproduces the same bug

* Return false if the comparsison is not equal
2018-09-05 13:34:26 -04:00
Sloane Hertel 038fd0d0f2 elb_target_group - prevent a KeyError exception (#45169)
Ensure ports to integers after allowing the key 'Targets' to be available in params
2018-09-05 12:50:03 -04:00
Ryan Brown 9d1bf32825
[aws] Add suboptions to aws_application_scaling_policy (#43042)
* [aws] Add suboptions to aws_application_scaling_policy

Fixes #42917

* Remove any suboptions that are None
2018-09-05 12:35:26 -04:00
Zim Kalinowski a5e2b60870 adding tags to keyvault (#45145) 2018-09-05 16:21:15 +08:00
Abhijeet Kasurde 9c1ba18607
VMware: Return Disk UUID information (#45157)
This fix adds feature of disk uuid for given virtual machine disk.

Fixes: #45149

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-05 10:35:13 +05:30
Rémy Léone f6303ba5df Add user_data/cloud-init support for scaleway_compute module (#42697) 2018-09-04 19:56:05 -04:00
Dougal Seeley a6c97f2243 ec2_vpc_route_table - allow routes to be created if the CIDR already exists but its 'Origin' is 'EnableVgwRoutePropagation' (which cannot be replaced). (#43417)
Fixes #43415
2018-09-04 11:18:33 -04:00
Abhijeet Kasurde b3b65d16b8
Handle special service where package is not available (#45155)
There are several services e.g. vmware-fdm, which does not have package name and
package description which will raise a error if queried for.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-04 17:03:44 +05:30
Abhijeet Kasurde 885ee25375
Documentation for several VMware modules (#45153)
* Added return for vmware_host_config_facts
* Added return for vmware_host_service_facts
* Correct typo in vmware_portgroup_facts

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-04 16:37:14 +05:30
Zim Kalinowski b1b90faf96 added missing resource_group description in return value (#45143) 2018-09-04 04:04:51 -04:00
Zim Kalinowski e7ec1ef59c adding tags to container instance (#45142) 2018-09-04 03:56:10 -04:00
Zim Kalinowski 1f8635fbd9 Virtual machine facts - retrieving instance view (#45128) 2018-09-04 11:25:01 +08:00
Zim Kalinowski 9bd702ef37 vm size idempotence (#45108) 2018-09-04 09:41:41 +08:00
Madhura-CSI a4663d8e73 New module for azure custom image facts (#42102)
* new module for azure custom image facts

* added facts in aliases, corrected assertion

* simplified managed disk id struct

* updated ansible version
2018-09-04 02:28:01 +08:00
Zim Kalinowski 9b28319020 adding container instance facts (#43326) 2018-09-03 15:51:42 +08:00
vpopescu b4c148b6ea fixed boolean value for zone (#41974) 2018-09-03 10:20:16 +08:00
Matt Martz f89d873698
Stub out modules scheduled for 2.8 removal (#44985)
* Remove modules scheduled for 2.8

* Add changelog and porting guide

* Skip docs test on removed modules

* Don't link to removed modules
2018-08-31 16:27:32 -05:00
Rémy Léone 5cf9644003 Add an user facts module for Online (#44709) 2018-08-31 14:02:40 -04:00
Martin Nečas c2fa0d2c4b recator uploading disk and downloading (#43635) 2018-08-31 03:23:52 -04:00
Martin Nečas d5ebc3e0ec add quota_name to ovirt permition module (#44713) 2018-08-31 03:00:13 -04:00
Martin Nečas c65c841ef3 add ovirt attach host devic (#44714) 2018-08-31 03:00:04 -04:00
Ubuntu 7d81de2516 updates to azure_rm_sqlfirewallrule
updates to azure_rm_sqlfirewallrule

small fixes

move sql client to common

adding state

fixed sample

fixed sanity

fixed aliases

removed unnecessary object

removed unused resource_group

changed group to less crowdy

tags

no tags on firewall rule
2018-08-30 21:54:58 -07:00
Yuwei Zhou b7d614df78 add auto scale module (#41533)
* add autoscale modules

* add test alias
2018-08-30 21:18:56 -07:00
Roman Belyakovsky 4f70eb3e26 ec2_vol_facts: moved to boto3 (#43348)
* ec2_vol_facts: moved to boto3

* vol_facts: formatting fixes

* vol_facts: formatting fixes

* vol_facts: added integration tests

* vol_facts: improved integration tests

* vol_facts: integration tests, fixed ami

* vol_facts: integration tests, fixed ami

* vol_facts: refactor, post-review update

* vol_facts: implemented pagination

* vol_facts: pep8 style fix

* CI IAM policy requirements fix

* Tests fixed, added to unsupported, removed empty files

* removed shippable alias
2018-08-31 13:50:17 +10:00
Sloane Hertel 113336d6f1 rds_instance module and tests (#43789)
* Add functions to retrieve the allowed and required parameters for boto3 client methods

* Add custom waiter for stopping an RDS DB instance

* Add rds_instance module

* Add rds_instance integration tests

* address requested changes from ryansb

* address requested changes from willthames

* address requested changes from dmsimard

* Fix final snapshots

Fix idempotence with already-deleting DB instances

Remove unused import from module_utils/aws/core.py

Consolidate function to get all boto3 client method parameters and the subset of required parameters

* Add some additional rds_instance integration tests

* Add some common functions to module_utils/aws/rds

* Move common code out of rds_instance

* Remove hardcoded engine choices and require the minimum boto3

* Document wait behavior

* Provide a list of valid engines in the error message if it is invalid

Add supported methods to whitelist

Remove AWSRetry around waiter

Wait for a less crazy amount of time

Remove unused variables

* Add a test for an invalid engine option

* pep8

* Missed adding a method to the whitelist

* Use retries

* Fix some little things

* Fix more things

* Improve error message

* Support creating cross-region read replicas

* Remove unused imports

* Add retry when getting RDS instance

* Soft-check required options so module fails properly when options are missing

* Fix mariadb parameter version

* Fix cross-region read_replica creation and tests

* fix modify tests

* Fix a modification test

* Fix typo

* Remove test for option_group_name that exists for this account but may not for others and added as a TODO to do properly
2018-08-31 12:17:02 +10:00
Yunge Zhu ef8ce6b2f3 remove wrong alias on secret_value (#44877) 2018-08-31 09:36:52 +08:00
Adam 00368a432f Update lightsail.py (#44902) 2018-08-30 13:24:04 -05:00
Jeff Geerling c3e526bf2c helm: Improve documentation style and readability. (#44876) 2018-08-30 11:06:35 -05:00
yaakov kuperman 6b7ea5078f [aws] New module: elb_target_facts (#43565)
* initial source of the elb_target_facts module, which gathers all
registered ELBv2 target groups for a given instance id

* updating

* initial dump of tests

* updating docs, adding AWSRetry decorators

* updating tests

* More brush up, some refactoring

* updating for sanity tests

* removing extra space

* updating elb_target_facts to use a new name for the return value, not return a fact, and use instance variables for the AWS connections.  updating tests to go along with that

* updating classes to be 'new-style' classes
2018-08-30 10:47:28 -04:00
Zim Kalinowski bd866ed69a adding container registry facts (#43325) 2018-08-30 17:56:12 +08:00
Yunge Zhu b731732616 add azure_rm_webapp_facts module (#43631)
* add webapp facts module

* remove certified

* remove useless argument

* add tests

* return curated output

* add description of return value, move test to webapp folder

* fix lint

* fix lint

* fix lint

* fix test

* fix bug

* fix test, will get all webapp with same tag created by previous test

* fix test

* fix test

* fix test

* add properties description, refine return name

* refine properties, add request_id when exception

* fix bug

* update doc, add publish profile

* fix error

* flatten properties, add option for return publish profile
2018-08-30 17:49:06 +08:00
Zim Kalinowski 78eb4724a0 Adding sql client to common (#44825) 2018-08-30 12:44:36 +08:00
Lachlan Cooper 1e7ab24e40 Fix minor issues with docker_login docs (#35081)
* Fix typos in docker_login reauthorize parameter

* Remove note about docker_login email address

Docker Hub no longer requires an email address.

* Remove check for email parameter with Docker Hub

This is no longer required, so login should not fail if it's not provided.
2018-08-30 05:33:39 +01:00
Hai Cao ccb7909cc5 [new module] Azure Traffic Manager profile module (#43812)
* add traffic manager client and models in azure_rm_common
- add traffic manager management client
- import traffic manager models to 'traffic_manager_models' proprety
- azure.mgmt.trafficmanager doesn't have models(), so use direct import
for now

* add traffic manager facts module

* add traffic manager module

* add integration test for two modules

* fix package info in requirements

* fix sanity check

* fix monitor config default value

* fix facts module doc

* move model import into module

* resolve comments except seprating endpoint

* remove endpoint operation

* fix test after removing endpoint operation

* change module name to azure_rm_trafficmanagerprofile/facts

* fix sanity test

* seperate endpoint into delegate module

* fix typo

* fix lint

* fix lint

* fix test

* fix test

* resolve comments

* fix test

* fix test

* fix test

* fix bug in return

* resolve comments

* fix lint

* fix lint

* add sample in endpoint module
2018-08-30 14:18:53 +10:00
lwm fbcdf8ba5b Linode: Mark 'name' as required. Fixes #29785 (#44699)
* Mark 'name' parameter as required.

Closes https://github.com/ansible/ansible/issues/29785.

* Add the `linode-python` dependency for unit tests.

* Add unit test for linode name parameter.

* Add note about where to find required arguments.

Closes https://github.com/ansible/ansible/issues/44696.
2018-08-30 05:09:21 +02:00
Felix Fontein 1dcf52c8fe docker_container: improving idempotency (#44808)
* Only handle cpu_shares, volume_driver, auto_remove as in _host_config().

* Don't compare log_options (resp restart_retries) if log_driver (resp restart_policy) is not specified.

* Warn that log_options (resp restart_retries) is ignored if log_driver (resp restart_policy) is not specified.
2018-08-29 21:07:32 -04:00
Felix Fontein 63fde92b60 Improve description of default network removal. (#44861) 2018-08-29 20:53:26 -04:00
Jasper Aorangi 2541a8c494 azure_rm_virtualmachine: Add 'accept_terms' for accepting terms when deploying paid marketplace images (#44701)
azure_rm_storageaccount: Add 'StandardSSD_LRS', and choices to correct unrelated sanity error
2018-08-29 17:14:44 -07:00
Constantin Bugneac 23adc3ecf1 added RETURN structure to _ec2_remote_facts.py (#26041) 2018-08-29 18:22:09 -04:00
Alex Stephen 56fa7eeb41 [gcp] gcp_compute_backend_service changes (#44796) 2018-08-29 16:41:37 -04:00
Rémi REY cd7c946ea5 modules/terraform: add support of backend configuration (#44860)
This patch adds a new `backend_config` parameter that allows to provide the
-backend-config parameter during the terraform init command.

The option allows to dynamically set the backend information, like the s3 bucket name
and statefile name.
2018-08-29 16:26:19 -04:00
Zim Kalinowski ed2cd40a5b
adding new clients to common (#44804)
* adding new clients to common

* container registry and instance clients to the common

* fix problem
2018-08-29 13:52:18 +08:00
Yunge Zhu 2bd0a66c08 start/stop/restart azure webapp (#44498)
* add webapp start/stop/restart

* disable test with facts

* fix lint

* fix lint

* fix check mode

* rename power_action to app_state

* refine names of choices

* fix renaming bug
2018-08-29 07:41:11 +08:00
René Moser dd953dbe96
cs_template: implement update and revamp (#37015) 2018-08-28 19:55:21 +02:00
Felix Fontein ed22efb2a6 Clarify that uninstalling docker-py can break docker (and vice versa). (#43238) 2018-08-28 17:53:43 +01:00
Alex Stephen d38bccfc3e New GCP Module: gcp_compute_router (#42796) 2018-08-28 12:35:20 -04:00
Yoan Blanc cf61510f48 cs instance root_disk size update resizes the root volume (#43817)
* cloudstack: resize volume on root_disk_size changes

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
Reviewed-by: Marc-Aurèle Brothier <m@brothier.org>

* fixup! cloudstack: resize volume on root_disk_size changes

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

* fixup! fixup! cloudstack: resize volume on root_disk_size changes

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

* cs_instance: rename flag to allow_root_disk_shrink

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
2018-08-28 12:19:43 -04:00
Jasper Aorangi 56ea56f2b5 azure_rm_networkinterface: Feature/dns servers (#43588)
* Working through tests and fixing dumb mistakes

* Fix sanity issues and tests. All G

* Correct type test for azure_rm_networkinterface

* azure_rm_networkinterface correct type comparison

* Post rebase cleanup

* Remove erroneous reference to dns_servers
2018-08-28 08:59:45 -07:00
Alex Stephen 0972d37872 New GCP Module: gcp_spanner_database (#42799) 2018-08-28 11:58:33 -04:00
Alex Stephen 48de2cf214 New GCP Module: gcp_spanner_instance (#42800) 2018-08-28 11:57:59 -04:00
Alex Stephen 6d548d405b New GCP Module: gcp_sql_user (#42803) 2018-08-28 11:57:36 -04:00
Alex Stephen e9c9ccc561 Bug fixes for gcp_dns_resource_record_set (#42832) 2018-08-28 11:56:43 -04:00
Alex Stephen 473b6dbe8a New GCP Module: gcp_sql_instance (#42802) 2018-08-28 11:56:13 -04:00
Alex Stephen 26cf8fafb5 New GCP Module: gcp_sql_database (#42801) 2018-08-28 11:55:44 -04:00
Abhijeet Kasurde fe8af27e5d
VMware: new module: vmware_host_ntp_facts (#44306)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-28 06:25:46 -07:00
Felix Fontein fabba43da7 docker_container: fix check mode for container creation (#42380)
* Create copy of HostConfig object before adding it to results.

* Create general sanitize function in docker_common. Using it for all return values of docker_container.

* Make Python 2.6 compatible.
2018-08-28 12:03:33 +01:00
Jean-Bernard Jansen 390a08c781 azure_rm_virtualmachine : fix support for existing machines provisioned with a managed image (#32984) 2018-08-28 17:33:16 +08:00
Yunge Zhu d5cbb53f5a fix linux webapp java framework bug (#44753)
* fix linux web app java linux_fx_version

* fix lint

* fix test

* resolve comments
2018-08-28 15:55:19 +08:00
Zim Kalinowski 289be02224 Revert "fix linux web app java linux_fx_version (#44715)" (#44750) 2018-08-28 14:32:40 +08:00
Yunge Zhu 661172ab40
fix linux web app java linux_fx_version (#44715) 2018-08-28 13:14:11 +08:00
Rémi REY 26be68dd1c modules/terraform: Quote the variable values in the command line (#43493)
* modules/terraform: Quote the variable values in the command line

Fixes: #43492

* fix six import
2018-08-27 14:38:21 -04:00
Chris Adams 23eb4f2093 ec2: add "IAM Role" to instance_profile_name
The AWS API and console docs are inconsistent about whether EC2 instances have IAM profiles or roles. Things which follow the API tend to use profile but the console uses “IAM Role”. This adds that term to the help text so it's searchable.

+label: docsite_pr
2018-08-27 10:06:15 -04:00
Dag Wieers b6b36276a4 Clean up BOTMETA.yml (#44574)
This PR includes:
- Removal of maintainers that are listed as author in the module
- Removal of entries that do not extend the original author list
- Move ignored-statement to namespace/directory (where useful)
- In some cases, fix the authors-list or add missing github id

We end up with a list of exceptions/additions and a large set of
namespace/directory maintainers or team of maintainers.

Some entries could be further improved by discussing with some
maintainers.
2018-08-24 19:43:35 -04:00
Toshio Kuratomi b2932a41b0 Fixup removed and deprecated modules
* Removed modules no longer have documentation
  Decided this was causing people to think that modules were supported
  even after being removed.  This change is a new strategy to have the
  error message trying to use a removed module point people to the older
  documentation.

* Add stubs for modules removed in 2.7
  These are freshly removed so we want people who are still using them
  when they upgrade Ansible to have a hint as to where to find information
  on how to port.

* Finish properly undeprecating include
  include was undeprecated earlier but not all of the pieces that marked
  it as deprecated were reverted.  This change fixes the remaining
  pieces
2018-08-24 15:37:13 -07:00
Ryan S. Brown 990e95eb57 Fix ec2_instance synopsis. Fixes #44641 2018-08-24 15:44:28 -04:00
Dario Zanzico d0bf38ab6a New module: docker_swarm_service (#19229) 2018-08-24 15:40:40 -04:00
Aren 9db3e597f3 state: present added in docs (#37197)
* state: present added in docs

* atomic_container.py docs now match argspec, enforce test
2018-08-24 12:22:18 -05:00
Sloane Hertel d3f5238c09
Fix dangerous elb_application_lb state (#44646)
* elb_application_lb: fix dangerous default of deleting an ELB if state is omitted by changing state to default to present to be more like other AWS modules
2018-08-24 13:04:15 -04:00
Yanis Guenane 03e3a0b202 scaleway: Introduce scaleway_organization_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane 809aa2d767 scaleway: Introduce scaleway_snapshot_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane 2cfcfd6dc9 scaleway: Introduce scaleway_server_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane 5c65ba62aa scaleway: Introduce scaleway_ip_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane d62f63b680 scaleway: Introduce scaleway_image_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane e4e6569cc9 scaleway: Introduce scaleway_volume_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane 4bdec575c0 scaleway: Introduce scaleway_security_group_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Rémy Léone 8f9d55529d scaleway: Refactor modules 2018-08-24 18:15:45 +02:00
Pierre Gaxatte 3122860f22 Update os_server docs when removing an instance (#41963)
When removing an instance via its ID, it is not clearly explained that one should use the `name` parameter.

Also a simple example is provided.

+label: docsite_pr
2018-08-24 10:42:25 -04:00