Commit Graph

215 Commits (3635c59b23e16862946ba0deb054195c42316fbc)

Author SHA1 Message Date
Piotr Olczak d08604eebc Fixes 45136 and 47641: (#47642)
- each volume in the volume_info should be identified by VOLUME_NAME:OWNING_VSERVER:AGGREGATE
- do not fail if external key management is enabled
2018-12-12 06:47:19 -05:00
Chris Archibald 62dd1fe29e New options of na_ontap_aggregate (#48906)
* add new options for na_ontap_aggregate

* add gpl line

* remove dup option

* Put files in wrong directory

* change unit test to match the request from PR 48941

* Changed for review comments

* pep8
2018-12-02 14:24:27 +00:00
Chris Archibald 73348ae32d Fixes for na_ontap_cluster_peer (#48329)
* Fixes for na_ontap_cluster_peer, incorporating review comments, version, etc.
2018-11-29 16:22:02 -06:00
Corey Wanless 6cd321ed8e sets admin_password to no_log (#46604) 2018-11-29 12:17:15 +00:00
Chris Archibald 6dc6538eef Bug fixes for na_ontap_fcp (#48583) 2018-11-28 20:03:44 +00:00
Abhijeet Kasurde bc3e7bbeba
E325 Removal - Part II (#49196)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-28 13:55:52 +05:30
John R Barker 97e2fa4953
Bulk module author 2 (#48955)
* Bulk fix DOCUMENTATION.author (Part 2)
2018-11-21 10:32:42 +00:00
Chris Archibald 0cf88809ef Fix argument_spec for modules that are using the old version (#47693)
* Use correct argument spec
2018-11-05 16:56:59 +00:00
Chris Archibald 8f3e297d7d NetApp bugfix for na_ontap_snapmirror (#47621)
* Bug fixes for Snapmirror

* Bug fixes for Snapmirror
2018-11-05 16:53:29 +00:00
Abhijeet Kasurde ab86051c0b Misc fixes for several errors
* aci: Correct usage in fail_json
* Fixes incorrect usage of fail_json
* Raise exception object

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-02 12:14:57 -04:00
Abhijeet Kasurde 3568dc512a
Misc typo fixes (#47699)
fixes requried to required

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-28 12:35:30 +05:30
Matt Clay c24c19594e
Enable pylint rules and fix exposed bugs. (#47219)
* Resolve invalid-unary-operand-type.

* Resolve raising-format-tuple.

* Resolve stop-iteration-return.

* Use disable comment instead of fixing logic.

The affected line in _find_address_range will only fail on Python 3.7
and later if the function is called with an empty address list. As an
internal method it is never called in this way, making it a non-issue
for use via public methods.

Using a comment to disable the rule in favor of an ignore.txt entry
since there are no plans to change the logic in the code itself. This
will also prevent any potential future issues being added in other
parts of the code when updating it based on upstream changes.
2018-10-19 08:32:52 -07:00
Matt Clay 37b013aca3
Enable additional pylint rules and resolve issues found. (#47221)
* Resolve unneeded-not.
* Resolve global-at-module-level.
* Resolve useless-import-alias.
* Resolve bad-whitespace.
* Resolve global-variable-not-assigned.
* Resolve logging-not-lazy.
* Resolve comparison-with-itself.
2018-10-18 13:38:08 -07:00
Sandra McCann 4513298971 Change netapp ontap and elementsw modules to certified (#46974)
* netapp ontap and elementsw modules to certified
2018-10-12 13:54:23 -05:00
Chris Archibald e3ec9e5345 NetApp Bulk Doc changes (#45856)
* Doc changes

* fix ansibot issue

* Fix spacing
2018-09-19 20:26:28 +01:00
ndswartz 205693a3f9 Update short description for NetApp E-Series modules. (#45820)
Update short description according to new standards
2018-09-19 11:23:49 -04:00
Jesse Morgan ac4e611f9d not sure if typo or pun. (#45358)
Fixing header to be SNapshot
+label: docsite_pr
2018-09-07 13:29:19 -04:00
ndswartz b0cee34ca1 Fixed netapp_e_lun_mapping options for backwards compatibilitiy (#44769)
* Fixed netapp_e_lun_mapping options for backwards compatibility.

Readd lun and target_type as deprecated options.

Note: lun and target_type were removed in patch #44666 since they were
no longer needed for the logic in the module.  However, this cause will
cause existing playbooks utilizing these options to break.

* Add lun specification and target_type verification for netapp_e_lun_mapping
2018-08-30 05:35:57 +01:00
Chris Archibald 7cded31ec9 Depreciate elementsw modules (#44792)
* rename deprecated files
2018-08-29 17:51:52 +01:00
Chris Archibald 408868ed49 fix bug and documentation issue (#44793) 2018-08-28 18:32:44 -04:00
Chris Archibald 15886b1d56 Adding na_ontap_autosupport.py Module (#44178)
* Adding na_ontap_autosupport.py Module
2018-08-28 22:41:05 +01:00
Piotr 966c87e111 ONTAP information gathering module (#43888)
* ONTAP information gathering module
2018-08-28 19:05:06 +01:00
Chris Archibald adc5f0c89d Adding ontap_node.py Module (#44211)
* Adding ontap_node.py Module

* Change Short Description

* documentation changes
2018-08-28 18:41:49 +01:00
Chris Archibald 0f31111809 Adding ElementSW Snapshot Restore Module (#43973)
* Adding ElementSW Snapshot Restore Module
2018-08-28 18:41:02 +01:00
Chris Archibald e2ae09117d Adding ElementSW Volume Clone (#43983)
* Adding ElementSW Volume Clone
2018-08-28 18:40:34 +01:00
Chris Archibald ab9c4ab82d Adding ontap_cluster_peer.py Modules (#44189)
* Add ontap_cluster_peer.py Modules
2018-08-28 18:39:59 +01:00
Michael Price 70fd1ec130 Define module for NetApp E-Series iSCSI targets (#40632)
Create a new module for managing E-Series iSCSI targets.
2018-08-28 18:38:43 +01:00
ndswartz d31e25acbd Define netapp_e_mgmt_interface storage module. (#42519)
* Define netapp_e_mgmt_interface storage module.

The netapp_e_mgmt_interface module provides management configuration for
e-series storage array interface points including remote ssh access, NTP
and DNS services.

This patch also includes integration and unit tests.

* Fix netapp_e_mgmt_interface ssh option documentation and name/channel exclusivity.
2018-08-28 17:50:21 +01:00
Chris Archibald 26545ecac9 Adding ElementSW Drive Module (#43968)
* Adding ElementSW Drive Module
2018-08-28 17:43:10 +01:00
Michael Price 054b87acb8 Define module for managing E-Series email alerts (#42643)
Email alerts can be enabled for an E-Series system to provide
information to interested users by email when a warning or critical
level event occurs on the system. This module will allow a system owner
to configure whether or not system alerts are enabled, and who will
receive them.
2018-08-28 17:40:51 +01:00
Michael Price 97157cf876 New module for managing NetApp E-Series iSCSI Interfaces (#39877)
* New module for NTAP E-Series iSCSI Interfaces

Define a new module for configuring NetApp E-Series iSCSI interfaces.

* Improve netapp_e_iscsi_interface integration tests

Restructured integration test to set all iscsi ports to disabled, then
defines the ports either statically or with dhcp, next updates the ports
with the other definition type (static <-> dhcp), and lastly disables
all ports.  Each netapp_eseries_iscsi_interface call is verified with the
array.
2018-08-28 17:39:14 +01:00
Michael Price f781f341a2 Define NetApp E-Series ASUP module (#41153)
* Define NetApp E-Series ASUP module

ASUP, or Auto-Support, is a mechanism that allows NetApp support
to receive information on the status of E-Series storage-systems
in order to proactively resolve issues for customers. This module
gives customers the ability to tune ASUP settings to their liking,
including disabling the feature entirely.

* Improved testing for netapp_e_asup module

Added coverage and validation to asup integration and unit testing
2018-08-28 17:05:25 +01:00
Chris Archibald f101cb0226 Adding na_ontap_disks.py Module (#44192)
* Adding na_ontap_disks.py Disk
2018-08-28 16:43:55 +01:00
Piotr 5d31c5b2c6 na_ontap_motd module added (#44756)
* state=present is now default

* assign whole params dictionary to a single variable
2018-08-28 16:42:37 +01:00
Chris Archibald 61d8266442 Adding ontap_firewall_policy.py Module (#44198)
* Adding ontap_firewall_policy.py Module
2018-08-28 16:02:05 +01:00
Michael Price 1f2ae0d4cd Define a module for managing E-Series settings (#41010)
There are multiple settings that are defined at a global level for
E-Series systems, but don't necessarily fit with anything else. This
module is intended to provide a place to encapsulate those.
2018-08-28 15:38:53 +01:00
Chris Archibald fe14781a46 Add ontap_command.py Module (#44190)
* Add ontap_command.py Module
2018-08-28 15:32:48 +01:00
Chris Archibald 45e7b2da98 Adding ElementSW Snapshot Module (#43972)
* Adding ElementSW Snapshot Module
2018-08-28 15:27:44 +01:00
Chris Archibald c29acc7ee1 Adding ElementSW Node Module (#43971)
* Adding ElementSW Node Module
2018-08-28 15:27:09 +01:00
Chris Archibald 6b0fa954f4 Adding ElementSW Network Interfaces Module (#43970)
* Adding ElementSW Network Interfaces Module
2018-08-28 15:26:18 +01:00
Chris Archibald 12c7656268 Adding ElementSW Cluster Module (#43965)
* Adding ElementSW Cluster Module
2018-08-28 15:22:20 +01:00
Chris Archibald 09c7d1c4b9 Adding ElementSW check Connection Module (#43963)
* Adding ElementSW check Connections Module
2018-08-28 15:21:45 +01:00
Chris Archibald 9acbd81e02 Adding ElementSW Admin users Module (#43959)
* Adding ElementSW Admin users Module
2018-08-28 15:19:52 +01:00
Chris Archibald 1377019951 Adding ElementSW account Module (#43958)
* Adding ElementSW account Module
2018-08-28 15:19:11 +01:00
Chris Archibald 6d592dc505 adding ElementSW access group module (#43957)
* adding access group

* Change short description
2018-08-28 15:18:18 +01:00
ndswartz cf41415bdf Define netapp_e_auditlog storage module. (#42535)
This module allows NetApp E-Series storage system's audit-log feature to be configured.
2018-08-28 14:11:33 +01:00
ndswartz 7eda94dc8d Defined netapp_e_syslog storage module (#42421)
Module allows syslog server configuration on NetApp E-Series storage arrays.
2018-08-28 13:22:36 +01:00
Michael Price feb212b0a1 Define module for managing LDAP for E-Series (#42356)
This module will allow users to manage LDAP authentication domains for
accessing E-Series systems.
2018-08-28 13:00:19 +01:00
Milan Zink 2fab2d5775 Fixing missing modify_client_match function and get_export_policy_rule function logic (#44164) 2018-08-28 12:25:16 +01:00
ndswartz 06a5e6ae0f Improve netapp_e_lun_mapping module and documentation (#44666) 2018-08-28 12:13:32 +01:00
Chris Archibald 047fddfe86 Adding ElementSW Ldap Module (#43969)
* Adding ElementSW Ldap Module
2018-08-28 11:45:57 +01:00
Chris Archibald 3820c3351b Adding ElementSW Backup Module (#43960)
* Adding ElementSW Backup Module
2018-08-24 17:23:03 +01:00
Chris Archibald 319bd2de5f Adding ElementSW Cluster Pair Module (#43967)
* Adding ElementSW Cluster Pair
2018-08-24 17:21:52 +01:00
Chris Archibald 448db900dd Adding ElementSW SnapShot Schedule Module (#43974)
* Adding ElementSW SnapShot Schedule Module
2018-08-24 17:18:02 +01:00
Chris Archibald d7efcc4161 Adding ElementSW Vlan Module (#43981)
* Adding ElementSW Vlan Module
2018-08-24 17:16:51 +01:00
Chris Archibald 790e19804b Adding ElementSW Volume Module (#43982)
* Adding ElementSW Volume Module
2018-08-24 17:16:07 +01:00
Chris Archibald caeae632ba Adding ElementSW Volume Pair (#43984)
* Adding ElementSW Volume Pair
2018-08-24 16:30:15 +01:00
Chris Archibald 54c526991a Adding ontap_cg_snapshot.py Module (#44181)
* Adding ontap_cg_snapshot.py Module

* Fix issues
2018-08-24 16:29:21 +01:00
Chris Archibald ea5a455656 Adding ontap_dns.py Module (#44193)
* Adding ontap_dns.py Module

* Change Short Description
2018-08-24 16:23:34 +01:00
Chris Archibald 3c69ad7104 Adding ontap_fcp.py Module (#44197)
* Adding ontap_fcp.py Module
2018-08-24 16:21:33 +01:00
Chris Archibald b85458d8ba Adding ontap_snapmirror.py Module (#44215)
* Adding ontap_snapmirror.py Module
2018-08-24 16:02:35 +01:00
Chris Archibald d6e74adbf5 Adding ontap_software_update.py Module (#44218)
* Adding ontap_software_update.py Module
2018-08-24 16:01:37 +01:00
Chris Archibald 0534b7ad38 Adding ontap_svm_options.py Module (#44220)
* Adding ontap_svn_options.py Module
2018-08-24 15:58:45 +01:00
Michael Price ad91793428 Resolve issues in NetApp E-Series Host module (#39748)
* Resolve issues in NetApp E-Series Host module

The E-Series host module had some bugs relating to the update/creation
of host definitions when iSCSI initiators when included in the
configuration. This patch resolves this and other minor issues with
correctly detecting updates.

There were also several minor issues found that were causing issues with
truly idepotent updates/changes to the host definition.

This patch also provides some unit tests and integration tests to help
catch future issues in these areas.

fixes #28272

* Improve NetApp E-Series Host module testing

The NetApp E-Series Host module integration test lacked feature test
verification to verify the changes made to the storage array.

The NetApp E-Series rest api was used to verify host create, update, and
remove changes made to the NetApp E-Series storage arrays.
2018-08-24 15:44:59 +01:00
njferrant 507d6e241e NetApp: return lun info for na_ontap_lun_map module (#42961)
* return lun details for na_ontap_lun_map

return lun details for na_ontap_lun_map.py and added return value documentation
2018-08-24 15:37:28 +01:00
♫ Christian Krause ♫ d779eb1f15 doc: fixes the the repetitions (#43937)
Wow, this does not seem to be an uncommon misspelling. Might be there
are some left that span over two lines. I noticed the one in the git
module and then used `grep -rw 'the the'` to find some more.
2018-08-22 21:53:30 +02:00
Chris Archibald 65c9280935 Adding ontap_vserver_peer.py Module (#44226)
* Adding ontap_vserver_peer.py Module
2018-08-22 12:04:26 -07:00
Chris Archibald 5b19d67873 Bug Fixes for ontap_export_policy_rule.py (#44196)
* Bug Fixes for ontap_export_policy_rule.py
2018-08-22 09:03:56 -07:00
Chris Archibald 86a48af541 Bug Fixes for ontap_net_routes.py (#44208) 2018-08-22 09:01:28 -07:00
Chris Archibald 66ae8efbd3 Bug Fixes for ontap_net_vlan.py (#44209)
* Bug Fixes for ontap_net_vlan.py

* Make documentation changes
2018-08-22 09:00:49 -07:00
Chris Archibald 00143d806c Bug Fixes for ontap_snapshot.py (#44216) 2018-08-22 08:59:26 -07:00
Chris Archibald 8c97aa948e Bug Fixes for ontap_interface.py (#44200) 2018-08-17 14:37:15 -07:00
Chris Archibald 4abfbe06c4 Bug fixes for ontap_broadcast_domain_ports.py (#44180) 2018-08-17 14:37:03 -07:00
Chris Archibald 87467dcd66 Bug fixes for ontap_cifs.py (#44182) 2018-08-17 14:36:07 -07:00
Chris Archibald cfa304a400 Bug fixes for ontap_cifs_acl.py (#44184) 2018-08-17 14:35:43 -07:00
Chris Archibald 3d0287aca1 Bug Fixes for ontap_cluster.py: (#44187) 2018-08-17 14:35:14 -07:00
Chris Archibald 9dac00fabe Bug fixes for na_ontap_cluster_ha.pya (#44188) 2018-08-17 14:34:53 -07:00
Chris Archibald 9858f41628 Bug Fixes for ontap_iscsi.py (#44201) 2018-08-17 14:30:53 -07:00
Chris Archibald 5778691923 Bug Fixes for ontap_job_schedule.py (#44202) 2018-08-17 14:30:33 -07:00
Chris Archibald cd2af0b06a Bug Fixes for ontap_license.py (#44203) 2018-08-17 14:29:42 -07:00
Chris Archibald 060d444949 Bug Fixes for ontap_lun_map.py (#44205) 2018-08-17 14:29:33 -07:00
Chris Archibald d220859190 Bug fixes for ontap_net_ifgrp.py (#44206) 2018-08-17 14:27:07 -07:00
Chris Archibald 6e527c3f36 Bug Fixes for ontap_net_port.py (#44207) 2018-08-17 14:26:26 -07:00
Chris Archibald 4be72ba60d Bug Fixes for ontap_ntp.py (#44212) 2018-08-17 14:23:16 -07:00
Chris Archibald 44f4f54fe5 Bug Fixes for ontap_service_processor_network.py (#44214) 2018-08-17 14:22:33 -07:00
Chris Archibald 270bc58b84 Bug Fixes for ontap_snmp.py (#44217) 2018-08-17 14:15:38 -07:00
Chris Archibald bc4f7abe96 Bug fixes for ontap_ucadapter.py (#44221) 2018-08-17 09:21:59 -04:00
Chris Archibald 374a22f4c7 Bug Fixes for ontap_user.py (#44222) 2018-08-17 09:21:50 -04:00
Chris Archibald 6d97765688 Bug Fixes for ontap_user_role.py (#44223) 2018-08-17 09:11:39 -04:00
Chris Archibald d0a7147224 Bug fixes for ontap_volume_clone.py (#44225) 2018-08-17 09:11:28 -04:00
Chris Archibald ef037480a4 Bug fixes for na_ontap_aggregate.py (#44177)
* Bug fixes for na_ontap_aggregate.py

* Fix issues
2018-08-16 08:48:11 -04:00
Chris Archibald 92a2207199 Bug Fixes for ontap_broadcast_domain.py (#44179)
* Bug Fixes for ontap_broadcast_domain.py

* Fix issues
2018-08-16 08:37:06 -04:00
Chris Archibald d22d97d420 Bug fixes for ontap_cifs_server.py (#44185)
* Bug fixes for ontap_cifs_server.py

* Fix issues
2018-08-16 08:36:47 -04:00
Chris Archibald 5f29735987 Bug Fixes for ontap_lun.py (#44204)
* Bug Fixes for ontap_lun.py

* Fix issues
2018-08-16 08:36:28 -04:00
Chris Archibald aa44158f80 Bug Fixes for ontap_nfs.py (#44210)
* Bug Fixes for ontap_nfs.py

* Fix issues
2018-08-16 08:36:19 -04:00
Chris Archibald 11a3d56faf Bug Fixes for ontap_svm.py (#44219)
* Bug Fixes for ontap_svm.py

* Fix issues
2018-08-16 08:36:10 -04:00
Chris Archibald 38680f38f1 Bug Fixes for ontap_volume.py (#44224)
* Bug Fixes for ontap_volume.py

* Fix issues
2018-08-16 08:36:00 -04:00
Chris Archibald b83565958e Bug fixes for ontap_export_policy.py (#44194)
* Adding ontap_export_policy.py Module

* fix issues
2018-08-16 08:15:32 -04:00
Chris Archibald 1d0dede9de Bug Fixes for ontap_igroup.py (#44199)
* Bug Fixes for ontap_igroup.py

* Fix issues
2018-08-16 08:15:23 -04:00
Chris Archibald 95b86dea88 Bug fixes for ontap_qtree.py (#44213)
* Bug fixes for ontap_qtree.py

* Fix issues
2018-08-16 08:15:13 -04:00